From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F340137757F for ; Tue, 9 Jun 2026 16:11:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781021492; cv=none; b=SpULKH1Y16h3HxRPUnTiVKaBq5DKQC+uGeU1Y0AuAaAjOz6s5cLj3AdcT0qxKTMoG0u3S/dQSwFbsDrRT9GmwQl1hAdEAVa+4zfiLCRSrgD1e2JgGl+6Wk7wUgSkDkAg4TJaGu3jnh12NN3NYRa331ZyK9zqxGtOQA7wXV9hmZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781021492; c=relaxed/simple; bh=jXG4PWaLculkrGCMBKvWz16KNAcutg4Nr5j1HtVB5eg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DInIGTBLEs3ixSGKCpFzb8xyCtKAicnSUbh2L7VV1VB20+I6SpZCJm9QCJqe77LPn/nZWhAl+7p6W/78hsEswPyPeCZH8RRwjMM7ulkgp2q/Txy241zFPK93MJAJFYJoahtSSGpzGfz4t4KbjVYKfnQIgS9rUt5K+Mt7z827knw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=V7pDje4C; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="V7pDje4C" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-486badc02ecso1313751b6e.3 for ; Tue, 09 Jun 2026 09:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1781021490; x=1781626290; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6Uz2/S8q1bGzYbvjOi+dd2PPF/EKmkqQlSRIaTmPAZs=; b=V7pDje4C/TPP9dOXrkrUmIJyPOX2Tgt2po9yO+HDfanfobPPFHQvO+TEft9fudDwXx Hny8Wzv52/+9yD3uJlopCz99QtIGSl6slQ7l4haqjD54Xuhye03LU56L1mTHWk0amcVm 9VoXYW768TeLL8ktqn418Vbsor7U3kN/eeTBXkwJ+o8GmPf7Kdg4tIhZpZXHlwOgz8zR LjNP9iJWSUfCDhVtJ1DSvfzqxOHxNgDt+4tnUXXZmx+TKkAZhXYB5caok0X3gyz60SfS w3P+OdpB5ZxCKLRgVvHVzIT5l94n5NrpLF44a5o6gSsGrsHtJl2i+9Bi2dOnKnDc6NKt FzEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781021490; x=1781626290; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6Uz2/S8q1bGzYbvjOi+dd2PPF/EKmkqQlSRIaTmPAZs=; b=eKuT3F60Et+Y9/tIZ/kP7/3+9VLLyvTHAD67dQskSMzr7vDp4p0ctEuTf8dAiz4cif iHoYFmns6iNJx49wI02KOGj41373dQEZQWpxW4KMhoyoHgVVJzoYuQjgXcbFevdTHSpw CqQCMTMtbipEA43UocToDouCl3RqVzWuRipDDgTAx2Z5sv1QaG47b2pbArnm2oHbV/rx zzAzRNPqleEFJkTYkheed9OUxLFLZ/WsnIwSJZUjvqvOhkxV/ZQP0EuwjaXz9xmhzgJ7 mIWEB+uPNrMgLON5Y1wUwy8lqVN2CO27UR5WJxExZ0+rm79lXoKqrWvDkJiLCLS/0HYw nQsA== X-Forwarded-Encrypted: i=1; AFNElJ8bMHtLI7vlsPuzE1xoZz2d31azmb5k9N9op2ThLVivjo8CCbNgXrABLqyts8hPMAr2Z9gJBBEin6NE@vger.kernel.org X-Gm-Message-State: AOJu0Yw0aLvHomji5zkmhBraMEGPR/pipLmM38H0HGdp7vumuwQVr+mj tPp6aHnYcf2ORRvh/rBrLBu+EHih5KrX7qYvFWxP1qN82ECsxbwUUHcAqM0X51rss6w= X-Gm-Gg: Acq92OEqItJCARf9uDLhsp7EYue7hpa1UjE55Ty5WSUwzr9SyiXMxuqsU2aO9Qbyq38 esn9pD3HMi9ck+snR8O+lmUdv+DnPazWtMwziY1UuDa2gm3LdVI5OpuqAIqBSB4s7Oav8bi4pQx tJosMvUbN+SGjcF1cPlxCXMwzbnPJP2sXr57fSdX/s1EQQlNMV2NWlJ4/2OuUWGvweWU2VevM/p qHn8djzVOdKnw+n7gDsYEmvaJ9QJemjrOVly5jQY1wmJIxmLxlJYpxsrwOcjoIPfZ9/G4Zz5Jxb 6XMOmln+vF2EG6MEFdL5MQGSeN1wlYid3azoP6mW2BAzYZ4GbkjTLXDOIIwL8zThmOK+pI8GNUH DQWL+QBCfy63UrtPi6FLO+L8CGktHX1EU6tXmDGsDko8U+tw92kXmwjJgP2Ro0w4jFVWPu/K9F4 OG44Y78B26DrUM2tDMndYSfYOI8uvIh1PNH9xnt4rB3+qF X-Received: by 2002:a05:6808:1301:b0:47b:d07b:ecac with SMTP id 5614622812f47-4868db2e306mr15084950b6e.10.1781021490024; Tue, 09 Jun 2026 09:11:30 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4865b91f944sm16430240b6e.9.2026.06.09.09.11.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 09:11:29 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 11:11:27 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] PCI: spacemit-k1: Add Spacemit K3 PCIe host controller support To: Manivannan Sadhasivam , Inochi Amaoto Cc: Jingoo Han , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Christian Bruel , Vincent Guittot , Senchuan Zhang , Nam Cao , Siddharth Vadapalli , Randolph Lin , Andy Shevchenko , Vidya Sagar , Neil Armstrong , Gustavo Pimentel , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, Yixun Lan , Longbin Li References: <20260517014841.254085-1-inochiama@gmail.com> <20260517014841.254085-6-inochiama@gmail.com> Content-Language: en-US From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/9/26 9:18 AM, Manivannan Sadhasivam wrote: > On Sun, May 17, 2026 at 09:48:40AM +0800, Inochi Amaoto wrote: >> The PCIe controller on Spacemit K3 is almost a standard Synopsys >> DesignWare PCIe IP with extra link and reset control. Unlike >> the PCIe controller on K1, this controller supports external MSI >> interrupt controller and can use multiple PHYs at the same time. >> >> Add driver to support PCIe controller on Spacemit K3 PCIe. >> >> Signed-off-by: Inochi Amaoto >> --- >> drivers/pci/controller/dwc/Kconfig | 4 +- >> drivers/pci/controller/dwc/pcie-spacemit-k1.c | 169 ++++++++++++++++++ >> 2 files changed, 171 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig >> index f2fde13107f2..fae971ecd876 100644 >> --- a/drivers/pci/controller/dwc/Kconfig >> +++ b/drivers/pci/controller/dwc/Kconfig >> @@ -439,7 +439,7 @@ config PCIE_SOPHGO_DW >> Sophgo SoCs. >> >> config PCIE_SPACEMIT_K1 >> - tristate "SpacemiT K1 PCIe controller (host mode)" >> + tristate "SpacemiT K1/K3 PCIe controller (host mode)" > > Can you just say 'SpacemiT PCIe controller (host mode)"? I believe I asked Alex > while adding K1 support and he said this driver might not support future IP > revisions, but here we are. (Sorry if I said that in error.) Will this be K1 and K3 only? If so what you say is fine, but I agree with Mani, if it's going to also form the basis of K5 (or whatever) just make it "SpacemiT". And probably change the Kconfig symbol to PCIE_SPACEMIT. -Alex >> depends on ARCH_SPACEMIT || COMPILE_TEST >> depends on HAS_IOMEM >> select PCIE_DW_HOST >> @@ -447,7 +447,7 @@ config PCIE_SPACEMIT_K1 >> default ARCH_SPACEMIT >> help >> Enables support for the DesignWare based PCIe controller in >> - the SpacemiT K1 SoC operating in host mode. Three controllers >> + the SpacemiT K1/K3 SoC operating in host mode. Three controllers >> are available on the K1 SoC; the first of these shares a PHY >> with a USB 3.0 host controller (one or the other can be used). >> . . .