[PATCH v2 1/4] ARM: dts: st: stm32mp157c-emstamp: drop incorrect vref_ddr property

[PATCH v2 1/4] ARM: dts: st: stm32mp157c-emstamp: drop incorrect vref_ddr property

[Krzysztof Kozlowski]

The STPMIC1 PMIC vref_ddr regulator does not support over-current
protection, according to bindings and Linux driver:

  stm32mp157c-emsbc-argon.dtb: stpmic@33: regulators:vref_ddr: 'regulator-over-current-protection' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. None
---
 arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi b/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
index fd89542c69c9..f8e9980ed3d4 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
@@ -310,7 +310,6 @@ vdda: ldo6 {
 			vref_ddr: vref_ddr {
 				regulator-name = "vref_ddr";
 				regulator-always-on;
-				regulator-over-current-protection;
 			};
 
 			bst_out: boost {
-- 
2.34.1

[PATCH v2 2/4] ARM: dts: st: stm32mp157c-emstamp: correct regulator-active-discharge

[Krzysztof Kozlowski]

The "regulator-active-discharge" property is uint32, not boolean:

  stm32mp157c-emsbc-argon.dtb: stpmic@33: regulators:pwr_sw1:regulator-active-discharge: True is not of type 'array'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. None
---
 arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi b/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
index f8e9980ed3d4..009209ca673b 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
@@ -320,7 +320,7 @@ bst_out: boost {
 			vbus_otg: pwr_sw1 {
 				regulator-name = "vbus_otg";
 				interrupts = <IT_OCP_OTG 0>;
-				regulator-active-discharge;
+				regulator-active-discharge = <1>;
 			};
 
 			vbus_usbh: pwr_sw2 {
-- 
2.34.1

Re: [PATCH v2 2/4] ARM: dts: st: stm32mp157c-emstamp: correct regulator-active-discharge

[Alexandre TORGUE]

On 7/30/23 19:49, Krzysztof Kozlowski wrote:
> The "regulator-active-discharge" property is uint32, not boolean:
> 
>    stm32mp157c-emsbc-argon.dtb: stpmic@33: regulators:pwr_sw1:regulator-active-discharge: True is not of type 'array'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. None
> ---
>   arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi b/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
> index f8e9980ed3d4..009209ca673b 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
> @@ -320,7 +320,7 @@ bst_out: boost {
>   			vbus_otg: pwr_sw1 {
>   				regulator-name = "vbus_otg";
>   				interrupts = <IT_OCP_OTG 0>;
> -				regulator-active-discharge;
> +				regulator-active-discharge = <1>;
>   			};
>   
>   			vbus_usbh: pwr_sw2 {

Applied on stm32-next.

Thanks.
Alex

[PATCH v2 3/4] ARM: dts: st: ste: switch to enable-gpios

[Krzysztof Kozlowski]

The recommended name for enable GPIOs property in regulator-gpio is
"enable-gpios".  This is also required by bindings:

  ste-hrefv60plus-stuib.dtb: regulator-gpio: Unevaluated properties are not allowed ('enable-gpio' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. Correct subject prefix: AMR->ARM
---
 arch/arm/boot/dts/st/ste-href520-tvk.dts       | 2 +-
 arch/arm/boot/dts/st/ste-hrefprev60-stuib.dts  | 2 +-
 arch/arm/boot/dts/st/ste-hrefprev60-tvk.dts    | 2 +-
 arch/arm/boot/dts/st/ste-hrefv60plus-stuib.dts | 2 +-
 arch/arm/boot/dts/st/ste-hrefv60plus-tvk.dts   | 2 +-
 arch/arm/boot/dts/st/ste-snowball.dts          | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/st/ste-href520-tvk.dts b/arch/arm/boot/dts/st/ste-href520-tvk.dts
index 4201547c5988..7f661f8f13ad 100644
--- a/arch/arm/boot/dts/st/ste-href520-tvk.dts
+++ b/arch/arm/boot/dts/st/ste-href520-tvk.dts
@@ -28,7 +28,7 @@ vmmci: regulator-gpio {
 			  2900000 0x0>;
 
 		gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>;
-		enable-gpio = <&gpio2 14 GPIO_ACTIVE_HIGH>;
+		enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 
 		pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/st/ste-hrefprev60-stuib.dts b/arch/arm/boot/dts/st/ste-hrefprev60-stuib.dts
index dfc933214c1a..a29e345a43d3 100644
--- a/arch/arm/boot/dts/st/ste-hrefprev60-stuib.dts
+++ b/arch/arm/boot/dts/st/ste-hrefprev60-stuib.dts
@@ -27,7 +27,7 @@ vmmci: regulator-gpio {
 			  2900000 0x0>;
 
 		gpios = <&tc3589x_gpio 18 GPIO_ACTIVE_HIGH>;
-		enable-gpio = <&tc3589x_gpio 17 GPIO_ACTIVE_HIGH>;
+		enable-gpios = <&tc3589x_gpio 17 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 	};
 
diff --git a/arch/arm/boot/dts/st/ste-hrefprev60-tvk.dts b/arch/arm/boot/dts/st/ste-hrefprev60-tvk.dts
index 75506339a93c..1968bd143114 100644
--- a/arch/arm/boot/dts/st/ste-hrefprev60-tvk.dts
+++ b/arch/arm/boot/dts/st/ste-hrefprev60-tvk.dts
@@ -27,7 +27,7 @@ vmmci: regulator-gpio {
 			  2900000 0x0>;
 
 		gpios = <&tc3589x_gpio 18 GPIO_ACTIVE_HIGH>;
-		enable-gpio = <&tc3589x_gpio 17 GPIO_ACTIVE_HIGH>;
+		enable-gpios = <&tc3589x_gpio 17 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 	};
 };
diff --git a/arch/arm/boot/dts/st/ste-hrefv60plus-stuib.dts b/arch/arm/boot/dts/st/ste-hrefv60plus-stuib.dts
index 52c56ed17ae6..7a5b6aa1db5b 100644
--- a/arch/arm/boot/dts/st/ste-hrefv60plus-stuib.dts
+++ b/arch/arm/boot/dts/st/ste-hrefv60plus-stuib.dts
@@ -29,7 +29,7 @@ vmmci: regulator-gpio {
 			  2900000 0x0>;
 
 		gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>;
-		enable-gpio = <&gpio5 9 GPIO_ACTIVE_HIGH>;
+		enable-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 
 		pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/st/ste-hrefv60plus-tvk.dts b/arch/arm/boot/dts/st/ste-hrefv60plus-tvk.dts
index 2db2f8be8b03..d5af3f375161 100644
--- a/arch/arm/boot/dts/st/ste-hrefv60plus-tvk.dts
+++ b/arch/arm/boot/dts/st/ste-hrefv60plus-tvk.dts
@@ -29,7 +29,7 @@ vmmci: regulator-gpio {
 			  2900000 0x0>;
 
 		gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>;
-		enable-gpio = <&gpio5 9 GPIO_ACTIVE_HIGH>;
+		enable-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 
 		pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/st/ste-snowball.dts b/arch/arm/boot/dts/st/ste-snowball.dts
index 9a3d6546399d..27c2ec51e732 100644
--- a/arch/arm/boot/dts/st/ste-snowball.dts
+++ b/arch/arm/boot/dts/st/ste-snowball.dts
@@ -229,7 +229,7 @@ vmmci: regulator-gpio {
 			/* GPIO228 SD_SEL */
 			gpios = <&gpio7 4 GPIO_ACTIVE_HIGH>;
 			/* GPIO217 MMC_EN */
-			enable-gpio = <&gpio6 25 GPIO_ACTIVE_HIGH>;
+			enable-gpios = <&gpio6 25 GPIO_ACTIVE_HIGH>;
 			enable-active-high;
 
 			regulator-min-microvolt = <1800000>;
-- 
2.34.1

[PATCH v2 4/4] ARM: dts: st: stih407: drop max-duty-cycle

[Krzysztof Kozlowski]

"max-duty-cycle" property was removed in the commit f747a1fe7848
("regulator: pwm-regulator: Remove obsoleted property"):

  stih418-b2199.dtb: pwm-regulator: Unevaluated properties are not allowed ('max-duty-cycle' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. Correct subject prefix: AMR->ARM
---
 arch/arm/boot/dts/st/stih407-family.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/st/stih407-family.dtsi b/arch/arm/boot/dts/st/stih407-family.dtsi
index 3f58383a7b59..29302e74aa1d 100644
--- a/arch/arm/boot/dts/st/stih407-family.dtsi
+++ b/arch/arm/boot/dts/st/stih407-family.dtsi
@@ -111,7 +111,6 @@ pwm_regulator: pwm-regulator {
 		regulator-min-microvolt = <784000>;
 		regulator-max-microvolt = <1299000>;
 		regulator-always-on;
-		max-duty-cycle = <255>;
 		status = "okay";
 	};
 
-- 
2.34.1

Re: [PATCH v2 4/4] ARM: dts: st: stih407: drop max-duty-cycle

[Patrice CHOTARD]

On 7/30/23 19:49, Krzysztof Kozlowski wrote:
> "max-duty-cycle" property was removed in the commit f747a1fe7848
> ("regulator: pwm-regulator: Remove obsoleted property"):
> 
>   stih418-b2199.dtb: pwm-regulator: Unevaluated properties are not allowed ('max-duty-cycle' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. Correct subject prefix: AMR->ARM
> ---
>  arch/arm/boot/dts/st/stih407-family.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/st/stih407-family.dtsi b/arch/arm/boot/dts/st/stih407-family.dtsi
> index 3f58383a7b59..29302e74aa1d 100644
> --- a/arch/arm/boot/dts/st/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/st/stih407-family.dtsi
> @@ -111,7 +111,6 @@ pwm_regulator: pwm-regulator {
>  		regulator-min-microvolt = <784000>;
>  		regulator-max-microvolt = <1299000>;
>  		regulator-always-on;
> -		max-duty-cycle = <255>;
>  		status = "okay";
>  	};
>  
Acked-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks 
Patrice

Re: [PATCH v2 4/4] ARM: dts: st: stih407: drop max-duty-cycle

[Patrice CHOTARD]

On 7/30/23 19:49, Krzysztof Kozlowski wrote:
> "max-duty-cycle" property was removed in the commit f747a1fe7848
> ("regulator: pwm-regulator: Remove obsoleted property"):
> 
>   stih418-b2199.dtb: pwm-regulator: Unevaluated properties are not allowed ('max-duty-cycle' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. Correct subject prefix: AMR->ARM
> ---
>  arch/arm/boot/dts/st/stih407-family.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/st/stih407-family.dtsi b/arch/arm/boot/dts/st/stih407-family.dtsi
> index 3f58383a7b59..29302e74aa1d 100644
> --- a/arch/arm/boot/dts/st/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/st/stih407-family.dtsi
> @@ -111,7 +111,6 @@ pwm_regulator: pwm-regulator {
>  		regulator-min-microvolt = <784000>;
>  		regulator-max-microvolt = <1299000>;
>  		regulator-always-on;
> -		max-duty-cycle = <255>;
>  		status = "okay";
>  	};
>  


Applied on sti-next

Thanks
Patrice

Re: [PATCH v2 4/4] ARM: dts: st: stih407: drop max-duty-cycle

[Krzysztof Kozlowski]

On 16/08/2023 08:54, Patrice CHOTARD wrote:
> 
> 
> On 7/30/23 19:49, Krzysztof Kozlowski wrote:
>> "max-duty-cycle" property was removed in the commit f747a1fe7848
>> ("regulator: pwm-regulator: Remove obsoleted property"):
>>
>>   stih418-b2199.dtb: pwm-regulator: Unevaluated properties are not allowed ('max-duty-cycle' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Changes in v2:
>> 1. Correct subject prefix: AMR->ARM
>> ---
>>  arch/arm/boot/dts/st/stih407-family.dtsi | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/st/stih407-family.dtsi b/arch/arm/boot/dts/st/stih407-family.dtsi
>> index 3f58383a7b59..29302e74aa1d 100644
>> --- a/arch/arm/boot/dts/st/stih407-family.dtsi
>> +++ b/arch/arm/boot/dts/st/stih407-family.dtsi
>> @@ -111,7 +111,6 @@ pwm_regulator: pwm-regulator {
>>  		regulator-min-microvolt = <784000>;
>>  		regulator-max-microvolt = <1299000>;
>>  		regulator-always-on;
>> -		max-duty-cycle = <255>;
>>  		status = "okay";
>>  	};
>>  
> 
> 
> Applied on sti-next

This is still not in linux-next (one month later!).

I don't know what happened here, maybe patch got lost (thus let me know
if I am expect to apply it, which should not be the norm, but meh...).
If it is not the case and for example your tree is not in next, then
maybe this will be of use:
https://social.kernel.org/notice/Aa2Gbxj4cyyuUb0P8S
https://lpc.events/event/17/contributions/1498/

:)

Best regards,
Krzysztof

Re: [PATCH v2 4/4] ARM: dts: st: stih407: drop max-duty-cycle

[Patrice CHOTARD]

On 9/24/23 20:53, Krzysztof Kozlowski wrote:
> On 16/08/2023 08:54, Patrice CHOTARD wrote:
>>
>>
>> On 7/30/23 19:49, Krzysztof Kozlowski wrote:
>>> "max-duty-cycle" property was removed in the commit f747a1fe7848
>>> ("regulator: pwm-regulator: Remove obsoleted property"):
>>>
>>>   stih418-b2199.dtb: pwm-regulator: Unevaluated properties are not allowed ('max-duty-cycle' was unexpected)
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> ---
>>>
>>> Changes in v2:
>>> 1. Correct subject prefix: AMR->ARM
>>> ---
>>>  arch/arm/boot/dts/st/stih407-family.dtsi | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/st/stih407-family.dtsi b/arch/arm/boot/dts/st/stih407-family.dtsi
>>> index 3f58383a7b59..29302e74aa1d 100644
>>> --- a/arch/arm/boot/dts/st/stih407-family.dtsi
>>> +++ b/arch/arm/boot/dts/st/stih407-family.dtsi
>>> @@ -111,7 +111,6 @@ pwm_regulator: pwm-regulator {
>>>  		regulator-min-microvolt = <784000>;
>>>  		regulator-max-microvolt = <1299000>;
>>>  		regulator-always-on;
>>> -		max-duty-cycle = <255>;
>>>  		status = "okay";
>>>  	};
>>>  
>>
>>
>> Applied on sti-next
> 
> This is still not in linux-next (one month later!).

Hi Krzysztof

Yes i saw that, i submitted my pull request to ML but it hasn't be merged.
I just notice i forgot to add soc@kernel.org in the sender list, my bad :-(
I expect to resubmit it for v6.7.

Patrice

> 
> I don't know what happened here, maybe patch got lost (thus let me know
> if I am expect to apply it, which should not be the norm, but meh...).
> If it is not the case and for example your tree is not in next, then
> maybe this will be of use:
> https://social.kernel.org/notice/Aa2Gbxj4cyyuUb0P8S
> https://lpc.events/event/17/contributions/1498/
> 
> :)
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH v2 4/4] ARM: dts: st: stih407: drop max-duty-cycle

[Krzysztof Kozlowski]

On 25/09/2023 08:50, Patrice CHOTARD wrote:
> 
> 
> On 9/24/23 20:53, Krzysztof Kozlowski wrote:
>> On 16/08/2023 08:54, Patrice CHOTARD wrote:
>>>
>>>
>>> On 7/30/23 19:49, Krzysztof Kozlowski wrote:
>>>> "max-duty-cycle" property was removed in the commit f747a1fe7848
>>>> ("regulator: pwm-regulator: Remove obsoleted property"):
>>>>
>>>>   stih418-b2199.dtb: pwm-regulator: Unevaluated properties are not allowed ('max-duty-cycle' was unexpected)
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>
>>>> ---
>>>>
>>>> Changes in v2:
>>>> 1. Correct subject prefix: AMR->ARM
>>>> ---
>>>>  arch/arm/boot/dts/st/stih407-family.dtsi | 1 -
>>>>  1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/st/stih407-family.dtsi b/arch/arm/boot/dts/st/stih407-family.dtsi
>>>> index 3f58383a7b59..29302e74aa1d 100644
>>>> --- a/arch/arm/boot/dts/st/stih407-family.dtsi
>>>> +++ b/arch/arm/boot/dts/st/stih407-family.dtsi
>>>> @@ -111,7 +111,6 @@ pwm_regulator: pwm-regulator {
>>>>  		regulator-min-microvolt = <784000>;
>>>>  		regulator-max-microvolt = <1299000>;
>>>>  		regulator-always-on;
>>>> -		max-duty-cycle = <255>;
>>>>  		status = "okay";
>>>>  	};
>>>>  
>>>
>>>
>>> Applied on sti-next
>>
>> This is still not in linux-next (one month later!).
> 
> Hi Krzysztof
> 
> Yes i saw that, i submitted my pull request to ML but it hasn't be merged.
> I just notice i forgot to add soc@kernel.org in the sender list, my bad :-(
> I expect to resubmit it for v6.7.

So if you have them in your tree, why they are not in linux-next? Soc
has nothing to do with it.

Best regards,
Krzysztof

Re: [PATCH v2 1/4] ARM: dts: st: stm32mp157c-emstamp: drop incorrect vref_ddr property

[Alexandre TORGUE]

On 7/30/23 19:49, Krzysztof Kozlowski wrote:
> The STPMIC1 PMIC vref_ddr regulator does not support over-current
> protection, according to bindings and Linux driver:
> 
>    stm32mp157c-emsbc-argon.dtb: stpmic@33: regulators:vref_ddr: 'regulator-over-current-protection' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. None
> ---
>   arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi b/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
> index fd89542c69c9..f8e9980ed3d4 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp157c-emstamp-argon.dtsi
> @@ -310,7 +310,6 @@ vdda: ldo6 {
>   			vref_ddr: vref_ddr {
>   				regulator-name = "vref_ddr";
>   				regulator-always-on;
> -				regulator-over-current-protection;
>   			};
>   
>   			bst_out: boost {


Applied on stm32-next.

Thanks.
Alex