From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH resend] sh_eth: add R8A7743/5 support
Date: Tue, 27 Sep 2016 21:08:56 +0300 [thread overview]
Message-ID: <b04bbb5d-fda2-f11b-1ff7-1502dcc31e53@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdWq_714eP2q7V6AgopKu-mNx0GLUzyemad2H_ZcFt15ug@mail.gmail.com>
On 09/27/2016 10:35 AM, Geert Uytterhoeven wrote:
>> Add support for the first two members of the Renesas RZ/G family, RZ/G1M/E
>> (also known as R8A7743/5). The Ether core is the same as in the R-Car gen2
>> SoCs, so will share the code/data with them...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>> --- net-next.orig/drivers/net/ethernet/renesas/Kconfig
>> +++ net-next/drivers/net/ethernet/renesas/Kconfig
>> @@ -27,7 +27,7 @@ config SH_ETH
>> Renesas SuperH Ethernet device driver.
>> This driver supporting CPUs are:
>> - SH7619, SH7710, SH7712, SH7724, SH7734, SH7763, SH7757,
>> - R8A7740, R8A777x and R8A779x.
>> + R8A7740, R8A774x, R8A777x and R8A779x.
>
> Surely "R8A7740" is covered by "R8A774x"? :-)
It should be, yes -- but 7740 has completely different Ether core than the
RZ/G family. I can fix this if you want...
> However, the "x" is not a real wildcard (also for '7x and '9x), as the driver
> doesn't support all possible values of "x".
Well, I think for 779x it does, provided that the Ether core exists at all.
For 777x it doesn't support the SH flavour of 7778 indeed but it's not
supported by the kernel at all...
> Apart from that:
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thank you. :-)
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
next prev parent reply other threads:[~2016-09-27 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 22:23 [PATCH resend] sh_eth: add R8A7743/5 support Sergei Shtylyov
2016-09-27 7:35 ` Geert Uytterhoeven
2016-09-27 18:08 ` Sergei Shtylyov [this message]
[not found] ` <1654835.SEcvPVx4OQ-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-09-28 9:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b04bbb5d-fda2-f11b-1ff7-1502dcc31e53@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).