From: Judith Mendez <jm@ti.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <linux-mmc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Josua Mayer <josua@solid-run.com>, Moteen Shah <m-shah@ti.com>,
Hiago De Franco <hiagofranco@gmail.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena
Date: Thu, 17 Apr 2025 17:37:15 -0500 [thread overview]
Message-ID: <b051466d-534d-4e93-9ba5-52401aed82ef@ti.com> (raw)
In-Reply-To: <aAFULUo9BMf306s3@gaggiata.pivistrello.it>
Hi Francesco,
On 4/17/25 2:19 PM, Francesco Dolcini wrote:
> Hello Judith,
> thanks for the patch.
>
> On Thu, Apr 17, 2025 at 01:26:52PM -0500, Judith Mendez wrote:
>> This patch documents ti,suppress-v1p8-ena which is a flag
>> used to suppress V1P8_SIGNAL_ENA in sdhci_am654 driver. This
>> quirk is necessary to fix fail init issues across various
>> types of SD cards tested on Sitara K3 SoCs.
>
> bindings are supposed to describe the hardware, not the driver.
>
> You should rephrase the commit message and the description of the property with
> this in mind.
>
> In addition, I think that the dt-bindings is supposed to be before the driver
> patch in the series.
>
Right, will fix for v3 along with adding fixes tags.
~ Judith
next prev parent reply other threads:[~2025-04-17 22:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 18:26 [PATCH v2 0/2] Fix V1P8_SIGNAL_ENA Judith Mendez
2025-04-17 18:26 ` [PATCH v2 1/2] mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch Judith Mendez
2025-04-17 19:21 ` Francesco Dolcini
2025-04-17 18:26 ` [PATCH v2 2/2] dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena Judith Mendez
2025-04-17 19:19 ` Francesco Dolcini
2025-04-17 22:37 ` Judith Mendez [this message]
2025-04-17 19:22 ` [PATCH v2 0/2] Fix V1P8_SIGNAL_ENA Francesco Dolcini
2025-04-17 22:38 ` Judith Mendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b051466d-534d-4e93-9ba5-52401aed82ef@ti.com \
--to=jm@ti.com \
--cc=adrian.hunter@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=francesco@dolcini.it \
--cc=hiagofranco@gmail.com \
--cc=josua@solid-run.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=m-shah@ti.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox