devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Richard Acayan <mailingradian@gmail.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v6 2/5] dt-bindings: media: camss: Add qcom,sdm670-camss
Date: Thu, 31 Oct 2024 15:42:09 +0000	[thread overview]
Message-ID: <b054116e-c6a4-48c3-8162-571d653788a4@linaro.org> (raw)
In-Reply-To: <jcqgsgp4ivbokn545sy2rvfllm3vnygfpbufxagotuicacfmgd@v2hlnohlwzdf>

On 11/10/2024 15:29, Krzysztof Kozlowski wrote:
> How do you imagine writing drivers and request items by order (not by
> name) if the order is different in each flavor?

I don't think I'd be much in favour of relying on declaration order in 
the dts, favouring names to find resources instead, tbh.

The 8250 has regs that sort by address and name in the same order. For 
8280xp we preferred sort by address and you're right the interrupt 
sorting isn't consistent.

However the latest applied dts for CAMSS is sort by address/irq not sort 
by reg-name irq-name.

Unless its a NAK from yourself and Rob, that would certainly be my 
preference for any _new_ additions subsequent.

---
bod

  parent reply	other threads:[~2024-10-31 15:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11  2:37 [PATCH v6 0/5] Add SDM670 camera subsystem Richard Acayan
2024-10-11  2:37 ` [PATCH v6 1/5] dt-bindings: clock: qcom,sdm845-camcc: add sdm670 compatible Richard Acayan
2024-10-11  2:37 ` [PATCH v6 2/5] dt-bindings: media: camss: Add qcom,sdm670-camss Richard Acayan
2024-10-11  7:14   ` Vladimir Zapolskiy
2024-10-11  8:31     ` Bryan O'Donoghue
2024-10-11 14:41       ` Rob Herring
2024-10-11 15:56         ` Bryan O'Donoghue
2024-10-30 14:19         ` Vladimir Zapolskiy
2024-10-30 21:06           ` Rob Herring
2024-10-30 22:13             ` Vladimir Zapolskiy
2024-11-01  9:47               ` Krzysztof Kozlowski
2024-10-11 14:29     ` Krzysztof Kozlowski
2024-10-30 14:06       ` Vladimir Zapolskiy
2024-10-30 18:33         ` Krzysztof Kozlowski
2024-10-31 15:42       ` Bryan O'Donoghue [this message]
2024-11-01  9:17         ` Krzysztof Kozlowski
2024-11-01  9:36           ` Bryan O'Donoghue
2024-11-01  9:49             ` Krzysztof Kozlowski
2024-10-11  2:37 ` [PATCH v6 3/5] media: qcom: camss: add support for SDM670 camss Richard Acayan
2024-10-11  2:37 ` [PATCH v6 4/5] arm64: dts: qcom: sdm670: add camcc Richard Acayan
2024-10-11  2:37 ` [PATCH v6 5/5] arm64: dts: qcom: sdm670: add camss and cci Richard Acayan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b054116e-c6a4-48c3-8162-571d653788a4@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mailingradian@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).