From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5826214293 for ; Sun, 23 Jun 2024 07:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719127290; cv=none; b=kbTXLk+6wxf8uI00kYlpE5+rlUxrqTEiXJCn8zt320/OgSy1xUaTzIpJywQiMOMg3wvNtmw8I+Q4RAuDoGPjnO6wxHCct+eqqbZEmburRuWNBdmx+SqWumfyEcvtkyLnYDxr4eLg/cZP7RLlaiw278Qbj+FvaBz2v21+fyoye/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719127290; c=relaxed/simple; bh=0PNpJt/756hXIHWcZ6RXajfJLKjxBHZIhniKi0DPGys=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oISUPgRMThqBH0guKmj0iqytlF/34VH6Qmi1AzJL22YJd04HK2FetRoDyb4+VDzBlfdh7ZWhNDGX8li6EG14ppJ91wQ7OiUhqnf7Jp3C6hKS6olVo1qQgIwaSlitwoBSKUv1KcDwFz/2m/VIl/TBjvfNw/UXLxQ7ei8wExT123Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xki9LDGV; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xki9LDGV" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2ebe6495aedso33568971fa.0 for ; Sun, 23 Jun 2024 00:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719127286; x=1719732086; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3FWUfaYBqcYhCS/5Uvnh0ttEO3F1ByqHvqJF7XCQ4Q4=; b=xki9LDGV6M3T3DQc5cuyQZ73v8nopZ5sSHHAFxY+ldDGvaIMYEgB39T22FzaRotdir jGvr4+1Stm9HuuErTfQvXyacOdi8QcGea+5X+LBRB/JdXHmHIepApYyYEuiDUO0LO5Vl KIiS6n//YDhLQhOU3NQyj3+dexVgLQ2cD/nrAzK/ycDCAaCTJ13ScQzgyvH3RYt/+/dr LfaSPC0QjttzMv42sraqiowACZne7DCai0cWzfddY30y/8WaY13/H1qh83zPTvJmAd5j 6fQ/4umMRwVV6ON/Ymb4cb9n4HJ2doJkTv+Y8hWv4WPCt54GlijFE4HtyZR/awY1Hee1 hMkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719127286; x=1719732086; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3FWUfaYBqcYhCS/5Uvnh0ttEO3F1ByqHvqJF7XCQ4Q4=; b=wAyKZTnzOam44E7+2kX53sIfAFs51ep62pJkIRmFXwbdkUv9UMJhr0ln8185RciDCt 0Vot9zH27B9bWcSL70cM3A/EG50f7lVes2DdyBqBm33QNYfUo9VCRWpfdwkKNaM9CQdw SAieS1Tm0GgrtVoXMMdxFOza86EFH9d0oTarNmOGnan6pXKtTHVOero2OFUUlHy/SOty evIArwywAfUOBvnBsx8M0Cc2hDXrZSmRgwALwgfO5bsHOXtlizEA0kTqKBSpnGzydcNg uqptKSm2n2t2yELxEOsWk0Gal16ZBnzIrvw+Poltk3SCTYNC6QmPMfIEGwj8U9/28ODu 8ewA== X-Forwarded-Encrypted: i=1; AJvYcCXobm+0GcMfIyO4bzien3ilZLB6wKX92dGkLmKvHZyoAai6q7fUbxWhbff1j/agRS6v5mZFi9mTIu8WRT4GVBXfAapXoJyR5NjmJw== X-Gm-Message-State: AOJu0YwbwVV/gLQ260MiI69H5kOXiYiKr5sLrCMbRnEz51zqxhhLLHUM Ivwqur54QE+zVDxwPE/il9qNGT/R8EYyl99XprP1vTH2SAhQ6bctyIT20+HJj9JToHffm3qlqfh O X-Google-Smtp-Source: AGHT+IFsl/AVesE5GqdVzxaiFO8C793i/9TRp5i491GoOkoznjc11hdadNvKTApDx8StweAuALjNoQ== X-Received: by 2002:a05:651c:b0c:b0:2ec:5fa1:2435 with SMTP id 38308e7fff4ca-2ec5fa124e4mr1067671fa.11.1719127286470; Sun, 23 Jun 2024 00:21:26 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36638f85922sm6664834f8f.63.2024.06.23.00.21.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 00:21:25 -0700 (PDT) Message-ID: Date: Sun, 23 Jun 2024 09:21:23 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: mfd: Explain lack of child dependency in simple-mfd To: Lee Jones Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240616080659.8777-1-krzysztof.kozlowski@linaro.org> <20240620171756.GY3029315@google.com> <97b84ce1-3ed2-48a8-bed4-9a671b61cd6d@linaro.org> <20240621111000.GN1318296@google.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240621111000.GN1318296@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/06/2024 13:10, Lee Jones wrote: > On Thu, 20 Jun 2024, Krzysztof Kozlowski wrote: > >> On 20/06/2024 19:17, Lee Jones wrote: >>> On Sun, 16 Jun 2024, Krzysztof Kozlowski wrote: >>> >>>> Common mistake of usage of 'simple-mfd' compatible is a dependency of >>>> children on resources acquired and managed by the parent, e.g. clocks. >>>> Extend the simple-mfd documentation to cover this case. >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> --- >>>> Documentation/devicetree/bindings/mfd/mfd.txt | 13 +++++++------ >>>> 1 file changed, 7 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/mfd.txt b/Documentation/devicetree/bindings/mfd/mfd.txt >>>> index 336c0495c8a3..98b4340b65f3 100644 >>>> --- a/Documentation/devicetree/bindings/mfd/mfd.txt >>>> +++ b/Documentation/devicetree/bindings/mfd/mfd.txt >>>> @@ -18,12 +18,13 @@ A typical MFD can be: >>>> Optional properties: >>>> >>>> - compatible : "simple-mfd" - this signifies that the operating system should >>>> - consider all subnodes of the MFD device as separate devices akin to how >>>> - "simple-bus" indicates when to see subnodes as children for a simple >>>> - memory-mapped bus. For more complex devices, when the nexus driver has to >>>> - probe registers to figure out what child devices exist etc, this should not >>>> - be used. In the latter case the child devices will be determined by the >>>> - operating system. >>>> + consider all subnodes of the MFD device as separate and independent devices >>>> + akin to how "simple-bus" indicates when to see subnodes as children for a >>>> + simple memory-mapped bus. "Independent devices" means that children do not >>> >>> I'm not against the change, but I think it can be phased better. >>> >>> Quoting the new part and going on to explain what you mean by it doesn't >>> flow very well. Are you able to massage it so it reads a little more >>> nicely please? >> >> Does this feels better? >> >> compatible : "simple-mfd" - this signifies that the operating system >> should consider all subnodes of the MFD device as separate and >> independent devices, so not needing any resources to be provided by the >> parent device. Similarly to how "simple-bus" indicates when to see >> subnodes as children for a simple memory-mapped bus. >> >> For more complex devices, when the nexus driver has to probe registers >> to figure out what child devices exist etc, this should not be used. In >> the latter case the child devices will be determined by the operating >> system. > > Flows a lot better, yes. Sure. > > Submit it and please include the original author this time. Everything is scripted, so you ask me for additional, manual steps just to find the author and then Cc-them. I'll do it but it would be much easier if the interested party added themself as reviewer or maintainer of the binding. > Best regards, Krzysztof