* [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
@ 2022-11-21 1:54 ` Bernhard Rosenkränzer
2022-11-21 9:00 ` AngeloGioacchino Del Regno
` (3 more replies)
2022-11-21 1:54 ` [PATCH 2/9] pinctrl: stm32: " Bernhard Rosenkränzer
` (8 subsequent siblings)
9 siblings, 4 replies; 26+ messages in thread
From: Bernhard Rosenkränzer @ 2022-11-21 1:54 UTC (permalink / raw)
To: devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Remove the check for the unnecessary pins-are-numbered Devicetree property.
Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 076ae0b38e3d7..553d16703475b 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -1057,7 +1057,6 @@ int mtk_pctrl_init(struct platform_device *pdev,
struct pinctrl_pin_desc *pins;
struct mtk_pinctrl *pctl;
struct device_node *np = pdev->dev.of_node, *node;
- struct property *prop;
int ret, i;
pctl = devm_kzalloc(&pdev->dev, sizeof(*pctl), GFP_KERNEL);
@@ -1066,11 +1065,6 @@ int mtk_pctrl_init(struct platform_device *pdev,
platform_set_drvdata(pdev, pctl);
- prop = of_find_property(np, "pins-are-numbered", NULL);
- if (!prop)
- return dev_err_probe(dev, -EINVAL,
- "only support pins-are-numbered format\n");
-
node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
if (node) {
pctl->regmap1 = syscon_node_to_regmap(node);
--
2.38.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered
2022-11-21 1:54 ` [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered Bernhard Rosenkränzer
@ 2022-11-21 9:00 ` AngeloGioacchino Del Regno
2022-11-21 12:33 ` Matthias Brugger
` (2 subsequent siblings)
3 siblings, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-11-21 9:00 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Il 21/11/22 02:54, Bernhard Rosenkränzer ha scritto:
> Remove the check for the unnecessary pins-are-numbered Devicetree property.
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered
2022-11-21 1:54 ` [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered Bernhard Rosenkränzer
2022-11-21 9:00 ` AngeloGioacchino Del Regno
@ 2022-11-21 12:33 ` Matthias Brugger
2022-11-21 12:35 ` Krzysztof Kozlowski
2022-11-21 18:20 ` Kevin Hilman
3 siblings, 0 replies; 26+ messages in thread
From: Matthias Brugger @ 2022-11-21 12:33 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Remove the check for the unnecessary pins-are-numbered Devicetree property.
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 076ae0b38e3d7..553d16703475b 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -1057,7 +1057,6 @@ int mtk_pctrl_init(struct platform_device *pdev,
> struct pinctrl_pin_desc *pins;
> struct mtk_pinctrl *pctl;
> struct device_node *np = pdev->dev.of_node, *node;
> - struct property *prop;
> int ret, i;
>
> pctl = devm_kzalloc(&pdev->dev, sizeof(*pctl), GFP_KERNEL);
> @@ -1066,11 +1065,6 @@ int mtk_pctrl_init(struct platform_device *pdev,
>
> platform_set_drvdata(pdev, pctl);
>
> - prop = of_find_property(np, "pins-are-numbered", NULL);
> - if (!prop)
> - return dev_err_probe(dev, -EINVAL,
> - "only support pins-are-numbered format\n");
> -
> node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
> if (node) {
> pctl->regmap1 = syscon_node_to_regmap(node);
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered
2022-11-21 1:54 ` [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered Bernhard Rosenkränzer
2022-11-21 9:00 ` AngeloGioacchino Del Regno
2022-11-21 12:33 ` Matthias Brugger
@ 2022-11-21 12:35 ` Krzysztof Kozlowski
2022-11-21 18:20 ` Kevin Hilman
3 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-21 12:35 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel, khilman,
mcoquelin.stm32, alexandre.torgue, matthias.bgg
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Remove the check for the unnecessary pins-are-numbered Devicetree property.
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 ------
> 1 file changed, 6 deletions(-)
>
FWIW:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered
2022-11-21 1:54 ` [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered Bernhard Rosenkränzer
` (2 preceding siblings ...)
2022-11-21 12:35 ` Krzysztof Kozlowski
@ 2022-11-21 18:20 ` Kevin Hilman
3 siblings, 0 replies; 26+ messages in thread
From: Kevin Hilman @ 2022-11-21 18:20 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Bernhard Rosenkränzer <bero@baylibre.com> writes:
> Remove the check for the unnecessary pins-are-numbered Devicetree property.
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 2/9] pinctrl: stm32: Remove check for pins-are-numbered
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
2022-11-21 1:54 ` [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered Bernhard Rosenkränzer
@ 2022-11-21 1:54 ` Bernhard Rosenkränzer
2022-11-21 12:34 ` Matthias Brugger
2022-11-21 12:35 ` Krzysztof Kozlowski
2022-11-21 1:54 ` [PATCH 3/9] dt-bindings: pinctrl: mediatek,mt65xx: Make pins-are-numbered optional Bernhard Rosenkränzer
` (7 subsequent siblings)
9 siblings, 2 replies; 26+ messages in thread
From: Bernhard Rosenkränzer @ 2022-11-21 1:54 UTC (permalink / raw)
To: devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Remove the check for the unnecessary pins-are-numbered
DeviceTree property
Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
drivers/pinctrl/stm32/pinctrl-stm32.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
index cc9472b284047..1cddca506ad7e 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -1499,11 +1499,6 @@ int stm32_pctl_probe(struct platform_device *pdev)
if (!match_data)
return -EINVAL;
- if (!device_property_present(dev, "pins-are-numbered")) {
- dev_err(dev, "only support pins-are-numbered format\n");
- return -EINVAL;
- }
-
pctl = devm_kzalloc(dev, sizeof(*pctl), GFP_KERNEL);
if (!pctl)
return -ENOMEM;
--
2.38.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 2/9] pinctrl: stm32: Remove check for pins-are-numbered
2022-11-21 1:54 ` [PATCH 2/9] pinctrl: stm32: " Bernhard Rosenkränzer
@ 2022-11-21 12:34 ` Matthias Brugger
2022-11-21 12:35 ` Krzysztof Kozlowski
1 sibling, 0 replies; 26+ messages in thread
From: Matthias Brugger @ 2022-11-21 12:34 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Remove the check for the unnecessary pins-are-numbered
> DeviceTree property
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/pinctrl/stm32/pinctrl-stm32.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
> index cc9472b284047..1cddca506ad7e 100644
> --- a/drivers/pinctrl/stm32/pinctrl-stm32.c
> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
> @@ -1499,11 +1499,6 @@ int stm32_pctl_probe(struct platform_device *pdev)
> if (!match_data)
> return -EINVAL;
>
> - if (!device_property_present(dev, "pins-are-numbered")) {
> - dev_err(dev, "only support pins-are-numbered format\n");
> - return -EINVAL;
> - }
> -
> pctl = devm_kzalloc(dev, sizeof(*pctl), GFP_KERNEL);
> if (!pctl)
> return -ENOMEM;
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH 2/9] pinctrl: stm32: Remove check for pins-are-numbered
2022-11-21 1:54 ` [PATCH 2/9] pinctrl: stm32: " Bernhard Rosenkränzer
2022-11-21 12:34 ` Matthias Brugger
@ 2022-11-21 12:35 ` Krzysztof Kozlowski
1 sibling, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-21 12:35 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel, khilman,
mcoquelin.stm32, alexandre.torgue, matthias.bgg
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Remove the check for the unnecessary pins-are-numbered
> DeviceTree property
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
> ---
FWIW:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 3/9] dt-bindings: pinctrl: mediatek,mt65xx: Make pins-are-numbered optional
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
2022-11-21 1:54 ` [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered Bernhard Rosenkränzer
2022-11-21 1:54 ` [PATCH 2/9] pinctrl: stm32: " Bernhard Rosenkränzer
@ 2022-11-21 1:54 ` Bernhard Rosenkränzer
2022-11-21 8:00 ` Krzysztof Kozlowski
2022-11-21 1:54 ` [PATCH 4/9] dt-bindings: pinctrl: st,stm32: Don't list pins-are-numbered as required Bernhard Rosenkränzer
` (6 subsequent siblings)
9 siblings, 1 reply; 26+ messages in thread
From: Bernhard Rosenkränzer @ 2022-11-21 1:54 UTC (permalink / raw)
To: devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Don't list the pins-are-numbered property as required
Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
.../devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
index 33b5f79e741ab..cca9cc58a6934 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
@@ -62,7 +62,6 @@ properties:
required:
- compatible
- - pins-are-numbered
- gpio-controller
- "#gpio-cells"
--
2.38.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 3/9] dt-bindings: pinctrl: mediatek,mt65xx: Make pins-are-numbered optional
2022-11-21 1:54 ` [PATCH 3/9] dt-bindings: pinctrl: mediatek,mt65xx: Make pins-are-numbered optional Bernhard Rosenkränzer
@ 2022-11-21 8:00 ` Krzysztof Kozlowski
2022-11-21 12:32 ` Matthias Brugger
0 siblings, 1 reply; 26+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-21 8:00 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel, khilman,
mcoquelin.stm32, alexandre.torgue, matthias.bgg
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Don't list the pins-are-numbered property as required
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
> ---
And how about making them deprecated? (deprecated: true)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 3/9] dt-bindings: pinctrl: mediatek,mt65xx: Make pins-are-numbered optional
2022-11-21 8:00 ` Krzysztof Kozlowski
@ 2022-11-21 12:32 ` Matthias Brugger
2022-11-21 12:36 ` Matthias Brugger
0 siblings, 1 reply; 26+ messages in thread
From: Matthias Brugger @ 2022-11-21 12:32 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel, khilman,
mcoquelin.stm32, alexandre.torgue
On 21/11/2022 09:00, Krzysztof Kozlowski wrote:
> On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
>> Don't list the pins-are-numbered property as required
>>
>> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
>> ---
>
> And how about making them deprecated? (deprecated: true)
>
I think that's we want to do.
Regards,
Matthias
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 3/9] dt-bindings: pinctrl: mediatek,mt65xx: Make pins-are-numbered optional
2022-11-21 12:32 ` Matthias Brugger
@ 2022-11-21 12:36 ` Matthias Brugger
0 siblings, 0 replies; 26+ messages in thread
From: Matthias Brugger @ 2022-11-21 12:36 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel, khilman,
mcoquelin.stm32, alexandre.torgue
On 21/11/2022 13:32, Matthias Brugger wrote:
>
>
> On 21/11/2022 09:00, Krzysztof Kozlowski wrote:
>> On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
>>> Don't list the pins-are-numbered property as required
>>>
>>> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
>>> ---
>>
>> And how about making them deprecated? (deprecated: true)
>>
>
> I think that's we want to do.
>
Also squash 8/9 into this patch.
Same comments holds for 4/9.
Regards,
Matthias
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 4/9] dt-bindings: pinctrl: st,stm32: Don't list pins-are-numbered as required
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
` (2 preceding siblings ...)
2022-11-21 1:54 ` [PATCH 3/9] dt-bindings: pinctrl: mediatek,mt65xx: Make pins-are-numbered optional Bernhard Rosenkränzer
@ 2022-11-21 1:54 ` Bernhard Rosenkränzer
2022-11-21 1:54 ` [PATCH 5/9] arm64: dts: mediatek: Remove pins-are-numbered property Bernhard Rosenkränzer
` (5 subsequent siblings)
9 siblings, 0 replies; 26+ messages in thread
From: Bernhard Rosenkränzer @ 2022-11-21 1:54 UTC (permalink / raw)
To: devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Don't list the pins-are-numbered property as required
Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
index 9d59208d83c18..7c08d362132a4 100644
--- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
@@ -206,7 +206,6 @@ required:
- '#address-cells'
- '#size-cells'
- ranges
- - pins-are-numbered
additionalProperties: false
--
2.38.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 5/9] arm64: dts: mediatek: Remove pins-are-numbered property
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
` (3 preceding siblings ...)
2022-11-21 1:54 ` [PATCH 4/9] dt-bindings: pinctrl: st,stm32: Don't list pins-are-numbered as required Bernhard Rosenkränzer
@ 2022-11-21 1:54 ` Bernhard Rosenkränzer
2022-11-21 9:00 ` AngeloGioacchino Del Regno
2022-11-21 18:21 ` Kevin Hilman
2022-11-21 1:54 ` [PATCH 6/9] ARM: " Bernhard Rosenkränzer
` (4 subsequent siblings)
9 siblings, 2 replies; 26+ messages in thread
From: Bernhard Rosenkränzer @ 2022-11-21 1:54 UTC (permalink / raw)
To: devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Remove the unnecessary pins-are-numbered property from
arm64 Mediatek DeviceTrees
Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 1 -
arch/arm64/boot/dts/mediatek/mt8167.dtsi | 1 -
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 -
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 -
arch/arm64/boot/dts/mediatek/mt8516.dtsi | 1 -
5 files changed, 5 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
index 9dc0794fcd2e6..ace8e751c8ea4 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
@@ -270,7 +270,6 @@ pio: pinctrl@10005000 {
compatible = "mediatek,mt2712-pinctrl";
reg = <0 0x1000b000 0 0x1000>;
mediatek,pctl-regmap = <&syscfg_pctl_a>;
- pins-are-numbered;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
diff --git a/arch/arm64/boot/dts/mediatek/mt8167.dtsi b/arch/arm64/boot/dts/mediatek/mt8167.dtsi
index fbe1a1128cc6a..6a54315cf6502 100644
--- a/arch/arm64/boot/dts/mediatek/mt8167.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8167.dtsi
@@ -117,7 +117,6 @@ pio: pinctrl@1000b000 {
compatible = "mediatek,mt8167-pinctrl";
reg = <0 0x1000b000 0 0x1000>;
mediatek,pctl-regmap = <&syscfg_pctl>;
- pins-are-numbered;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index e21feb85d822b..18e214464a2d3 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -929,7 +929,6 @@ clock: mt6397clock {
pio6397: pinctrl {
compatible = "mediatek,mt6397-pinctrl";
- pins-are-numbered;
gpio-controller;
#gpio-cells = <2>;
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 7640b5158ff9d..c47d7d900f283 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -375,7 +375,6 @@ pio: pinctrl@1000b000 {
compatible = "mediatek,mt8173-pinctrl";
reg = <0 0x1000b000 0 0x1000>;
mediatek,pctl-regmap = <&syscfg_pctl_a>;
- pins-are-numbered;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
index d1b67c82d7617..118025263a29b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
@@ -229,7 +229,6 @@ pio: pinctrl@1000b000 {
compatible = "mediatek,mt8516-pinctrl";
reg = <0 0x1000b000 0 0x1000>;
mediatek,pctl-regmap = <&syscfg_pctl>;
- pins-are-numbered;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
--
2.38.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 5/9] arm64: dts: mediatek: Remove pins-are-numbered property
2022-11-21 1:54 ` [PATCH 5/9] arm64: dts: mediatek: Remove pins-are-numbered property Bernhard Rosenkränzer
@ 2022-11-21 9:00 ` AngeloGioacchino Del Regno
2022-11-21 18:21 ` Kevin Hilman
1 sibling, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-11-21 9:00 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Il 21/11/22 02:54, Bernhard Rosenkränzer ha scritto:
> Remove the unnecessary pins-are-numbered property from
> arm64 Mediatek DeviceTrees
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 5/9] arm64: dts: mediatek: Remove pins-are-numbered property
2022-11-21 1:54 ` [PATCH 5/9] arm64: dts: mediatek: Remove pins-are-numbered property Bernhard Rosenkränzer
2022-11-21 9:00 ` AngeloGioacchino Del Regno
@ 2022-11-21 18:21 ` Kevin Hilman
1 sibling, 0 replies; 26+ messages in thread
From: Kevin Hilman @ 2022-11-21 18:21 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Bernhard Rosenkränzer <bero@baylibre.com> writes:
> Remove the unnecessary pins-are-numbered property from
> arm64 Mediatek DeviceTrees
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 6/9] ARM: dts: mediatek: Remove pins-are-numbered property
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
` (4 preceding siblings ...)
2022-11-21 1:54 ` [PATCH 5/9] arm64: dts: mediatek: Remove pins-are-numbered property Bernhard Rosenkränzer
@ 2022-11-21 1:54 ` Bernhard Rosenkränzer
2022-11-21 9:00 ` AngeloGioacchino Del Regno
2022-11-21 18:21 ` Kevin Hilman
2022-11-21 1:54 ` [PATCH 7/9] ARM: dts: stm32: Remove the " Bernhard Rosenkränzer
` (3 subsequent siblings)
9 siblings, 2 replies; 26+ messages in thread
From: Bernhard Rosenkränzer @ 2022-11-21 1:54 UTC (permalink / raw)
To: devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Remove the unnecessary pins-are-numbered property from
Mediatek ARM DeviceTrees
Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
arch/arm/boot/dts/mt2701.dtsi | 1 -
arch/arm/boot/dts/mt7623.dtsi | 1 -
arch/arm/boot/dts/mt8135.dtsi | 1 -
3 files changed, 3 deletions(-)
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index b8eba3ba153c2..0a0fe8c5a4059 100644
--- a/arch/arm/boot/dts/mt2701.dtsi
+++ b/arch/arm/boot/dts/mt2701.dtsi
@@ -178,7 +178,6 @@ pio: pinctrl@1000b000 {
compatible = "mediatek,mt2701-pinctrl";
reg = <0 0x1000b000 0 0x1000>;
mediatek,pctl-regmap = <&syscfg_pctl_a>;
- pins-are-numbered;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index 25d31e40a5535..11379c3e6b4ca 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -253,7 +253,6 @@ pio: pinctrl@10005000 {
compatible = "mediatek,mt7623-pinctrl";
reg = <0 0x1000b000 0 0x1000>;
mediatek,pctl-regmap = <&syscfg_pctl_a>;
- pins-are-numbered;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi
index a031b36363187..0f291ad22d3af 100644
--- a/arch/arm/boot/dts/mt8135.dtsi
+++ b/arch/arm/boot/dts/mt8135.dtsi
@@ -152,7 +152,6 @@ pio: pinctrl@10005000 {
compatible = "mediatek,mt8135-pinctrl";
reg = <0 0x1000b000 0 0x1000>;
mediatek,pctl-regmap = <&syscfg_pctl_a &syscfg_pctl_b>;
- pins-are-numbered;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
--
2.38.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 6/9] ARM: dts: mediatek: Remove pins-are-numbered property
2022-11-21 1:54 ` [PATCH 6/9] ARM: " Bernhard Rosenkränzer
@ 2022-11-21 9:00 ` AngeloGioacchino Del Regno
2022-11-21 18:21 ` Kevin Hilman
1 sibling, 0 replies; 26+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-11-21 9:00 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Il 21/11/22 02:54, Bernhard Rosenkränzer ha scritto:
> Remove the unnecessary pins-are-numbered property from
> Mediatek ARM DeviceTrees
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 6/9] ARM: dts: mediatek: Remove pins-are-numbered property
2022-11-21 1:54 ` [PATCH 6/9] ARM: " Bernhard Rosenkränzer
2022-11-21 9:00 ` AngeloGioacchino Del Regno
@ 2022-11-21 18:21 ` Kevin Hilman
1 sibling, 0 replies; 26+ messages in thread
From: Kevin Hilman @ 2022-11-21 18:21 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Bernhard Rosenkränzer <bero@baylibre.com> writes:
> Remove the unnecessary pins-are-numbered property from
> Mediatek ARM DeviceTrees
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 7/9] ARM: dts: stm32: Remove the pins-are-numbered property
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
` (5 preceding siblings ...)
2022-11-21 1:54 ` [PATCH 6/9] ARM: " Bernhard Rosenkränzer
@ 2022-11-21 1:54 ` Bernhard Rosenkränzer
2022-11-21 1:54 ` [PATCH 8/9] dt-bindings: pinctrl: mediatek,mt65xx: Drop " Bernhard Rosenkränzer
` (2 subsequent siblings)
9 siblings, 0 replies; 26+ messages in thread
From: Bernhard Rosenkränzer @ 2022-11-21 1:54 UTC (permalink / raw)
To: devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Remove the pins-are-numbered property from STM32 DeviceTrees
Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 1 -
arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 1 -
arch/arm/boot/dts/stm32h743.dtsi | 1 -
arch/arm/boot/dts/stm32mp131.dtsi | 1 -
arch/arm/boot/dts/stm32mp151.dtsi | 2 --
5 files changed, 6 deletions(-)
diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 500bcc302d422..4523c63475e4c 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -51,7 +51,6 @@ pinctrl: pinctrl@40020000 {
ranges = <0 0x40020000 0x3000>;
interrupt-parent = <&exti>;
st,syscfg = <&syscfg 0x8>;
- pins-are-numbered;
gpioa: gpio@40020000 {
gpio-controller;
diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
index 8f37aefa73150..c8e6c52fb248e 100644
--- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
@@ -15,7 +15,6 @@ pinctrl: pinctrl@40020000 {
ranges = <0 0x40020000 0x3000>;
interrupt-parent = <&exti>;
st,syscfg = <&syscfg 0x8>;
- pins-are-numbered;
gpioa: gpio@40020000 {
gpio-controller;
diff --git a/arch/arm/boot/dts/stm32h743.dtsi b/arch/arm/boot/dts/stm32h743.dtsi
index 28e3deb20e1e1..f30796f7adf36 100644
--- a/arch/arm/boot/dts/stm32h743.dtsi
+++ b/arch/arm/boot/dts/stm32h743.dtsi
@@ -588,7 +588,6 @@ pinctrl: pinctrl@58020000 {
ranges = <0 0x58020000 0x3000>;
interrupt-parent = <&exti>;
st,syscfg = <&syscfg 0x8>;
- pins-are-numbered;
gpioa: gpio@58020000 {
gpio-controller;
diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi
index 2a9b3a5bba830..adaee0f9e1263 100644
--- a/arch/arm/boot/dts/stm32mp131.dtsi
+++ b/arch/arm/boot/dts/stm32mp131.dtsi
@@ -549,7 +549,6 @@ pinctrl: pinctrl@50002000 {
ranges = <0 0x50002000 0x8400>;
interrupt-parent = <&exti>;
st,syscfg = <&exti 0x60 0xff>;
- pins-are-numbered;
gpioa: gpio@50002000 {
gpio-controller;
diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index 5491b6c4dec20..4e437d3f2ed66 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -1660,7 +1660,6 @@ pinctrl: pinctrl@50002000 {
ranges = <0 0x50002000 0xa400>;
interrupt-parent = <&exti>;
st,syscfg = <&exti 0x60 0xff>;
- pins-are-numbered;
gpioa: gpio@50002000 {
gpio-controller;
@@ -1789,7 +1788,6 @@ pinctrl_z: pinctrl@54004000 {
#size-cells = <1>;
compatible = "st,stm32mp157-z-pinctrl";
ranges = <0 0x54004000 0x400>;
- pins-are-numbered;
interrupt-parent = <&exti>;
st,syscfg = <&exti 0x60 0xff>;
--
2.38.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 8/9] dt-bindings: pinctrl: mediatek,mt65xx: Drop the pins-are-numbered property
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
` (6 preceding siblings ...)
2022-11-21 1:54 ` [PATCH 7/9] ARM: dts: stm32: Remove the " Bernhard Rosenkränzer
@ 2022-11-21 1:54 ` Bernhard Rosenkränzer
2022-11-21 12:36 ` Krzysztof Kozlowski
2022-11-21 1:54 ` [PATCH 9/9] dt-bindings: pinctrl: st,stm32: Remove " Bernhard Rosenkränzer
2022-11-21 12:31 ` [PATCH 0/9] Remove the pins-are-numbered DT property Matthias Brugger
9 siblings, 1 reply; 26+ messages in thread
From: Bernhard Rosenkränzer @ 2022-11-21 1:54 UTC (permalink / raw)
To: devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Drop the pins-are-numbered property from the Mediatek MT65xx DeviceTree
schema
Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
.../bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 6 ------
1 file changed, 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
index cca9cc58a6934..cb450da49e6e9 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
@@ -28,11 +28,6 @@ properties:
reg:
maxItems: 1
- pins-are-numbered:
- $ref: /schemas/types.yaml#/definitions/flag
- description: |
- Specify the subnodes are using numbered pinmux to specify pins.
-
gpio-controller: true
"#gpio-cells":
@@ -149,7 +144,6 @@ examples:
compatible = "mediatek,mt8135-pinctrl";
reg = <0 0x1000B000 0 0x1000>;
mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>;
- pins-are-numbered;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
--
2.38.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 8/9] dt-bindings: pinctrl: mediatek,mt65xx: Drop the pins-are-numbered property
2022-11-21 1:54 ` [PATCH 8/9] dt-bindings: pinctrl: mediatek,mt65xx: Drop " Bernhard Rosenkränzer
@ 2022-11-21 12:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-21 12:36 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel, khilman,
mcoquelin.stm32, alexandre.torgue, matthias.bgg
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Drop the pins-are-numbered property from the Mediatek MT65xx DeviceTree
> schema
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
> ---
> .../bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
> index cca9cc58a6934..cb450da49e6e9 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
> @@ -28,11 +28,6 @@ properties:
> reg:
> maxItems: 1
>
> - pins-are-numbered:
> - $ref: /schemas/types.yaml#/definitions/flag
> - description: |
> - Specify the subnodes are using numbered pinmux to specify pins.
Oh, I missed that patch. There is no need to split it. Squash it with
your first and rather mark it as "deprecated: true"
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 9/9] dt-bindings: pinctrl: st,stm32: Remove the pins-are-numbered property
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
` (7 preceding siblings ...)
2022-11-21 1:54 ` [PATCH 8/9] dt-bindings: pinctrl: mediatek,mt65xx: Drop " Bernhard Rosenkränzer
@ 2022-11-21 1:54 ` Bernhard Rosenkränzer
2022-11-21 12:31 ` [PATCH 0/9] Remove the pins-are-numbered DT property Matthias Brugger
9 siblings, 0 replies; 26+ messages in thread
From: Bernhard Rosenkränzer @ 2022-11-21 1:54 UTC (permalink / raw)
To: devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue,
matthias.bgg
Remove the pins-are-numbered property from the STM32 DeviceTree schema
Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
.../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
index 7c08d362132a4..dc111122ff5d2 100644
--- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
@@ -34,7 +34,6 @@ properties:
const: 1
ranges: true
- pins-are-numbered: true
hwlocks: true
interrupts:
@@ -219,7 +218,6 @@ examples:
#size-cells = <1>;
compatible = "st,stm32f429-pinctrl";
ranges = <0 0x40020000 0x3000>;
- pins-are-numbered;
gpioa: gpio@0 {
gpio-controller;
@@ -237,7 +235,6 @@ examples:
#size-cells = <1>;
compatible = "st,stm32f429-pinctrl";
ranges = <0 0x50020000 0x3000>;
- pins-are-numbered;
gpiob: gpio@1000 {
gpio-controller;
--
2.38.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 0/9] Remove the pins-are-numbered DT property
2022-11-21 1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
` (8 preceding siblings ...)
2022-11-21 1:54 ` [PATCH 9/9] dt-bindings: pinctrl: st,stm32: Remove " Bernhard Rosenkränzer
@ 2022-11-21 12:31 ` Matthias Brugger
2022-11-21 12:37 ` Krzysztof Kozlowski
9 siblings, 1 reply; 26+ messages in thread
From: Matthias Brugger @ 2022-11-21 12:31 UTC (permalink / raw)
To: Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel,
krzysztof.kozlowski, khilman, mcoquelin.stm32, alexandre.torgue
Hi Bernhard,
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> During the review of my MT8365 support patchset
> (https://lore.kernel.org/linux-mediatek/20221117210356.3178578-1-bero@baylibre.com/),
> the issue of the "pins-are-numbered" DeviceTree property has come up.
>
> This property is unique to Mediatek MT65xx and STM32 pinctrls, and
> doesn't seem to serve any purpose (both the Mediatek and STM32 drivers
> simply refuse to deal with a device unless pins-are-numbered is set to
> true).
>
> There is no other use of this property in the kernel or in other projects
> using DeviceTrees (checked u-boot and FreeBSD -- in both of those, the
> flag is present in Mediatek and STM devicetrees, but not used anywhere).
>
> There is also no known use in userspace (in fact, a userland application
> relying on the property would be broken because it would get true on
> any Mediatek or STM chipset and false on all others, even though other
> chipsets use numbered pins).
>
> This patchset removes all uses of pins-are-numbered.
>
>
My personal preference is to add a summary of the files touched by the series in
the cover letter (the tools will do that for you). This allows maintainers to
easier understand if they have to look deeper into the series or can ignore it.
No need to send again, just saying for the future.
Regards,
Matthias
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH 0/9] Remove the pins-are-numbered DT property
2022-11-21 12:31 ` [PATCH 0/9] Remove the pins-are-numbered DT property Matthias Brugger
@ 2022-11-21 12:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-21 12:37 UTC (permalink / raw)
To: Matthias Brugger, Bernhard Rosenkränzer, devicetree
Cc: linux-mediatek, linux-stm32, linux-arm-kernel, khilman,
mcoquelin.stm32, alexandre.torgue
On 21/11/2022 13:31, Matthias Brugger wrote:
> Hi Bernhard,
>
> On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
>> During the review of my MT8365 support patchset
>> (https://lore.kernel.org/linux-mediatek/20221117210356.3178578-1-bero@baylibre.com/),
>> the issue of the "pins-are-numbered" DeviceTree property has come up.
>>
>> This property is unique to Mediatek MT65xx and STM32 pinctrls, and
>> doesn't seem to serve any purpose (both the Mediatek and STM32 drivers
>> simply refuse to deal with a device unless pins-are-numbered is set to
>> true).
>>
>> There is no other use of this property in the kernel or in other projects
>> using DeviceTrees (checked u-boot and FreeBSD -- in both of those, the
>> flag is present in Mediatek and STM devicetrees, but not used anywhere).
>>
>> There is also no known use in userspace (in fact, a userland application
>> relying on the property would be broken because it would get true on
>> any Mediatek or STM chipset and false on all others, even though other
>> chipsets use numbered pins).
>>
>> This patchset removes all uses of pins-are-numbered.
>>
>>
>
> My personal preference is to add a summary of the files touched by the series in
> the cover letter (the tools will do that for you). This allows maintainers to
> easier understand if they have to look deeper into the series or can ignore it.
>
> No need to send again, just saying for the future.
Yep. And git format-patch does it automatically in both common cases -
writing cover letter manually or taking it from branch description
(which is absolutely cool, IMHO).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread