From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB53A3C4165; Thu, 14 May 2026 14:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778767582; cv=none; b=W4cMpwuslyC7UODve8tfRy+50gvqoGDHpOEo+NwO5Sc1p/Wm7WJ1wr8cffKL5mP6pUJkxZpQW1fJRkZ5R663wzOi55VMskF90HHY5vFpSm1tK3mA09SP8Ma3p+IDcpoLdb16jb0N9ZJrfeAG3knbjlB1if4Xxf3YoRKdvvbvDUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778767582; c=relaxed/simple; bh=bF/5iB/aRUkfr7re3u8A4MHw2NVqXyyKjzOAvG6y4No=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a7meKDYFYvffP6vVGcQpTpcTH9pRsicMpio3EUafIl0/yMMZ5ZV3oHsPtdLp4nUaMKF4YlI+QOmXVXFKoBPlxvi1I5xnaxnt/zpkYvvDfOPMcOmt0cYjoG6HpN2OCP9qFTv4zMZuvq4271pCQAxM4rm7MUVqlZQHayNjud9375s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X3e4UgSK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X3e4UgSK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93236C2BCB3; Thu, 14 May 2026 14:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778767582; bh=bF/5iB/aRUkfr7re3u8A4MHw2NVqXyyKjzOAvG6y4No=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=X3e4UgSKVXjRZTzOl7KkoiIti855Z00n+ywh/4/7sBG29YSTFrUMepB4ZcmtG/UR8 z3uehQZcH2AYFWmIMRD4iXqkdxgKIi7yG5Fes9cfdJEDIEQkLcmQS93eZCGOythcMJ kgSp8YvppUo7Aju3bCfbOY4r/OoO+kapKyQxnx5CfhsqsXO7o6xex4eZYzAREmf8DG V2g9IN4ljkFP3mJY6tR27cxb0XSGJ6V5WG8Ev5Jb9FPMn4AiSHQtRpUeiYTJ41bjZF LIrK1v3oWu21o/qircuU65sE+e+8Ns3Adr/y6BAbNvowOApfUzNpBein/5vPfCrhJ0 7V9u/Y24PPxEQ== Message-ID: Date: Thu, 14 May 2026 16:06:17 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] soc: qcom: ice: Enable PM runtime for ICE driver To: Linlin Zhang , Rob Herring , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: Herbert Xu , "David S . Miller" , devicetree@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Neeraj Soni , Deepti Jaggi References: <20260512033750.3393050-1-linlin.zhang@oss.qualcomm.com> <20260512033750.3393050-3-linlin.zhang@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260512033750.3393050-3-linlin.zhang@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/05/2026 05:37, Linlin Zhang wrote: > The QCOM ICE driver manages the ICE core clock through direct calls to > clk_prepare_enable() and clk_disable_unprepare(), which limits integration No, it does not limit any integration. > with platforms that rely on firmware-managed resources or platform-specific > power management mechanisms. Nope. It's perfectly correct way of managing clocks. Adding runtime PM ONLY to toggle clocks is absolute killer, pointless overhead without benefits. > > Replace direct clock management with runtime PM support by moving clock > enable and disable into runtime PM callbacks. Use > pm_runtime_resume_and_get() and pm_runtime_put_sync() in qcom_ice_resume() > and qcom_ice_suspend() to drive power state transitions, and enable runtime > PM in qcom_ice_probe(). > > Reviewed-by: Neeraj Soni > Reviewed-by: Deepti Jaggi > Signed-off-by: Linlin Zhang > --- > drivers/soc/qcom/ice.c | 58 ++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 53 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > index b203bc685cad..6f9d679b530c 100644 > --- a/drivers/soc/qcom/ice.c > +++ b/drivers/soc/qcom/ice.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #include > > @@ -310,8 +311,8 @@ int qcom_ice_resume(struct qcom_ice *ice) > struct device *dev = ice->dev; > int err; > > - err = clk_prepare_enable(ice->core_clk); > - if (err) { > + err = pm_runtime_resume_and_get(dev); > + if (err < 0) { > dev_err(dev, "failed to enable core clock (%d)\n", > err); > return err; > @@ -323,7 +324,7 @@ EXPORT_SYMBOL_GPL(qcom_ice_resume); > > int qcom_ice_suspend(struct qcom_ice *ice) > { > - clk_disable_unprepare(ice->core_clk); > + pm_runtime_put_sync(ice->dev); > ice->hwkm_init_complete = false; > > return 0; This is pretty pointless change. At least by quick glance. You changed nothing here for PM, except adding indirection layer and more locks. Clocks will be gated the same way, no energy savings. But on the other hand introducing runtime PM subsystem is huge bunch of code with its own locks, completely unnecessary here. This itself is poor choice and has NEGATIVE impact on all existing platforms without any benefit. I am surprised you went through SIX internal reviews, collected two internal review tags and no one suggested that using runtime PM ONLY to toggle clocks is pretty pointless and undesired. Best regards, Krzysztof