From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4654E21B9F5 for ; Thu, 12 Jun 2025 10:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749725961; cv=none; b=Q8tWUl6Iz8eDSnueQAkyL0Z4Mp370HDk+yYJI4xc4sqIo3vA3KOYOlieU5XgrEW6tzFt7ALF38ab6U/TSMJQXIT7dL6KA8sFLtK0n9Je81BnRHwNFYVbkRlpW/C+PX+nBeG8Z0NJUQCYr+y3gJwtSHKWlJlPEXihf8sH3JJKwYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749725961; c=relaxed/simple; bh=WWPYYggyKVUIqcpZRwtY3ch16mcUxM6fvmZKKpyOsWg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qNDXYPWOiVWoBXHmIPMOX2N/JtyajbZrfvZlkLmgcCSFtHXW1RvzjRzr1ktBCQVlwe6wzd97xr6sSiT2gf7M7WsD1NQawXJk8siZrxsXlMklhqvpDgPf7r1eBPpFtQnsCki+258HjEOWe7ObBqO01MjElgM29kW7moow/P2wj+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=r6nN+AaH; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r6nN+AaH" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3a54700a46eso691464f8f.1 for ; Thu, 12 Jun 2025 03:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749725957; x=1750330757; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=OxVFpXC9gE/NnptI7yasZSeAwdsDwjZxI1xtlSOfvvA=; b=r6nN+AaH1FFt9eiD/oBB6xuxgOlHpttnmzJhBx3WCbi/KaDm+x7tLBZyac03mSdqFT n75/2p6JKdJjfULVxmhhVzlSK1CoWfbvx5ZN94xlE/oCvExe7Mpg/3DrCfHFBg38SpHw AZbxEyi81sDmbs6yXTlIWc7Hcf82sdtAv/myAQnpqMUwIZOHCL9FCLTX/CZYOXeeTojw ckQjb0s/Su47ljH+lKQ7oMYRtYI17ATM1q1zIqJjW2rNLvK6w0QCOxZ6WTYaUmTyURZo 6P96e6qJ076z6uZXdapfKqBNGdoQxxjyN9Uwfwu3kSwDbprln1I3fE14n8rVDFcPp6iL 4A6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749725957; x=1750330757; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OxVFpXC9gE/NnptI7yasZSeAwdsDwjZxI1xtlSOfvvA=; b=IT431G5oGPD7ZGiDZydXAyNn++raszZWlBOl0cJKd6rK93JEZi/seJrUKS7+jhzsDZ gdujnvZOptObwj0q1vuDw9dDZeJ3rkh7m1HgP75gX1GQr8heSsR7bkP7EsiKdu1VacYA titWxxZGNfiCxBBKiwbAbwybrLjGnC0/KFEGxssCP4RjjWWs6bb+meVXlhfRoy61a3YW uUMO/lfxxOsPleNhWzVWOQPhplVh9cJ5hz1R5DQt8VmFAXcnfZjWIXzG9pbL8IhwVwyS HmubmKkVKpKZrIcsw4NIDdPLPk8LQ9e/hNAyd9EzFQ7jPoqeMa/ECXJ1gXzHrVG52sCG ASWA== X-Forwarded-Encrypted: i=1; AJvYcCUzZRG+bY9epd2nDe8ptaWJADeZl+SslGcf7QegivWCgL6Aju9ND0JGZ9jRPU+bYKl1axUP+ZeEIiaT@vger.kernel.org X-Gm-Message-State: AOJu0YzvvYE4ILjwCdXJMAucrH+dufKlXTv6ycFSEfrC6nGJN4BtYU6h VDhVibidpcbdA5sTUbzSWbnoC5dNfLbyXKmZ2z71c9qEIH7iwTLX+e3B9fCCqwPoWy4= X-Gm-Gg: ASbGnctsYef4Xsipc/zqrAILwNCXeavR6lWlVGm1JC3K4UCJqXBgujncC8L2DJBPrTi sUBzNJZHFzd4qG8Bsz/UC0hj4lRwer+TbXoxJpFtxdHgdonHkv1pTlzMVI9Ft+8zlAl1WrbKB8i XgTpalTR9/BOJVbsiJMOTHfFmln+eHN/FBanxcz5BD1eT1HJ7+dL5Wjjz9YGB6/UMD+zRfSvzij uFrqB2l4xpt9vXWfco43HOygk8N1+HU1F4y1fr6c45hyy8vl3NexmbLpRQhlanVY0u8oZoTbJYs qLpmzEpiI3KO8HVz0V5z3OQQ9UeW3o+yZ2Tn3JmegQalWSufj8EBImqXjJi2ZshxxA== X-Google-Smtp-Source: AGHT+IHqd8/I6PcH/SsGO4ZHasePxLhvFKcF2xtJG5ImKC1vi9knPoEYRyrNOkQXYTNCKl3KYXGlKw== X-Received: by 2002:a05:6000:4028:b0:3a5:1f2:68f3 with SMTP id ffacd0b85a97d-3a5586e9764mr5499812f8f.46.1749725956635; Thu, 12 Jun 2025 03:59:16 -0700 (PDT) Received: from draszik.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a561976a20sm1681124f8f.19.2025.06.12.03.59.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 03:59:16 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 02/17] regulator: dt-bindings: add s2mpg10-pmic regulators From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Mark Brown , Krzysztof Kozlowski Cc: Tudor Ambarus , Rob Herring , Conor Dooley , Liam Girdwood , Lee Jones , Linus Walleij , Bartosz Golaszewski , Peter Griffin , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Date: Thu, 12 Jun 2025 11:59:14 +0100 In-Reply-To: References: <20250606-s2mpg1x-regulators-v2-0-b03feffd2621@linaro.org> <20250606-s2mpg1x-regulators-v2-2-b03feffd2621@linaro.org> <20250611-statuesque-dolphin-of-felicity-6fbf54@kuoka> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Mark, On Wed, 2025-06-11 at 14:53 +0100, Mark Brown wrote: > On Wed, Jun 11, 2025 at 10:55:44AM +0200, Krzysztof Kozlowski wrote: > > On Fri, Jun 06, 2025 at 04:02:58PM GMT, Andr=C3=A9 Draszik wrote: >=20 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 For S2MPG10 l= do20m, the following values are valid > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -= 0 # S2MPG10_PCTRLSEL_LDO20M_ON - always on >=20 > > No, use standard regulator properties - regulator-always-on >=20 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -= 1 # S2MPG10_PCTRLSEL_LDO20M_EN_SFR - VLDO20M_EN & LDO20M_SFR > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -= 2 # S2MPG10_PCTRLSEL_LDO20M_EN - VLDO20M_EN pin > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -= 3 # S2MPG10_PCTRLSEL_LDO20M_SFR - LDO20M_SFR in LDO_CTRL1 register > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -= 4 # S2MPG10_PCTRLSEL_LDO20M_OFF - disable >=20 > > I don't think we allowed such property in the past. I don't get what is > > here the actual signal - you described registers in multiple places, no= t > > signals. Few of these duplicate standard properties, so this looks like > > exact copy of downstream which was doing exactly that way and that was > > exactly never upstreamed. >=20 > It looks like we can infer the configuration needed here from the > existing properties, For this ldo20, yes, and I'll update binding+driver to do so. > if a GPIO is provided then use value 2 otherwise > use value 3. Close :-) There is another register to say if this pctrlsel should be respected in the first place. Therefore if a GPIO is provided, then use value 2 for pctrlsel, otherwise the value doesn't matter, as pctrlsel will be ignored anyway. But doesn't really matter in the context of this discussion here, just for future reference :-) Thanks for your review! Thanks! Andre'