From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1794C28B2B for ; Wed, 10 Aug 2022 07:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231410AbiHJHsE (ORCPT ); Wed, 10 Aug 2022 03:48:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231453AbiHJHr4 (ORCPT ); Wed, 10 Aug 2022 03:47:56 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72DE96E8A2 for ; Wed, 10 Aug 2022 00:47:55 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id x25so15252054ljm.5 for ; Wed, 10 Aug 2022 00:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=ws3xDmWAM6yboeXN1KDvG4lH4Cj9ukWxfaS0mjDB9TI=; b=DInQ/feLe7M5SaGVz//m1f7wJx8FFBjFujTtxG6gQNok0dAnXF+QgSnbgfRwOVpfIk B/i6MmVeIWkRHByz0kwb7Xj7b+tnxluDhjzQbhAoDP5D445Zp9cOX42+4a7TGx8fFvXG SbTW9CcXA0j4AwInxrywN40hRQnMHsO/inB5aJM0VNrpzshXhdbqa/b4ApqOajOn9BYp nTLJkp2IqqZ+y65dlrANSyZsrF4XPuWDXqbaqn49KdRxN6hNNghFO4oZsI+VOlS4ewTk rF/n9hlp86GYoY+dEkY6iwG0jb64mxu8drCe3jCq1y+YJZ4J4rC/xYXokdSVkfAPOHrB eg6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=ws3xDmWAM6yboeXN1KDvG4lH4Cj9ukWxfaS0mjDB9TI=; b=xDGIAawOVwEG5unfc9g4O4whvKTSF9hReU/SzduZU5KBOLAN/Vbnuexbx39QZczRJB 85fbEF3rEzI5AoJO4g/FVIyF+791kkDbF4JyBMu3fcUL9415tyiwmXB6nIvRiwx+iGfz ymRf8N2HWNJm8yIlRe7pQ7Jp5Wwjj8AkEmyBfs1k7mKpf+vKWKryKhuYRsOaIWP4hbP7 molhwsXEP5Wj1bKk6yoVAZwhSzXAmWwFO6rKizw/V6zbH4QMVnnjNzmy7Q+KuYGPhu4K 5V1rHi2d7lRnOVDbeINtJWtOWqEcaM4ZpYpMSqEKmrdSxyQwqS11Lko2NaXdJtZvRfEx rwTA== X-Gm-Message-State: ACgBeo0/XYqA8+AhA/QQcygZzesfIyANieXGqgejp3AJN9e8QFrDuFW2 xyIRWuGK7AOsGEfv5h5flOAipg== X-Google-Smtp-Source: AA6agR7qeW+xM7yDL4T6bfOZz3EvFkzr5m3lpWkyVtIYGJrOIdftBw2e8h3zgyiOQ8uI8cpU2lr0JA== X-Received: by 2002:a05:651c:1990:b0:25f:ad63:490c with SMTP id bx16-20020a05651c199000b0025fad63490cmr4479688ljb.63.1660117673812; Wed, 10 Aug 2022 00:47:53 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id l21-20020a19c215000000b0047f7722b73csm243780lfc.142.2022.08.10.00.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 00:47:53 -0700 (PDT) Message-ID: Date: Wed, 10 Aug 2022 10:47:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 2/2] ARM: msm8960: Add Samsung Galaxy Express support Content-Language: en-US To: Rudraksha Gupta Cc: agross@kernel.org, bjorn.andersson@linaro.org, david@ixit.cz, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org References: <20220808234723.5184-2-guptarud@gmail.com> <20220809000300.6384-1-guptarud@gmail.com> <20220809000300.6384-2-guptarud@gmail.com> <27f83048-ac75-97eb-c9f0-0829de30e1ad@linaro.org> <479a6fa3-7214-2cca-14b0-b9b335146168@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <479a6fa3-7214-2cca-14b0-b9b335146168@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/08/2022 02:57, Rudraksha Gupta wrote: > > OK, I'll abandon the review. This file is really not matching anything > > > in the upstream. Please start your work from a proper upstreamed, recent > > > board. > > I based it off of qcom-msm8960-cdp.dts. If there is a dts that you would > like > > me to model off of, please link it to me. Otherwise, I will find another > recent > > dts and model off of that > >From arm these look good: arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts Best regards, Krzysztof