From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC74A2FD1B6 for ; Fri, 17 Apr 2026 15:20:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776439204; cv=none; b=MYGBd2LUyOCM92IkBEArTIIAIHhor/62Cu59YaYr1z/9WFEDQQHrpHh+3dD5yuKR+TDnH0BlVnqlwc6sF50u3MDmhbcEZEckhhdrzcPMWn5r+klgR+0cuOh5rn5yKc+82cpTT5UZoeV5INzzEN2xuivTdPiwnZShToPZGS82rdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776439204; c=relaxed/simple; bh=94H9O5bKpZJFIum9FyBi6L/m0YdYgTBfbD+IuzK2avE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=F1OdBGpAWdpRpE+B1YGbV35ovif+laGrki9cz3QQ7UjWW6/TX5q/mklcMDdygDaRY1FILZI7fRgHhvSP1CIhWBeiV7vR8DhA3rjRrw0gtHyWYY+JBVXrbgv/hs7++sYUJN+SCzJzYFuiMKxsT4NNPM/crG4+NmsZYtgogN53iHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MEHa0pWc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i499Izi7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MEHa0pWc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i499Izi7" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H8M1DL667843 for ; Fri, 17 Apr 2026 15:19:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3Wig1FYIP1zNSkQ75Q9iE46JSnYQwQ+jz+kMS2CZwmk=; b=MEHa0pWcmt4NO+oF XIOI8kb+L/JodJtIBeDcElJu/+MpF8jpLDR0GlNqqApUe2eJajsKAq8JeaYtNJxg H/wN4Nt7BSzlq10yeH4HIALqtTsivmqxDZUgf8/bVaap8KD+DQXenT/t32cTdh4/ s06CZFhAe+4OsroOecp6k++stVG3vDYZ2pwcGOPs7DndR7ccnKcgdYg2HNsfJ4/i vauSf8nkMEm5yS5MzHOpsHJ2uKxuXC2iOVY8XbEAHNt4A42yvyPbvtjNURUSUxaY ntoxZgsbt7aGdKmi3iMIkZaI3HSXN0pSu0Rw3DaZEdtgeVZAEQ5hsTyX05sPD94g TtjIKg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkaxctrud-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 15:19:56 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b465bf993cso8140765ad.1 for ; Fri, 17 Apr 2026 08:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776439195; x=1777043995; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=3Wig1FYIP1zNSkQ75Q9iE46JSnYQwQ+jz+kMS2CZwmk=; b=i499Izi7N7Yfi5ruR0x8skwnH6FTBmH55tL2qO44mestcvP5Mefs9TRqq3t2fHSWdw 3zu2Pxf+moHHMa3YItYLMC9JOQ3DBzRIbUrc+vr/wxVAIwKFvGBGVBDB39IKJgpyqaE8 w9+LNJCANK0J9/LaRWxlu0s9NhqHPgzjpC1Z8Xbvlwz72W+cffoJN+3xPIxqKNtE+ep8 cJK42URutRU9kevpDyml5i+UuMErbW4vixMnnBjrJ0eq1w1IaaHImyNnZteHkU+jFWYj TaFPJIq9ZtKKcHsV7btPlZjJ/RYrxv7whJS+c8qmpb6Zgtimcyah3cdVTM8lWXYDGiqU yFRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776439195; x=1777043995; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3Wig1FYIP1zNSkQ75Q9iE46JSnYQwQ+jz+kMS2CZwmk=; b=IKIHSK2PAk/2IvivPRLSnWkAk7ZpFw4g5n0E5Xozoe6xZ0c3ezNYcJD2JucDZa0QtH 9/5M9bvuPcM33qrHD4bvoDno2U2epN14k+lUnmvO2cpz4l2dsmLPGMyljTb2j1tSs25e wkEds5uXBGUKlm7a+C8pM8Z7ITg2DpQf9qPupr3tiiaoar+iTkXCJk/De03mfgr6GGwm klkr/y09PDkczi3bk0d4yIvX5swU5A1WrRsgSItHiSkiV1AOcsWU9ioduMTCSkaCLm10 xL09I6uKSW1MDXQLGWPb2dAh+7VePhBpk2BgfUvw29+HNe7JsMOyIztCf2OLk4nXEcII 1/mw== X-Forwarded-Encrypted: i=1; AFNElJ+m3lNZZ8Ro8bJM3GxZa+1tje4vh3GGi/xpRnpro9IlFFHlEtqA9eks1gpMk2FxHPbRoopMDArUbVx/@vger.kernel.org X-Gm-Message-State: AOJu0YyAN/nfT0iUNlkeThdq2z2UlurHFZClUotlBRPzFyHCA+fHn2Si D2yxMEGDix0sZPlqIR6MCsssKKiO0lOaFPVaH6qkJam6XMCV4HFBqa5uXkIRYghagTOpRws9ofl CMtqGhhs+ukQ7i71eohwFaegz/6FY91XwdyMfZIv4Dl9f7jbIE0kbxFZW3oDRsFIg X-Gm-Gg: AeBDietqRSUFxBM0CB8U5yeXDEpUr0wDU9DK1MraAGRdSUDNLsozm54nBAwUUb2zOzQ nLPubEUIHzHs/d4Wth85isxCJuOvA+99bfscqD1dhq5FauJJ5UTFHsXkgog+9V5shEH/TLpM77y O+JYDeZT6v7yr8Nk3pvyC2ffpHcCXfsNGMNbkx9urnidQxZ/tFJjJ8w1abzxE5TyPnLSt8Iw2EN uwFJuL7S60ANe+rFGXq9RPWXWAzLZTr5F/SlFs14ekpVHFI9oQiW9OWUWPo1oDNETCWJ7iSb/tF f2mTyQd9EHD3ub68W+kHcL845Pt4yJ15Z0PR9hdq8rg1gYgm4mc04nXosI7ol9Yk9AxSyOv6vlU b0KywZiFcU+hUO3ik2KoGx1kg3LAQ6JSCDPg9oUfifNePB14UoCB+d2POYN+JaLmB X-Received: by 2002:a05:6a20:4326:b0:398:b178:a53f with SMTP id adf61e73a8af0-3a08d8f5c50mr4016401637.40.1776439194895; Fri, 17 Apr 2026 08:19:54 -0700 (PDT) X-Received: by 2002:a05:6a20:4326:b0:398:b178:a53f with SMTP id adf61e73a8af0-3a08d8f5c50mr4016360637.40.1776439194246; Fri, 17 Apr 2026 08:19:54 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebcc9easm3096856b3a.39.2026.04.17.08.19.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 08:19:53 -0700 (PDT) Message-ID: Date: Fri, 17 Apr 2026 20:49:44 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Vishnu Reddy Subject: Re: [PATCH 04/11] media: iris: Add helper to create a context bank device on iris vpu bus To: Dmitry Baryshkov Cc: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joerg Roedel , Will Deacon , Robin Murphy , Bjorn Andersson , Konrad Dybcio , Stefan Schmidt , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev References: <20260414-glymur-v1-0-7d3d1cf57b16@oss.qualcomm.com> <20260414-glymur-v1-4-7d3d1cf57b16@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JcqMa0KV c=1 sm=1 tr=0 ts=69e24f9c cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=JgkdHvVJu_VE_hPiJvkA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDE1NCBTYWx0ZWRfX9zgrYv25uFCo CBM506DSxchjFpZhS9nFRsb02OGNwFg3+iAW4Hyud+QoKj5oSXLOdPFUOrrJu2JCE2ScWDlETOG ZIxGTsz+4yyIaonKYVNllNyC8Kvw7tdoER8lRYIRtkAbBdDVwr2J3pgNiLS1SWvaenw0kBUR6MW op7Z00N9G/58fXoiTPVyEfmpN0dChYsl5KjuHIm5j9xjtDaJg4uZ4OZAaYATGQRQrkBynNt5CR2 KuCPsQra3gvhu7Gxhx1JGBFF5ALF1cN1Zt5UK/qEL1zVyUzdjymQifi2GMQ5HiflpzhcwYQe1PQ gNAg0IFSK8IrVQ4JWIL7en1wjzETk7RTypAcdwMJnXVWHcZnHvb3AJEzG9Z6HW+yFQ8AP4qeWi8 f5DfefkhtBKGJ1Dua73NcHFE5/ZUXpDZba65BJYERzgam7jsf5NpwrG+JLN7DjRWfUfoHUTFSQT OAkpaMCOumRR7J9cxNw== X-Proofpoint-GUID: 8XRETACT2j3vd6DtP04GyJvvfIvma-zz X-Proofpoint-ORIG-GUID: 8XRETACT2j3vd6DtP04GyJvvfIvma-zz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-17_01,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170154 On 4/14/2026 8:48 PM, Dmitry Baryshkov wrote: > On Tue, Apr 14, 2026 at 10:30:00AM +0530, Vishnu Reddy wrote: >> From: Vikash Garodia >> >> Add a helper function to allocate and register context bank (CB) device >> on the iris vpu bus. The function ID associated with the CB is specified >> from the platform data, allowing the bus dma_configure callback to apply >> correct stream ID mapping when device is registered. >> >> Signed-off-by: Vikash Garodia >> Signed-off-by: Vishnu Reddy >> --- >> drivers/media/platform/qcom/iris/iris_resources.c | 33 +++++++++++++++++++++++ >> drivers/media/platform/qcom/iris/iris_resources.h | 1 + >> 2 files changed, 34 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c >> index 773f6548370a..a25e0f2e9d26 100644 >> --- a/drivers/media/platform/qcom/iris/iris_resources.c >> +++ b/drivers/media/platform/qcom/iris/iris_resources.c >> @@ -6,6 +6,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -141,3 +142,35 @@ int iris_disable_unprepare_clock(struct iris_core *core, enum platform_clk_type >> >> return 0; >> } >> + >> +static void iris_release_cb_dev(struct device *dev) >> +{ >> + kfree(dev); >> +} >> + >> +struct device *iris_create_cb_dev(struct iris_core *core, const char *name, const u32 *f_id) > Please move into the bus code and make it generic enough. Do you suggest to add a wrapper to pass the varying inputs to the generic bus, something like this struct device* create_and_register_device(dma_mask, parent_dev, *release, dev_name,...) >> +{ >> + struct device *dev; >> + int ret; >> + >> + dev = kzalloc_obj(*dev); >> + if (!dev) >> + return ERR_PTR(-ENOMEM); >> + >> + dev->release = iris_release_cb_dev; >> + dev->bus = &iris_vpu_bus_type; >> + dev->parent = core->dev; >> + dev->coherent_dma_mask = core->iris_platform_data->dma_mask; >> + dev->dma_mask = &dev->coherent_dma_mask; > Would you also need to set the of_node? See > device_set_of_node_from_dev() It might be needed for FastRPC as they are following sub node approach, Iris does not need. >> + >> + dev_set_name(dev, "%s", name); >> + dev_set_drvdata(dev, (void *)f_id); >> + >> + ret = device_register(dev); >> + if (ret) { >> + put_device(dev); >> + return ERR_PTR(ret); >> + } >> + >> + return dev; >> +} >> diff --git a/drivers/media/platform/qcom/iris/iris_resources.h b/drivers/media/platform/qcom/iris/iris_resources.h >> index 6bfbd2dc6db0..4a494627ff23 100644 >> --- a/drivers/media/platform/qcom/iris/iris_resources.h >> +++ b/drivers/media/platform/qcom/iris/iris_resources.h >> @@ -15,5 +15,6 @@ int iris_unset_icc_bw(struct iris_core *core); >> int iris_set_icc_bw(struct iris_core *core, unsigned long icc_bw); >> int iris_disable_unprepare_clock(struct iris_core *core, enum platform_clk_type clk_type); >> int iris_prepare_enable_clock(struct iris_core *core, enum platform_clk_type clk_type); >> +struct device *iris_create_cb_dev(struct iris_core *core, const char *name, const u32 *f_id); >> >> #endif >> >> -- >> 2.34.1 >>