From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D510A330B2D for ; Tue, 16 Jun 2026 13:43:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617432; cv=none; b=lHq1GG6FnAj6XwQVoKjcwYwaGWoL+X0p43NbReKl201rmgOPXYYn+a2yX70lKnBPUJ/uxYa3RD3iM5Qa9IAJcZGYVRu8NUU7Vb6jlYsAFO8NGmPs0pc8TiORX5qWQoKTlQ0gOcXK7Bsvn6wqryhuJCVto0aKvxwi3llIevdqreI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617432; c=relaxed/simple; bh=bKV17d9tguID0LIesu8rxYoO2nZDE0Plv0lBRFnUe+k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ECjTFMPV5Gb+AN7aklIXav3B8z7EcsbiYk8AqFU/kyc2BIJ/rhFg5uMyirAlB9juj7xJzlGbJXOo5W489E50DauIb6tl8nSnAnmfW0ONAXXwTsST4EM2RK8vDNHiDFYkuShhVURCe5aawwUPjjgENXdmcT8MmCBs5QfzV47/CLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bbZztLce; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S4iR8TOz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bbZztLce"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S4iR8TOz" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GA9MnT2914579 for ; Tue, 16 Jun 2026 13:43:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lx2pLtb1L3rBMwiQWuihEDC+CgioMsnRDiqje1tzDBk=; b=bbZztLce5htqB+3O +w1Fo/2iUHCgOt/hWdZlXc5G4Qkhq8hGeyB4Yyu6TtF3S7Egt+gVq7wBbpT2nkGW Ec15ZJeh/EIj9vqjcF7udRq10ujntgMSuiv8UPGdXmTW5N2Fo2urgiU37quZnGNu z+SQSfXo7mByZkiJj6RKN4hk9uimRTrOfNWhVB7v/+UkBDtaeD+q9S4n31Crivo/ ts9YRcjEbNeH9eQVAnGf1baKzyr9zkNUv0R9lZrYP/umcsoUyvkS4PbHJPHVxhhM rQ0AhQq4PD92Rz0qQhRbkzLA0g2sywlndUs7TmLKm3718/0hGf3nVZJLruVVPL2s fzMkRw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu1761u3k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 13:43:50 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5177b12d7bbso10566761cf.1 for ; Tue, 16 Jun 2026 06:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781617429; x=1782222229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lx2pLtb1L3rBMwiQWuihEDC+CgioMsnRDiqje1tzDBk=; b=S4iR8TOzNkYPiPcwtuxxrpxzB9Jet88oDuKFRMlACWu+hwCMjes7whw3Z8ljAhE+zu 2UoXT6wDoQbrd/qQ7s+5fOj43fv/KFd1lAGnzLLnGifI7XASFAu7gXDfY5q5xIRs6/TH lfdDBBYMo1N5fiucCKWx+sM8i/5ydE3wpn19jg4OH3PrNTv20YCer4++TDt2on3dVrVw 7V4ZbMa6Va+2Xib0thpz2MnJeGtPf7d9LgpL/+5MdA9kDVYMOI0C1R1L7PLmM9i4R6nh WgKrFyYYSASYI2tLOA5PYAvuXUC3NIbrXnfuIpWNfK1rUxeDC4DWRWZtcYGbYR9PinMV 0i3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781617429; x=1782222229; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lx2pLtb1L3rBMwiQWuihEDC+CgioMsnRDiqje1tzDBk=; b=aau+1Li65/Aw7s142s88EXEKbIiAgYPu7ZAczrg+p6rv/T6zDX0i9KdqFfZG/VMYj6 g10gJW2prOWDI/aFurdVB6Xi91viWBFyzgGfIVYDhsWSpsnftUGw16iHK+TADlY5GqKH /iU5MFOSXU0DlDXWIczaJB34MuTLO2nSegBO36CtVvLmkg4vAA220TcIeA4BrJ0qpAdV +jWCA35XHdPQ0wgLwzLCzXlWmqMLhESMMmli32nKduEAMBM9FVIq0a1TGJbmW7D2hTRQ aFqt+fowrktx49C3zy4jALOsOVM4uW54uCezY1fqixeBZoqMF3mDIKCUnQynB1ccSmdL mHcw== X-Forwarded-Encrypted: i=1; AFNElJ+ojEVir2HzopbQLgcCMH6oqQ4v2UbwokadEBZ0rkfIa5/XIwLZqTBxJlgZ/rwD87J0ZFPUUc3Kzxf4@vger.kernel.org X-Gm-Message-State: AOJu0YxpjG8VgVLHowsS2f+/6kh9NNGz4drM30/MJMdOiRdJZ2GOGIW7 GDT/ZmWJQ6Dmk/ebMUxv9b8lMFPDifTFcjUm5zIaoSmAguAhk1Mj7TkKaRLUmr1rkBEyw52P6Kb eblBINAi3cz0UJiSxPiZDNp3AKThSEBykGKRp1Sxxev/FPEVK0L3Js0gq5C+LG98X X-Gm-Gg: Acq92OH+6GSuj6jC58NMLphnVXOHG4q+1BWOR8TMo4HlX8jE4lPus4hzk/dac8isCya vI631FYvuyZtFFDb8kzP7PwYl+003wHmsnYpMMXyK7vhPjFq2GlA92Jp5258RhEkiQwCtk77Cqh 39+nCH7MpPxa9G2naJbxzrKBKeuLBSTdmjaMlsPmwzmyPClMoqwGuQxTUnSzkdZKHLwNOqhyKZ+ anfPaYLxVB9fCBqL67fF5Bit9O5s3XB7mEqCP8z3htisx8GhG4SpiFiQ131PpQV4CGkI58wdCf5 mLaWTAKpeiHq48BkDfRVYzV9cpPJTCAYN2PvZjM0mdY3cs5PkPjomk7UPuh1Pf6Z/ieRGpNjAAZ e9Siu1yEBcsKfGJ09uBA7sbhY9rSc4LmkV4C8cIbDAHzS2w== X-Received: by 2002:a05:622a:1a98:b0:50f:a53b:9d5 with SMTP id d75a77b69052e-517fdea8e41mr196169051cf.2.1781617429133; Tue, 16 Jun 2026 06:43:49 -0700 (PDT) X-Received: by 2002:a05:622a:1a98:b0:50f:a53b:9d5 with SMTP id d75a77b69052e-517fdea8e41mr196168641cf.2.1781617428618; Tue, 16 Jun 2026 06:43:48 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-693c6d7cf3csm4133056a12.14.2026.06.16.06.43.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 06:43:47 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 15:43:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/10] ARM: dts: qcom: msm8960: add RPM clock controller and fix USB clocks To: Antony Kurniawan Soemardi , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta References: <20260601-msm8960-wifi-v3-0-fec6ac8dba02@smankusors.com> <20260601-msm8960-wifi-v3-5-fec6ac8dba02@smankusors.com> <1d15a420-7360-429e-a451-ec1f012a0346@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: utaxz015E_85E4cc30BT3kKQYJlAbpAT X-Proofpoint-ORIG-GUID: utaxz015E_85E4cc30BT3kKQYJlAbpAT X-Authority-Analysis: v=2.4 cv=I4RVgtgg c=1 sm=1 tr=0 ts=6a315316 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=wxLWbCv9AAAA:8 a=kVRP5i783O7quJDYENkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=QJY96suAAestDpCc5Gi9:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDE0MCBTYWx0ZWRfX0GcJz+IAGFOb Jw52C9Oz9n8WDcwgNpce/H1W3Fo7XRhXnTnoCDUucsRbiIrk/TD1QnJ6Z/ilN5xnXO4PzU6Z5ly SavdFtnZ1YMvYcKbSUolOt97F3rthWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDE0MCBTYWx0ZWRfX0WFQE3EczqUT s4CO1fbCO6ttz17vRO5MTjQI4O+OgiocZB5bjozcNBZXn6z1+3c5/aqOQIO22CmUiAr9QsbB70O L6TuevpOZ5GUurcxdxt9qUMCJv5LO67xBpqSJ9wxvNdXA+sseNmCOcZ4929XDRGHZ9rsckBQMst iatGYkL7ka7z00LkO+MNJ2OSeFmd57JBGuf0UmJJU6q4CiuDCKnBbA96YkHCNJedEkIAj6CuJCE Eofj3WDcIqcZ0aA6qFJl/90NUrDZ1g6AfE2v3+o585urWbVAvc4wKz/Wfr0RPGV2Inkd2fa6xI5 uJ8HijjDFewJdsQXwJHXV/ootPpMluFHERVnOfJ75x5rb5zVYRIX6dK8bkb8MwgyUH5TcYIZtub zl6kNltl/qKXUfp8yDDW2aFPfEcbtG9dvvB8QLAqaCb2loOmo2WWKb9lnJElrlVUJBem6ecojdQ 0/gljKn+GrtqU8O3aKw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_03,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160140 On 6/16/26 3:04 PM, Antony Kurniawan Soemardi wrote: > On 6/9/2026 7:21 PM, Konrad Dybcio wrote: >> On 6/1/26 10:51 AM, Antony Kurniawan Soemardi via B4 Relay wrote: >>> From: Antony Kurniawan Soemardi >>> @@ -507,8 +519,12 @@ usb1: usb@12500000 { >>>               reg = <0x12500000 0x200>, >>>                     <0x12500200 0x200>; >>>               interrupts = ; >>> -            clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>; >>> -            clock-names = "core", "iface"; >>> +            clocks = <&gcc USB_HS1_H_CLK>, >>> +                 <&rpmcc RPM_DAYTONA_FABRIC_CLK>, >>> +                 <&gcc USB_HS1_XCVR_CLK>; >>> +            clock-names = "iface", >>> +                      "core", >>> +                      "fs"; >> >> The bindings change you sent changes the expectations - "core" used >> to be the first clock. And I would guesstimate that the >> DAYTONA_FABRIC clock is not really "core" - does downstream do any >> ratesetting on the other two? > > Looking at the downstream, I can only find HS1_XCVR being set to 60MHz, DAYTONA_FABRIC being set to the max rate (just for voting purposes?). I don't see any clk_set_rate for HS1_P though. > > Would you rather the other way around? Like "core", "iface", and "fs"? My concern is that such a change would result in a large number of warnings for newer SoC device trees. I didn't notice you're actually aligning the order with bindings. I was under the impression this was a random change. For the clock assignments themselves, I think the schema reflects a full-speed (i.e. usb 1.x) core.. I dug out some ancient doc that says that we should have: - ahb (bus clock - perhaps daytona in this case?) - system (core clock for the thing, >55 Mhz for compliant HS operation or at least 35 MHz for any sort of operation) - ulpi_clk (60 MHz, coming from the USB PHY) (we can probably ignore this in our description) - inactivity_timer since there's a BAM instance attached to this host (possibly handled implicitly) for the record, there's 4 hosts: USB1_HS @ 0x12500000 (this one) USB2_HSIC @ 0x12520000 USB1_FS @ 0x18000000 USB2_FS @ 0x18100000 I don't know if they are all exposed and functional though Konrad