From: Heiner Kallweit <hkallweit1@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH v3] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding
Date: Wed, 1 Feb 2023 23:13:31 +0100 [thread overview]
Message-ID: <b0e502fa-ef11-df82-ad45-9367ff7c75b3@gmail.com> (raw)
In-Reply-To: <20230201020647.GA2318275-robh@kernel.org>
On 01.02.2023 03:06, Rob Herring wrote:
> On Mon, Jan 30, 2023 at 10:00:24PM +0100, Heiner Kallweit wrote:
>> Convert Amlogic Meson pinctrl binding to yaml.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> v2:
>> - consider that more than one compatible can be set
>> - remove bus part from example
>> v3:
>> - remove minItem/maxItem properties for compatible
>> ---
>> .../pinctrl/amlogic,meson-pinctrl.yaml | 122 ++++++++++++++++++
>> .../bindings/pinctrl/meson,pinctrl.txt | 94 --------------
>> 2 files changed, 122 insertions(+), 94 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl.yaml
>> delete mode 100644 Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl.yaml
>> new file mode 100644
>> index 000000000..7aaae606b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl.yaml
>> @@ -0,0 +1,122 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pinctrl/amlogic,meson-pinctrl.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic Meson pinmux controller
>> +
>> +maintainers:
>> + - Neil Armstrong <neil.armstrong@linaro.org>
>> +
>> +allOf:
>> + - $ref: pinctrl.yaml#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - items:
>> + - enum:
>> + - amlogic,meson8-cbus-pinctrl
>> + - amlogic,meson8b-cbus-pinctrl
>> + - amlogic,meson8m2-cbus-pinctrl
>> + - amlogic,meson8-aobus-pinctrl
>> + - amlogic,meson8b-aobus-pinctrl
>> + - amlogic,meson8m2-aobus-pinctrl
>> + - amlogic,meson-gxbb-periphs-pinctrl
>> + - amlogic,meson-gxbb-aobus-pinctrl
>> + - amlogic,meson-gxl-periphs-pinctrl
>> + - amlogic,meson-gxl-aobus-pinctrl
>> + - amlogic,meson-axg-periphs-pinctrl
>> + - amlogic,meson-axg-aobus-pinctrl
>> + - amlogic,meson-g12a-periphs-pinctrl
>> + - amlogic,meson-g12a-aobus-pinctrl
>> + - amlogic,meson-a1-periphs-pinctrl
>> + - amlogic,meson-s4-periphs-pinctrl
>> + - items:
>> + - const: amlogic,meson8m2-aobus-pinctrl
>> + - const: amlogic,meson8-aobus-pinctrl
>> + - items:
>> + - const: amlogic,meson8m2-cbus-pinctrl
>> + - const: amlogic,meson8-cbus-pinctrl
>
> Again, can't have both with and without the fallback allowed.
>
Hi Martin,
meson8m2 is the only chip version having a fallback for the
pinctrl compatible. Is this fallback really needed?
Looking at the driver it seems that both compatibles
are handled identically.
next prev parent reply other threads:[~2023-02-01 22:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 21:22 [PATCH 0/8] soc: amlogic: switch bindings to yaml and adjust some dtbs's Heiner Kallweit
2023-01-23 21:23 ` [PATCH 1/8] arm64: dts: meson-gx: Remove invalid pwm compatible Heiner Kallweit
2023-01-23 21:24 ` [PATCH 2/8] arm64: dts: amlogic: Fix non-compliant SD/SDIO node names Heiner Kallweit
2023-01-24 7:17 ` Neil Armstrong
2023-01-23 21:25 ` [PATCH 3/8] arm64: dts: meson-gx: Set only one compatible string for mmc Heiner Kallweit
2023-01-23 21:27 ` [PATCH 4/8] arm64: dts: amlogic: Remove invalid compatible string amlogic,meson-gpio-intc Heiner Kallweit
2023-01-23 21:28 ` [PATCH 5/8] dt-bindings: rtc: Add Amlogic Meson vrtc controller binding Heiner Kallweit
2023-01-25 19:19 ` Rob Herring
2023-01-23 21:29 ` [PATCH 6/8] dt-bindings: pwm: Add Amlogic Meson PWM binding Heiner Kallweit
2023-01-24 1:22 ` Rob Herring
2023-01-25 19:22 ` Rob Herring
2023-01-23 21:30 ` [PATCH 7/8] dt-bindings: interrupt-controller: Add Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
2023-01-24 1:22 ` Rob Herring
2023-01-24 7:03 ` Heiner Kallweit
2023-01-25 16:46 ` Rob Herring
2023-01-23 21:30 ` [PATCH 8/8] dt-bindings: pinctrl: Add Amlogic Meson pinctrl binding Heiner Kallweit
2023-01-24 1:22 ` Rob Herring
2023-01-24 7:14 ` Heiner Kallweit
2023-01-24 7:16 ` [PATCH 0/8] soc: amlogic: switch bindings to yaml and adjust some dtbs's Neil Armstrong
2023-01-24 9:20 ` Heiner Kallweit
2023-01-26 7:40 ` Uwe Kleine-König
2023-01-24 8:22 ` (subset) " Neil Armstrong
2023-01-25 22:24 ` [PATCH v2] dt-bindings: rtc: Convert Amlogic Meson vrtc controller binding Heiner Kallweit
2023-01-30 17:09 ` Rob Herring
2023-02-09 22:16 ` (subset) " Alexandre Belloni
2023-01-25 22:28 ` [PATCH v2] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
2023-01-30 17:16 ` Rob Herring
2023-01-27 21:14 ` [PATCH v2] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
2023-01-27 21:16 ` [PATCH v2] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding Heiner Kallweit
2023-01-30 20:34 ` [PATCH v3] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
2023-01-30 21:21 ` Rob Herring
2023-02-01 7:35 ` Krzysztof Kozlowski
2023-01-30 20:53 ` [PATCH v3] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
2023-02-01 2:03 ` Rob Herring
2023-02-01 6:47 ` Heiner Kallweit
2023-02-01 10:21 ` Neil Armstrong
2023-01-30 21:00 ` [PATCH v3] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding Heiner Kallweit
2023-02-01 2:06 ` Rob Herring
2023-02-01 22:13 ` Heiner Kallweit [this message]
2023-02-04 22:56 ` Martin Blumenstingl
2023-02-05 0:05 ` Heiner Kallweit
2023-02-05 7:57 ` Neil Armstrong
2023-02-05 16:54 ` Heiner Kallweit
2023-02-06 9:30 ` Neil Armstrong
2023-02-01 10:56 ` Neil Armstrong
2023-06-22 7:57 ` [PATCH 0/8] soc: amlogic: switch bindings to yaml and adjust some dtbs's Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0e502fa-ef11-df82-ad45-9367ff7c75b3@gmail.com \
--to=hkallweit1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).