From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF6DC433EF for ; Thu, 21 Jul 2022 13:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230480AbiGUNtn (ORCPT ); Thu, 21 Jul 2022 09:49:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbiGUNtk (ORCPT ); Thu, 21 Jul 2022 09:49:40 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2E346342 for ; Thu, 21 Jul 2022 06:49:38 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id m9so1880447ljp.9 for ; Thu, 21 Jul 2022 06:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Df5PaXBQvWi3ElHoTsEdWiLtMQ6HsSl/JnMKyaUxUZw=; b=u/jvunMnyd49xDidrkd2IjPWAeumQ8e8y/ZLGpFdZyEHxSJEMo2CR8SUicSbdC74NE JMb7LSsarT5VL72kvSyrJo9Nv5G9/KfHABcXTLUO7U6qIMBfWsJa4I91DCLXglTvcafB fNp40vmMAN5kmvqf1PzUVuQHws+ep/jtnM/oswkgfBbOXM8pihXM81a9zOatRFYovNkp nxkqdts7DyqcEMvNwIk6EtaHnV40krQtd8xHHxqt+HKytqXQsTa1soVCwJXesGyXdmKW /p/4P4PvZ/Qc4YH2R0uSC6ECgSR1yStB8saq+ayFfYAKxkBsFySs77mV6/ouRJjO/aSs NCyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Df5PaXBQvWi3ElHoTsEdWiLtMQ6HsSl/JnMKyaUxUZw=; b=Uxrs0lnR3IEASgfwwtrYuIsrOhpGh/fGAqOXBa4OMiCP6iLzvjTLQ60U7NgiOqYjaS ilquvt1vfvhuio5ItOeR81d/gUwNZpjofDvC1PgYdoDhbug8kO9xL72MsVaA55GMzBJ5 QRxVTe9QK1yk7zo91zKpgKdorV68vQo/GpqP8ZyvJUAqRqV9r/GWbaEOjsG7cAHunF12 +3ALK/XVEqKKV4EekJLKRhtqxluEQnRxJUZCeILTisTR/1TJvup6uOlUPRvbf6MuCqvw Glr1gL9MWt+qlTapCpNRL5nMJUlCXuv4KoUxWG1UI4nS8MjDSElQsyT7XEDe9CB0OLP0 VQnA== X-Gm-Message-State: AJIora+t4ATHkAtyp5rw8zTN6I+N+k0YR3sPOZ7rWEI2GDjmZUYeY2Og JJQ9OJuiDftY+5atdL/RvOcqDw== X-Google-Smtp-Source: AGRyM1thiRH/aj+PE2hEZO3seebses8tiG7Wdmeu6aB+i44xAKChmd5OawfeBgmZpsvVxmmTUcXReg== X-Received: by 2002:a2e:a591:0:b0:25d:7366:3344 with SMTP id m17-20020a2ea591000000b0025d73663344mr19932544ljp.242.1658411376877; Thu, 21 Jul 2022 06:49:36 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id a8-20020a2eb548000000b0025a6e47056csm518302ljn.124.2022.07.21.06.49.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 06:49:36 -0700 (PDT) Message-ID: Date: Thu, 21 Jul 2022 15:49:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "l.stach@pengutronix.de" Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "laurent.pinchart@ideasonboard.com" , "marex@denx.de" , "paul.elder@ideasonboard.com" , "aford173@gmail.com" , "Markus.Niebel@ew.tq-group.com" , "alexander.stein@ew.tq-group.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Aisheng Dong References: <20220719055054.3855979-1-peng.fan@oss.nxp.com> <20220719055054.3855979-4-peng.fan@oss.nxp.com> <27ab24ec-61c7-cafb-6665-a16c58808649@linaro.org> <9c1735bf-3f29-4bf1-f7cf-f9e211c505ac@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/07/2022 12:38, Peng Fan wrote: >> Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl >> >> On 19/07/2022 11:58, Peng Fan wrote: >>>>> + interconnects: >>>>> + items: >>>>> + - description: G1 decoder interconnect >>>>> + - description: G2 decoder interconnect >>>>> + - description: VC8000E encoder interconnect >>>>> + >>>>> + interconnect-names: >>>>> + items: >>>>> + - const: g1 >>>>> + - const: g2 >>>>> + - const: vc8000e >>>> >>>> Include interconnects+names in list of all properties and disallow >>>> them for other variants. >>> >>> I not understand well about >>> " Include interconnects+names in list of all properties ", could you >>> please explain a bit more? >>> >>> And there is already an "if" to check whether the compatible contains >>> " fsl,imx8mp-vpu-blk-ctrl" to make sure the interconnect valid for >>> i.MX8MP, so it is not valid to other variants. >> >> Defining properties in some if: clause is not really readable and >> maintainable. The properties should be defined in top-level properties:. > > Maybe I should also include i.MX8MM interconnect and make it > a separate patch, then i.MX8MP/i.MX8MM just use their own > names just like other properities. In final, as below: > > Tow patch: > 1. Add interconnect property for i.MX8MM VPU BLK CTRL > 2. Add i.MX8MP VPU BLK CTRL dt bindings > > In top-level: > + interconnects: > + maxItems: 3 > > + interconnect-names: > + maxItems: 3 > > For i.MX8MM > + interconnects: > + items: > + - description: G1 decoder interconnect > + - description: G2 decoder interconnect > + - description: H1 encoder interconnect > + > + interconnect-names: > + items: > + - const: g1 > + - const: g2 > + - const: h1 > > For i.MX8MP: > + interconnects: > + items: > + - description: G1 decoder interconnect > + - description: G2 decoder interconnect > + - description: VC8000E encoder interconnect > + > + interconnect-names: > + items: > + - const: g1 > + - const: g2 > + - const: vc8000e > > How do you think? I don't understand what is the question here to me. Shall I tell you what to do or not to do with iMX 8MM? I don't know. I am not a maintainer of that SoC. Best regards, Krzysztof