From: Philipp Zabel <p.zabel@pengutronix.de>
To: Rahul Tanwar <rahul.tanwar@linux.intel.com>,
jdelvare@suse.com, linux@roeck-us.net,
linux-hwmon@vger.kernel.org, robh+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
andriy.shevchenko@intel.com, songjun.Wu@intel.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
rtanwar@maxlinear.com
Subject: Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller
Date: Thu, 10 Sep 2020 12:35:17 +0200 [thread overview]
Message-ID: <b113e2f455f7770fc4852437b1bf3c40c8bc853e.camel@pengutronix.de> (raw)
In-Reply-To: <ecb6794a8f2ef6576421e6d5fbdf4e6a91f06b91.1599634208.git.rahul.tanwar@linux.intel.com>
On Wed, 2020-09-09 at 14:52 +0800, Rahul Tanwar wrote:
> PVT controller (MR75203) is used to configure & control
> Moortec embedded analog IP which contains temprature
> sensor(TS), voltage monitor(VM) & process detector(PD)
> modules. Add driver to support MR75203 PVT controller.
>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
> ---
[...]
> +static int mr75203_probe(struct platform_device *pdev)
> +{
> + const struct hwmon_channel_info **pvt_info;
> + u32 ts_num, vm_num, pd_num, val, index, i;
> + struct device *dev = &pdev->dev;
> + u32 *temp_config, *in_config;
> + struct device *hwmon_dev;
> + struct pvt_device *pvt;
> + int ret;
> +
> + pvt = devm_kzalloc(dev, sizeof(*pvt), GFP_KERNEL);
> + if (!pvt)
> + return -ENOMEM;
> +
> + ret = pvt_get_regmap(pdev, "common");
> + if (ret)
> + return ret;
> +
> + pvt->rst = devm_reset_control_get(dev, NULL);
Please use devm_reset_control_get_exclusive().
regards
Philipp
next prev parent reply other threads:[~2020-09-10 10:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 6:52 [PATCH 0/2] Add driver for Moortec PVT controller Rahul Tanwar
2020-09-09 6:52 ` [PATCH 1/2] Add DT bindings schema for " Rahul Tanwar
2020-09-09 20:48 ` Rob Herring
2020-09-09 6:52 ` [PATCH 2/2] Add driver for Moortec MR75203 " Rahul Tanwar
2020-09-09 10:33 ` Andy Shevchenko
2020-09-10 7:26 ` Tanwar, Rahul
2020-09-10 9:33 ` Andy Shevchenko
2020-09-09 15:05 ` Guenter Roeck
[not found] ` <c72665ba-b594-bbb0-00c5-ed763233d609@linux.intel.com>
2020-09-10 9:34 ` Guenter Roeck
2020-09-10 9:46 ` Andy Shevchenko
2020-09-10 9:53 ` Tanwar, Rahul
2020-09-10 10:35 ` Philipp Zabel [this message]
2020-09-10 10:42 ` Tanwar, Rahul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b113e2f455f7770fc4852437b1bf3c40c8bc853e.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=qi-ming.wu@intel.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=rtanwar@maxlinear.com \
--cc=songjun.Wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).