From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Ng, Adrian Ho Yin" <adrian.ho.yin.ng@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Thinh.Nguyen@synopsys.com" <Thinh.Nguyen@synopsys.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add Intel SoCFPGA USB controller bindings
Date: Mon, 24 Jul 2023 09:01:44 +0200 [thread overview]
Message-ID: <b11b4f8a-5379-9dc6-39b2-88f14cccda97@linaro.org> (raw)
In-Reply-To: <SA2PR11MB4860EE675DF40F1B6925AF0C8002A@SA2PR11MB4860.namprd11.prod.outlook.com>
On 24/07/2023 08:35, Ng, Adrian Ho Yin wrote:
>>> diff --git
>>> a/Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml
>>> b/Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml
>>> new file mode 100644
>>> index 000000000000..dedef70df887
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml
>>> @@ -0,0 +1,78 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/usb/intel,socfpga-dwc3.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Intel SoCFPGA DWC3 USB controller
>>> +
>>> +maintainers:
>>> + - Adrian Ng Ho Yin <adrian.ho.yin.ng@intel.com>
>>> +
>>> +properties:
>>> + compatible:
>>> + const: intel,agilex5-dwc3
>>
>> Why using compatible style different than other Agilex blocks? Which
>> one is recommended/official/correct?
>
> This style is used so that future SoCFPGA products can reuse the same binding.
Wait, why? How future products are relevant to style of compatible for
existing device? Again - why using different style? Which one is correct?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-24 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 4:30 [PATCH 0/2] Add support for Intel SocFPGA DWC3 USB controller adrian.ho.yin.ng
2023-07-21 4:30 ` [PATCH 1/2] dt-bindings: usb: Add Intel SoCFPGA USB controller bindings adrian.ho.yin.ng
2023-07-21 8:04 ` Krzysztof Kozlowski
2023-07-24 6:35 ` Ng, Adrian Ho Yin
2023-07-24 7:01 ` Krzysztof Kozlowski [this message]
2023-07-21 4:30 ` [PATCH 2/2] usb: dwc3: of-simple: Add compatible string for Intel Agilex5 platform adrian.ho.yin.ng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b11b4f8a-5379-9dc6-39b2-88f14cccda97@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=adrian.ho.yin.ng@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).