From: Krzysztof Kozlowski <krzk@kernel.org>
To: adrianhoyin.ng@altera.com, alexandre.belloni@bootlin.com,
Frank.Li@nxp.com, wsa+renesas@sang-engineering.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
dinguyen@kernel.org, linux-i3c@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: i3c: Add snps,dev-nack-retry-cnt property to Synopsys I3C master
Date: Tue, 4 Nov 2025 10:02:53 +0100 [thread overview]
Message-ID: <b11f90b0-cc1c-4372-b71a-30d34fe0be8c@kernel.org> (raw)
In-Reply-To: <9c16c22f67858e24fe7c3a7184537cb5c2c1a85c.1762245890.git.adrianhoyin.ng@altera.com>
On 04/11/2025 09:51, adrianhoyin.ng@altera.com wrote:
> From: Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
>
> Add a new optional property 'snps,dev-nack-retry-cnt' to the Synopsys
> DesignWare I3C master device tree binding. This property allows
> configuration of the Device NACK Retry count, which determines how many
> times the controller retries a transaction when a slave device responds
> with NACK.
>
> Valid values range from 0 to 3, with a default of 0
Don't explain us the binding. We can read the source code. You miss
rationale what hardware aspect you are solving, why we should accept this.
>
> Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
No, because:
1. Not a board property,
2. Most likely deducible from the compatible,
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-04 9:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 8:51 [PATCH 0/4] i3c: dw: Add support for Device NACK Retry count adrianhoyin.ng
2025-11-04 8:51 ` [PATCH 1/4] dt-bindings: i3c: Add snps,dev-nack-retry-cnt property to Synopsys I3C master adrianhoyin.ng
2025-11-04 9:02 ` Krzysztof Kozlowski [this message]
2025-11-04 19:25 ` Frank Li
2025-11-04 8:51 ` [PATCH 2/4] arm64: dts: intel: agilex5: Add snps,dev-nack-retry-cnt property for I3C controllers adrianhoyin.ng
2025-11-04 8:51 ` [PATCH 3/4] i3c: dw: Add support for Device NACK Retry count adrianhoyin.ng
2025-11-04 19:28 ` Frank Li
2025-11-04 8:51 ` [PATCH 4/4] i3c: dw: Preserve DAT entry bits when restoring addresses adrianhoyin.ng
2025-11-06 22:10 ` [PATCH 0/4] i3c: dw: Add support for Device NACK Retry count Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b11f90b0-cc1c-4372-b71a-30d34fe0be8c@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=adrianhoyin.ng@altera.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).