From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Samuel Holland <samuel@sholland.org>,
Chen-Yu Tsai <wens@csie.org>, Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: gpio: Add AXP221/AXP223/AXP809 compatibles
Date: Thu, 16 Jun 2022 06:57:01 -0700 [thread overview]
Message-ID: <b12be0e9-4fbe-ff92-6a75-ab65dbaf5160@linaro.org> (raw)
In-Reply-To: <20220616060915.48325-2-samuel@sholland.org>
On 15/06/2022 23:09, Samuel Holland wrote:
> These PMICs each have 2 GPIOs with the same register layout as AXP813,
> but without an ADC function.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> .../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml b/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> index 0f628b088cec..6faa3ef28960 100644
> --- a/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> @@ -19,7 +19,14 @@ properties:
> oneOf:
> - enum:
> - x-powers,axp209-gpio
> + - x-powers,axp221-gpio
> - x-powers,axp813-gpio
> + - items:
> + - const: x-powers,axp223-gpio
> + - const: x-powers,axp221-gpio
> + - items:
> + - const: x-powers,axp809-gpio
This is just an enum with 223 and 809. No need for two separate entries
here.
> + - const: x-powers,axp221-gpio
> - items:
> - const: x-powers,axp803-gpio
> - const: x-powers,axp813-gpio
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-16 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 6:09 [PATCH 0/4] AXP221/AXP223/AXP809 GPIO support Samuel Holland
2022-06-16 6:09 ` [PATCH 1/4] dt-bindings: gpio: Add AXP221/AXP223/AXP809 compatibles Samuel Holland
2022-06-16 13:57 ` Krzysztof Kozlowski [this message]
2022-06-16 6:09 ` [PATCH 2/4] mfd: axp20x: Add AXP221/AXP223/AXP809 GPIO cells Samuel Holland
2022-06-27 16:24 ` Lee Jones
2022-06-16 6:09 ` [PATCH 3/4] pinctrl: axp209: Support the AXP221/AXP223/AXP809 variant Samuel Holland
2022-06-25 23:29 ` Linus Walleij
2022-06-26 12:54 ` Chen-Yu Tsai
2022-06-16 6:09 ` [PATCH 4/4] ARM: dts: axp22x/axp809: Add GPIO controller nodes Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b12be0e9-4fbe-ff92-6a75-ab65dbaf5160@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).