Re: [net-next v2] dt-bindings: can: mpfs: document resets

[Krzysztof Kozlowski <krzk@kernel.org>]

On 26/11/2025 11:24, Marc Kleine-Budde wrote:
> Hello,
> 
> can I get a review from the DT people?

We don't always review each other patches, so you kind of have DT review
already. I can review, but I just did not plan to review this... less
work needed...

> 
> regards,
> Marc
> 
> On 21.11.2025 13:42:30, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> The CAN cores on Polarfire SoC both have a reset. The platform firmware
>> brings both cores out of reset, but the linux driver must use them
>> during normal operation. The resets should have been made required, but
>> this is one of the things that can happen when the binding is written
>> without driver support.
>>
>> Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller")
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> This is the second mistake in this binding, both spotted because of the
>> driver being written (although this one sat downstream for a while for
>> w/e reason). I wish I could say that I'd send the driver soon, but I am
>> busy upstreaming things I wrote and therefore understand at the moment,
>> so a driver that I'd have to go understand and review before sending is
>> low priority, sorry!
>>
>> v2: update the example too...
>>
>> CC: Conor Dooley <conor.dooley@microchip.com>
>> CC: Daire McNamara <daire.mcnamara@microchip.com>
>> CC: Marc Kleine-Budde <mkl@pengutronix.de>
>> CC: Vincent Mailhol <mailhol@kernel.org>
>> CC: Rob Herring <robh@kernel.org>
>> CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> CC: linux-riscv@lists.infradead.org
>> CC: linux-can@vger.kernel.org
>> CC: devicetree@vger.kernel.org
>> CC: linux-kernel@vger.kernel.org
>> ---
>>  .../devicetree/bindings/net/can/microchip,mpfs-can.yaml      | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
>> index 1219c5cb601f..519a11fbe972 100644
>> --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
>> +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
>> @@ -32,11 +32,15 @@ properties:
>>        - description: AHB peripheral clock
>>        - description: CAN bus clock
>>
>> +  resets:
>> +    maxItems: 1
>> +
>>  required:
>>    - compatible
>>    - reg
>>    - interrupts
>>    - clocks
>> +  - resets
>>
>>  additionalProperties: false
>>
>> @@ -46,6 +50,7 @@ examples:
>>          compatible = "microchip,mpfs-can";
>>          reg = <0x2010c000 0x1000>;
>>          clocks = <&clkcfg 17>, <&clkcfg 37>;
>> +        resets = <&clkcfg 17>;
>>          interrupt-parent = <&plic>;
>>          interrupts = <56>;
>>      };
>> --
>> 2.51.0
>>
>>
>>
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |


Best regards,
Krzysztof