From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2216522A7E6 for ; Fri, 14 Nov 2025 15:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763135339; cv=none; b=jheRCFCcIu7wBH8GCO2faBgjn9XFiLfFE5dAC0I+KKTijMpmdz+o3yLwWgeS60qKT5zjAbnP+1vT1/T2cNTdE6QkPNL5WxvRT6H+YNH8Z0nHvF3Z+pLrzBkJyic3Fn805vvzYf4AIPO7/F7EJUwyYvDlr4FaUknS+hB2a//I6WM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763135339; c=relaxed/simple; bh=32GJB5o//tb448T4HE2U4J6INacEhIaY5vGUG5cJs8Y=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=RqtoFAq93khiSEcLGbwzMdHPscF1wYHcrNqXR16PlIGzQ/QUO3TMUmX6sCUEgo2q8E7iEVzTmBg+nhlGocq1Jj/ZbFY+jCtetxdt1S9dCbWyfQ4rDc1F5F1Y6jwj/H4CBb5LtvhqUJthu+tUipPtAfIWDQVLyRuqaY1s5mLPQHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vJw2S-0008Ac-1g; Fri, 14 Nov 2025 16:48:40 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJw2R-000Rhr-1r; Fri, 14 Nov 2025 16:48:39 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1vJw2R-00000000AR3-24kG; Fri, 14 Nov 2025 16:48:39 +0100 Message-ID: Subject: Re: [PATCH v5 1/6] reset: imx8mp-audiomix: Drop unneeded macros From: Philipp Zabel To: Laurentiu Mihalcea , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Date: Fri, 14 Nov 2025 16:48:39 +0100 In-Reply-To: <20251114133738.1762-2-laurentiumihalcea111@gmail.com> References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> <20251114133738.1762-2-laurentiumihalcea111@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1+deb13u1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org On Fr, 2025-11-14 at 05:37 -0800, Laurentiu Mihalcea wrote: > From: Laurentiu Mihalcea >=20 > The macros defining the mask values for the EARC, EARC PHY resets, > and the DSP RUN_STALL signal can be dropped as they are not and will > not be used anywhere else except to set the value of the "mask" field > from "struct imx8mp_reset_map". In this particular case, based on the > name of the "mask" field, you can already deduce what these values are > for, which is why defining macros for them doesn't offer any new > information, nor does it help with the code readability. >=20 > Reviewed-by: Daniel Baluta > Reviewed-by: Frank Li > Signed-off-by: Laurentiu Mihalcea Reviewed-by: Philipp Zabel regards Philipp