From: Sean Nyekjaer <sean@geanix.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
andy.shevchenko@gmail.com, lars@metafoo.de, Nuno.Sa@analog.com,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers
Date: Thu, 29 Apr 2021 07:53:35 +0200 [thread overview]
Message-ID: <b1529522-6fc9-ad01-e05c-5b8d4c8364f1@geanix.com> (raw)
In-Reply-To: <20210428151925.000015e3@Huawei.com>
On 28/04/2021 16.19, Jonathan Cameron wrote:
>> +static int fxls8962af_get_temp(struct fxls8962af_data *data, int *val)
>> +{
>> + struct device *dev = regmap_get_device(data->regmap);
>> + unsigned int value;
>> + int ret;
>> +
>> + ret = fxls8962af_drdy(data);
> I'm a little confused. You check data is ready before calling power on
> which could result in you moving from standby to active state?
>
>
Reading it again, I would definitively move it around :)
When testing it looks like we currently are getting the last sample from
active state.
/Sean
prev parent reply other threads:[~2021-04-29 5:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 8:01 [PATCH v3 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers Sean Nyekjaer
2021-04-28 8:01 ` [PATCH v3 2/2] dt-bindings: iio: accel: fxls8962af: add bindings Sean Nyekjaer
2021-04-28 11:34 ` [PATCH v3 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers Sean Nyekjaer
2021-04-28 13:59 ` Jonathan Cameron
2021-04-28 14:19 ` Jonathan Cameron
2021-04-29 5:53 ` Sean Nyekjaer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1529522-6fc9-ad01-e05c-5b8d4c8364f1@geanix.com \
--to=sean@geanix.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=Nuno.Sa@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).