From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D699C47094 for ; Thu, 10 Jun 2021 14:33:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BD62613CB for ; Thu, 10 Jun 2021 14:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230348AbhFJOfm (ORCPT ); Thu, 10 Jun 2021 10:35:42 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:33293 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbhFJOfm (ORCPT ); Thu, 10 Jun 2021 10:35:42 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15AEMOAC008243; Thu, 10 Jun 2021 16:33:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=/hkRnTEMeC7+hgFh6oD0/FMI5Nxfp+iUUqwGzvsdDa4=; b=Wg299IqSLi4nruuOKVB0+Qs1wqEVojRMAnDkLkrwuqNIdss1p4GxUpvBFIJVbxrjYb5/ 67Q1+3L0zs0AhVBOzi4RTOz5kEdOqXGJ1TE+IBUxie2vlEQXwjq0lPvomgQml5ZrrD1p iSyankZjuaXyzXKhKGxTKHF85IF/fmrfwwTw68GwKsFp4jhGwFBbQyH+S5QJF92Cfnef 4sgWIiIH/9USTQwIBDzh23RDVQfNDMwHHgYchhRfvDIauTFfovMN2Xpfy66qJW/KTOZz bI8bwN2m5ncSb3Z87bhvbXttYxFAhEMEzT8uZ6hBDxc3DtMpJcRhW73IYAxVlru5WFqS lQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 393ee5jexu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jun 2021 16:33:28 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 89BD4100034; Thu, 10 Jun 2021 16:33:27 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 41D0522A6FF; Thu, 10 Jun 2021 16:33:27 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.50) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 10 Jun 2021 16:33:26 +0200 Subject: Re: [PATCH 09/13] ARM: dts: stm32: fix stpmic node for stm32mp1 boards To: , , Marek Vasut , , Manivannan Sadhasivam , Marcin Sloniewski , Ahmad Fatoum CC: , , , , Lee Jones , References: <20210415101037.1465-1-alexandre.torgue@foss.st.com> <20210415101037.1465-10-alexandre.torgue@foss.st.com> From: Alexandre TORGUE Message-ID: Date: Thu, 10 Jun 2021 16:33:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210415101037.1465-10-alexandre.torgue@foss.st.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-06-10_10:2021-06-10,2021-06-10 signatures=0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/15/21 12:10 PM, Alexandre Torgue wrote: > On some STM32 MP15 boards, stpmic node is not correct which generates > warnings running "make dtbs_check W=1" command. Issues are: > > -"regulator-active-discharge" is not a boolean but an uint32. > -"regulator-over-current-protection" is not a valid entry for vref_ddr. > -LDO4 has a fixed voltage (3v3) so min/max entries are not allowed. > > Signed-off-by: Alexandre Torgue Applied on stm32-next. Thanks. Alex > > diff --git a/arch/arm/boot/dts/stm32mp157a-stinger96.dtsi b/arch/arm/boot/dts/stm32mp157a-stinger96.dtsi > index 113c48b2ef93..a4b14ef3caee 100644 > --- a/arch/arm/boot/dts/stm32mp157a-stinger96.dtsi > +++ b/arch/arm/boot/dts/stm32mp157a-stinger96.dtsi > @@ -184,8 +184,6 @@ > > vdd_usb: ldo4 { > regulator-name = "vdd_usb"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > interrupts = ; > }; > > @@ -208,7 +206,6 @@ > vref_ddr: vref_ddr { > regulator-name = "vref_ddr"; > regulator-always-on; > - regulator-over-current-protection; > }; > > bst_out: boost { > @@ -219,13 +216,13 @@ > vbus_otg: pwr_sw1 { > regulator-name = "vbus_otg"; > interrupts = ; > - regulator-active-discharge; > + regulator-active-discharge = <1>; > }; > > vbus_sw: pwr_sw2 { > regulator-name = "vbus_sw"; > interrupts = ; > - regulator-active-discharge; > + regulator-active-discharge = <1>; > }; > }; > > diff --git a/arch/arm/boot/dts/stm32mp157c-odyssey-som.dtsi b/arch/arm/boot/dts/stm32mp157c-odyssey-som.dtsi > index 6cf49a0a9e69..0c0b66788ea1 100644 > --- a/arch/arm/boot/dts/stm32mp157c-odyssey-som.dtsi > +++ b/arch/arm/boot/dts/stm32mp157c-odyssey-som.dtsi > @@ -173,8 +173,6 @@ > > vdd_usb: ldo4 { > regulator-name = "vdd_usb"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > interrupts = ; > }; > > @@ -197,7 +195,6 @@ > vref_ddr: vref_ddr { > regulator-name = "vref_ddr"; > regulator-always-on; > - regulator-over-current-protection; > }; > > bst_out: boost { > @@ -213,7 +210,7 @@ > vbus_sw: pwr_sw2 { > regulator-name = "vbus_sw"; > interrupts = ; > - regulator-active-discharge; > + regulator-active-discharge = <1>; > }; > }; > > diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi > index 272a1a67a9ad..769fcf74685a 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi > @@ -327,8 +327,6 @@ > > vdd_usb: ldo4 { > regulator-name = "vdd_usb"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > interrupts = ; > }; > > @@ -350,7 +348,6 @@ > vref_ddr: vref_ddr { > regulator-name = "vref_ddr"; > regulator-always-on; > - regulator-over-current-protection; > }; > > bst_out: boost { > @@ -366,7 +363,7 @@ > vbus_sw: pwr_sw2 { > regulator-name = "vbus_sw"; > interrupts = ; > - regulator-active-discharge; > + regulator-active-discharge = <1>; > }; > }; > > diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi > index 713485a95795..6706d8311a66 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi > @@ -146,8 +146,6 @@ > > vdd_usb: ldo4 { > regulator-name = "vdd_usb"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > interrupts = ; > }; > > @@ -171,7 +169,6 @@ > vref_ddr: vref_ddr { > regulator-name = "vref_ddr"; > regulator-always-on; > - regulator-over-current-protection; > }; > > bst_out: boost { > @@ -182,13 +179,13 @@ > vbus_otg: pwr_sw1 { > regulator-name = "vbus_otg"; > interrupts = ; > - regulator-active-discharge; > + regulator-active-discharge = <1>; > }; > > vbus_sw: pwr_sw2 { > regulator-name = "vbus_sw"; > interrupts = ; > - regulator-active-discharge; > + regulator-active-discharge = <1>; > }; > }; > >