From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E80C433EF for ; Wed, 8 Sep 2021 09:15:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73A4A610A3 for ; Wed, 8 Sep 2021 09:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233824AbhIHJQZ (ORCPT ); Wed, 8 Sep 2021 05:16:25 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:56618 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348678AbhIHJQY (ORCPT ); Wed, 8 Sep 2021 05:16:24 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631092517; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=RDiwY+AZ3ACBodU30o7rTrzXnw0PgLmsZq3HxNZIBBE=; b=wT3+envUic3mKCNCSa3d2dXUKPQfE4xzxlf0YvysdtE1f6wzDDP5+kS9cDv7EVkJdgkVj6eb qMGCeRdNmL1NtGIyO3p1fb7l59KoGTaEpm4SZDMqFz2C5CUIa5J2Gb9V810wtRLPwKqqvFbx CJmGcKBYs/FD7/+sxG7OpF0pFAM= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 61387f11fc1f4cb6926f86b8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 08 Sep 2021 09:14:57 GMT Sender: skakit=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1DB8EC43617; Wed, 8 Sep 2021 09:14:57 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: skakit) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6E258C4338F; Wed, 8 Sep 2021 09:14:56 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 08 Sep 2021 14:44:56 +0530 From: skakit@codeaurora.org To: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , Pavel Machek , Rob Herring , mka@chromium.org, kgunda@codeaurora.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support In-Reply-To: References: <1630924867-4663-1-git-send-email-skakit@codeaurora.org> <1630924867-4663-4-git-send-email-skakit@codeaurora.org> Message-ID: X-Sender: skakit@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2021-09-08 09:04, Stephen Boyd wrote: > Quoting satya priya (2021-09-06 03:41:07) >> Add pwm support for PM8350C pmic. >> >> Signed-off-by: satya priya >> --- >> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> b/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> index e1b75ae..ecdae55 100644 >> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> @@ -29,6 +29,12 @@ >> interrupt-controller; >> #interrupt-cells = <2>; >> }; >> + >> + pm8350c_pwm4: pwm { >> + compatible = "qcom,pm8350c-pwm"; > > Shouldn't there be a reg property? > The bindings do not specify reg property. I think it is because we are adding the base address in struct "pm8350c_pwm_data". >> + #pwm-cells = <2>; >> + status = "okay"; >> + }; >> }; >> }; >> >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a >> member >> of Code Aurora Forum, hosted by The Linux Foundation >>