From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AA99C77B75 for ; Sat, 6 May 2023 12:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231675AbjEFM0X (ORCPT ); Sat, 6 May 2023 08:26:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232273AbjEFM0K (ORCPT ); Sat, 6 May 2023 08:26:10 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFE39150E8; Sat, 6 May 2023 05:26:04 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 953FA24E272; Sat, 6 May 2023 20:26:02 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sat, 6 May 2023 20:26:02 +0800 Received: from [192.168.125.107] (183.27.98.219) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sat, 6 May 2023 20:26:01 +0800 Message-ID: Date: Sat, 6 May 2023 20:26:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support Content-Language: en-US To: Conor Dooley CC: Conor Dooley , Krzysztof Kozlowski , Rob Herring , "Krzysztof Kozlowski" , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , , , References: <089e24d1-588a-4a56-f00b-0b35d1d99295@linaro.org> <1ac26c1a-1726-515d-6598-849a07ed0b86@linaro.org> <5adda0ad-965c-fbf0-878c-9d41d28b5c39@starfivetech.com> <86693969-59bf-5bcc-42a3-b6e94a0d6f3e@linaro.org> <20230504-worshiper-ongoing-5581e1f2c2c4@wendy> <2f473307-2219-61a4-fa66-5848fe566cf0@starfivetech.com> <20230505-magician-poet-724c96020c2f@wendy> <20230506-dating-twiddling-b364de21ed2b@spud> From: Changhuang Liang In-Reply-To: <20230506-dating-twiddling-b364de21ed2b@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.98.219] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX062.cuchost.com (172.16.6.62) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/5/6 18:17, Conor Dooley wrote: > On Sat, May 06, 2023 at 09:45:07AM +0800, Changhuang Liang wrote: >> >> >> On 2023/5/5 20:38, Conor Dooley wrote: >>> On Fri, May 05, 2023 at 09:29:15AM +0800, Changhuang Liang wrote: >>> >>>> But if keep this "starfive,jh7110-aon-syscon" compatible. Which .yaml match to >>>> it? Use this series dt-bindings or syscon series dt-bindings. >>> >>> There is no syscon series anymore, it's part of the PLL series now: >>> https://lore.kernel.org/linux-clk/20230414024157.53203-1-xingyu.wu@starfivetech.com/ >>> >>> I don't really care what you, Walker & Xingyu decide to do, but add the >>> binding in one series in a complete form. It's far less confusing to >>> have only have one version of the binding on the go at once. >>> >> >> Due to the current aon pmu needs to be adjusted, it affects the syscon in PLL series. >> So It's inevitable to change syscon in PLL series. >> >> My current idea is PLL series don't add the aon_syscon node. I will add it in my >> aon pmu series in next version > > That's fine. Rob was happy with the clock related parts, which was the > original source of confusion there. > >> like this: >> >> aon_syscon: syscon@17010000 { >> compatible = "starfive,jh7110-aon-pmu", "syscon"; > > The syscon does a bunch of things of which one is a pmu. I don't see a > reason to name this other than "starfive,jh100-aon-syscon". > OK, will replace "starfive,jh7110-aon-pmu" with "starfive,jh100-aon-syscon" in this series. Thanks, Changhuang