From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E2B4EB64D9 for ; Thu, 15 Jun 2023 13:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344180AbjFONkq (ORCPT ); Thu, 15 Jun 2023 09:40:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344038AbjFONka (ORCPT ); Thu, 15 Jun 2023 09:40:30 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D68F3359F; Thu, 15 Jun 2023 06:39:25 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 35FDctqp035586; Thu, 15 Jun 2023 08:38:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1686836335; bh=W03GDBtsx/euIwZmFpeRvYj1DNjPr/Db4E/jxNQJQJw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=geNB8XiLWWx0vmNoSY1KeK512Fd1z3+PRHsSRCIDMjdO0MQPREH7StixbYwKnyNk1 c1vrQHYmG4WMYC/OrC6beFkXIMVwGCNlpIYfPotPdBFFFguj8RNCkDHAFzyf0zuPgD Do3k7w9Kulux28Djd4PguNM8sMGM3frwj0P9u8yI= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 35FDctFw062056 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 15 Jun 2023 08:38:55 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 15 Jun 2023 08:38:55 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 08:38:55 -0500 Received: from [172.24.145.182] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 35FDcpZg030599; Thu, 15 Jun 2023 08:38:52 -0500 Message-ID: Date: Thu, 15 Jun 2023 19:08:51 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 6/9] arm64: dts: ti: k3-j721e-beagleboneai64: Add wakeup_uart pinmux Content-Language: en-US To: Nishanth Menon , "Kumar, Udit" CC: Conor Dooley , Krzysztof Kozlowski , Rob Herring , Tero Kristo , , , , Neha Malcom Francis References: <20230601183151.1000157-1-nm@ti.com> <20230601183151.1000157-7-nm@ti.com> <22b67e80-1f5f-d8e0-3c85-c69d97ea0d39@ti.com> <20230614120303.5ievpixlpjb3wtdz@elective> From: Vignesh Raghavendra In-Reply-To: <20230614120303.5ievpixlpjb3wtdz@elective> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/06/23 17:33, Nishanth Menon wrote: > On 19:26-20230613, Kumar, Udit wrote: >> Hi Nishanth, >> >> On 6/2/2023 12:01 AM, Nishanth Menon wrote: >>> Define the wakeup uart pin-mux for completeness. This allows the >>> device tree usage in bootloader and firmwares that can configure the >>> same appropriately. >>> >>> Signed-off-by: Nishanth Menon >>> --- >>> arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts >>> index c13246a9ed8f..bc53ca566a68 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts >>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts >>> @@ -531,6 +531,13 @@ J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */ >>> >; >>> }; >>> + wkup_uart0_pins_default: wkup-uart0-pins-default { >>> + pinctrl-single,pins = < >>> + J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */ >>> + J721E_WKUP_IOPAD(0xa4, PIN_OUTPUT, 0) /* (J28) WKUP_UART0_TXD */ >>> + >; >>> + }; >>> + >>> mcu_usbss1_pins_default: mcu-usbss1-pins-default { >>> pinctrl-single,pins = < >>> J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO0_30 */ >>> @@ -541,6 +548,8 @@ J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO >>> &wkup_uart0 { >>> /* Wakeup UART is used by TIFS firmware. */ >>> status = "reserved"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&wkup_uart0_pins_default>; >>> }; >> >> >> If you like to consider alias for wkup_uart0 for this board , >> >> Just to align with other boards for this SOC family.  I understand >> wkup_uart0 is not being used. > > Vignesh, > could you squash this locally OR if you like, I can post a v2: > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts > index 3304460f6a0b..9922d7bb061f 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts > @@ -20,6 +20,7 @@ / { > model = "BeagleBoard.org BeagleBone AI-64"; > > aliases { > + serial0 = &wkup_uart0; > serial2 = &main_uart0; > mmc0 = &main_sdhci0; > mmc1 = &main_sdhci1; > Squashed locally before queuing, no need to resend -- Regards Vignesh