From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2739A1917CD for ; Thu, 12 Sep 2024 08:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726129354; cv=none; b=tPr29c2Nt34faf9n0+AITlTcpcnb6G4ZdHHUimA0MOJPmDA7u5ieLkql8/Ah+pp2Et1tQGG6I9hY3smYQM6CZUDrjHlWIgURh3t8S4MIbcE5pc83JHjlZSNAFWveNZSn4LZJXwyjz3xO4kOivdDqB0W3/CXah1XTZ535egSoOCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726129354; c=relaxed/simple; bh=fxk0ADnO7AYMfVAA4gttR0iy6g40PU6xW5oQpU3fVoE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CHPifa22cGwMr39RSWSWc68G1NOb9F1XEJHR1qa9rJsiek9a2k8HT5NpHvs8ZEVf3cWqC83SVwOd6VtaVIQ1aNJ+nzFPgCSpq8Jn+tYFr/W2D2Rgspx1Ya5AIkRrr8zeFOq3Lf0Muk3h67dDFzKqZ/ZcJT7udgHd0M5sEPBH2h0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iQ6WmGfq; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iQ6WmGfq" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-53652c3bffdso99916e87.1 for ; Thu, 12 Sep 2024 01:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726129350; x=1726734150; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mePICWeS9/hXtfqs7iQrU4vgAXNr6sPz0xlhgJSQNUM=; b=iQ6WmGfq5NEW7YhwxSaLSel95LhMshK8mEretsWZI5MihQP0mevOlnNwMJygGr95E2 4j57pliz3OnWTZJHWA19K0Zc69QgBs1VTj0/qCKIgjUFjqX8IvZqsYMtJZQyWYJtlYUQ kLa4IMchh5XAte6GTh3822AKKBGKJPHZJdTVQDuNHP4vPOM/6fNYUlt7EmNFtkVinHZ/ 21lZgNmj/e2vld+hEpLP0OcLsyckLTZjfL2aKdAchf5ew12Eq2KU379SAMUq7kH/dCdj MkCHSQmF1RSNGK03Ni6jNFTVB9mSqYkIk1wBKpBdaOFcMyDy3mdsxZqR9+vmAE9KHlGA 2yOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726129350; x=1726734150; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mePICWeS9/hXtfqs7iQrU4vgAXNr6sPz0xlhgJSQNUM=; b=kPsDloO15mOm88ob6UZ0Eozd5/WF96mTVBiQClMDUdKlkZ9+HOoqTjcwMY/ji7OoRs TtHCM5sKfVZCHkIu4pJ4bHo2lokcmIjCvf3zp9FIhhXxNQDzdJyuOZ6t2msdjHhrJHMD tw/w5eiD3zwUqnVwkPpzgl+CHhRRxwo1scy2yr2yRhNeWtWGneiDsLtPhL93SmY/ZfYB 9wUptD8NcXfJV630rUoGd5n4C+Kj2nYkr9unhIQQv24gZMpnRq/HsBAyMBKuS4kruqPB YyP4zYzy5nHPeWAEprP5dF2NYgJWfod2sf57P1aRnI1qOAC0Nn4UrCypy13BkaEZx18Z 5M0A== X-Forwarded-Encrypted: i=1; AJvYcCVws8ULyju67CjTLL+enAjvi8he1ACgM6NlmemFMtz1sc1jnZpGUle/O3/LEaa218cB6tZ5GA6iOoEC@vger.kernel.org X-Gm-Message-State: AOJu0YxPV3J7y7h1B7NFKkF6hhwnSWWMRq0gWdiPBMHPOS+jg4SZm/6q BRh4Dd0QP03KDohzVU8g3ZjSIM2NPvSK1kIp5XGulaoqwScX88PEr0d0SJTVthE= X-Google-Smtp-Source: AGHT+IFHpYz3MtFNhhk0qE4MQvJloavhfM+9b9Iwh0c9t2QbQKCzNxYvsVOPmoH00u63FcpYNGMucA== X-Received: by 2002:a05:6512:3e08:b0:52f:c438:883c with SMTP id 2adb3069b0e04-53678fab60amr315905e87.1.1726129350250; Thu, 12 Sep 2024 01:22:30 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5365f8cb796sm1854010e87.171.2024.09.12.01.22.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 01:22:29 -0700 (PDT) Message-ID: Date: Thu, 12 Sep 2024 11:22:28 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding Content-Language: en-US To: Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20240812144131.369378-1-quic_depengs@quicinc.com> <20240812144131.369378-8-quic_depengs@quicinc.com> From: Vladimir Zapolskiy In-Reply-To: <20240812144131.369378-8-quic_depengs@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Depeng, I do have one more ask for a change. On 8/12/24 17:41, Depeng Shao wrote: > Add bindings for qcom,sm8550-camss in order to support the camera > subsystem for sm8550. > > Co-developed-by: Yongsheng Li > Signed-off-by: Yongsheng Li > Signed-off-by: Depeng Shao > + > + vdda-phy-supply: > + description: > + Phandle to a regulator supply to PHY core block. > + > + vdda-pll-supply: > + description: > + Phandle to 1.2V regulator supply to PHY refclk pll block. > + Here the supplies should be split into ones, which are specific to CSI blocks, and I believe they shall be set as optional. The proposed names are: vdda-phy-01-supply vdda-pll-01-supply vdda-phy-23-supply vdda-pll-23-supply vdda-phy-46-supply vdda-pll-46-supply vdda-phy-57-supply vdda-pll-57-supply I understand that what I ask is much more clumsy, and it could be seen even as unneeded, however it'll be the right set of properties to describe the CAMSS IP in this respect. -- Best wishes, Vladimir