From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B1B432142C for ; Thu, 14 Aug 2025 14:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755183079; cv=none; b=GeDMcvAqvkGt11EwjNl/IsMjxLU8TwgRh//2uEcda+ZQiB3vVCarrcrBWkg5thXDwkmdrTFJQsnj9aBbHCcTt3N/hvvuODJE4CBuUiLriFTY2jvWBwFVcC4F9n4HKeGmt0QP9qEvNbg0rMB5NKwYKtsWurCDBQZaog6uf3YWFZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755183079; c=relaxed/simple; bh=fyP/OLr3beYwssW4o3anr5GsJIQEhtOVd8ngVUetdSQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jYpLsTsIkuK7wVH3WvgLSz2luHdLeJZjm4grkxlkc4Qt6EwNeuVJhElflEqvmXv2y4GXjGsWc8D/hb6RFfSKm0RU/Aa0ss/6UWdGY4zKxYnia3T5XF1cFLUmsNitx21q9nbo0AwfDav0558BjON/EH5w2qosyvu5xwReC1S+7iE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=BppAGEUt; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="BppAGEUt" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-30cce52ba30so991280fac.0 for ; Thu, 14 Aug 2025 07:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1755183075; x=1755787875; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NhLbtz2pbCynkwC1z2ilVubEr1pcqPcdknoxUGu5RA0=; b=BppAGEUtHHtmsexkVgMOslgdxIUReQ8vAOm59cKPcjPnjmIxbidYBt0Q+MCtzFIw2g OPWMj1DaHSHkHPEMlALAA+QCUKxu+iroLsvOY6hiBJQl0+Oesrvspmcj7lSBRWIAwGeW J13NeImus4GIgqybGU+oVoC2AeOKP4T7W/73m8TTsN99Ug9ESQWmWHlVbyVfDQsQ9h68 pzizqRKMLmdX4SNIWW0guvzFHnsClC2irrsD9L/yDRMM8MY7p+uNj6OJtQn+IInf5h5j 7H2qw/K8S6NNhqdDXpzqN5TG9JgbyUmWoKSQ7AVBKZtr1c48QotX5nXyK9EWNv0lvHZV M+CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755183075; x=1755787875; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NhLbtz2pbCynkwC1z2ilVubEr1pcqPcdknoxUGu5RA0=; b=xDHJ17IaLS9EfvOoQ0/CfPlZoQZo+WMFzlx3GsJyJjItZK14WGoA3dbOXwPuLfWvdb JQWWwetaTcRovGJp2VZwIHARvzXXQcbUlupeqQvS8wFuUoXWG/K7kRNjNhekGeG+72Ek TNGX7wHUP37KwZyJ3w2uP6u7ti1GpC5nuBVOipE7HYd3MM/Eda0EI2+uenxmtQ4jzAsQ ZE5EIC/bnDvDzJ/6oOu+0vTy8u1xplfiv/RaEEL4bApjyseDTATJ6yeEpvYArnUrCCD3 NKPNnAyxIHZ5CAxTseLaS+xBf01RCQJQ0yxhrh0ZqbAEAbxaYhhlPTvfWbjK0jR3cMLB URhA== X-Forwarded-Encrypted: i=1; AJvYcCVRVz1zK5xFp0tWlCdd+n1MhXcCPoLvZmkEAo7gsyFASvUt7IP8hbOYKr+B5gVSdp1YLDfLBFl/DPZA@vger.kernel.org X-Gm-Message-State: AOJu0YxJY5AAdj04SKROpSxKInvTrnZmIZzS8TP3OFU36BhY+hFKDGe2 eh2HZcAe/EBbmPDviRG7Afhq7Byb5xrn8tc2g64Zz2rOSo9subWQvh9BTonxQz/3gJtF+SE9BXt RsA2q X-Gm-Gg: ASbGnctvr1Y7DWUoshUTUSvCHkCLdKZxXrg25Vlv3mR9GbxlcGRBuq/z+4lNQpUx4ab Lc3W8Q/dlODKywPkMMhB1O+ADYKzhgBmWblQsUs7Ss6+7Qwj1yWrsKYpRZJhK6gHilbV4B1XmfF nRd/R1s9aMY5rhEfy7k69uOZiuN+vsApgw3wxftjU6YMwCo4/TVZ1OymoduACsVsfpLuyYaSFYb /Ki35GWjSvrpmnLUbPxeyB0cZi8AVSh7UhR9v0kMp7lBIPTKWTvSh7jxxqqSEIYAwec9X7iTDmS MbC869/PHKicaxYnGEjOfDlP9hy7WQLv/97rFT08FlaOH/uOGe+XcgQuRxLO/cVq7P1VDc/XHVP HUN4B4cjTsq2o/dPm6UknPS17JbiCIXV2EYNxN9iNR5bp1ys0Idk16iylBm9xNTozb27ifiz5HC o= X-Google-Smtp-Source: AGHT+IGBSpWFh7v66sa0tHjx26XHgGotdF9DhOCF3YJvgTAZk5dQT2EANWxR0b3KAVLYLKWGk2J75w== X-Received: by 2002:a05:6871:6a5:b0:30b:582d:8eed with SMTP id 586e51a60fabf-30cd1399dbamr2002074fac.39.1755183075184; Thu, 14 Aug 2025 07:51:15 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:2d9b:959c:3c59:5831? ([2600:8803:e7e4:1d00:2d9b:959c:3c59:5831]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7436f879fabsm1436841a34.13.2025.08.14.07.51.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Aug 2025 07:51:14 -0700 (PDT) Message-ID: Date: Thu, 14 Aug 2025 09:51:13 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: iio: adc: Add BD7910[0,1,2,3] To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Heidelberg , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <8ef78e3cffcfdf99153a3fcf57860771890f1632.1755159847.git.mazziesaccount@gmail.com> <175ce750-7f5d-477c-8d18-dd418ba749be@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <175ce750-7f5d-477c-8d18-dd418ba749be@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/14/25 4:57 AM, Matti Vaittinen wrote: > On 14/08/2025 11:35, Matti Vaittinen wrote: >> The ROHM BD79100, BD79101, BD79102, BD79103 are very similar ADCs as the >> ROHM BD79104. The BD79100 has only 1 channel. BD79101 has 2 channels and >> the BD79102 has 4 channels. Both BD79103 and BD79104 have 4 channels, Is it just a difference in max sample rate? or pinout? >> and, based on the data sheets, they seem identical from the software >> point-of-view. >> >> Signed-off-by: Matti Vaittinen >> --- >>   .../devicetree/bindings/iio/adc/rohm,bd79104.yaml     | 11 ++++++++++- >>   1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml >> index f0a1347ba4db..6a6e6ab4aca3 100644 >> --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml >> +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml >> @@ -14,7 +14,16 @@ description: | >>     properties: >>     compatible: >> -    const: rohm,bd79104 >> +    oneOf: >> +      - items: You can drop the items: here since there is only one item. >> +          - enum: >> +              - rohm,bd79100 >> +              - rohm,bd79101 >> +              - rohm,bd79102 >> +              - rohm,bd79104 >> +      - items: >> +          - const: rohm,bd79104 >> +          - const: rohm,bd79103 > > Oops. I believe the order of the compatibles is wrong for the fallback. Indeed. > >>       reg: >>       maxItems: 1 > > Yours, >     -- Matti