public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: <Claudiu.Beznea@microchip.com>
To: <robh@kernel.org>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<codrin.ciubotariu@microchip.com>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: dt-bindings: microchip,sama7g5-pdmc: Simplify "microchip,mic-pos" constraints
Date: Thu, 22 Jun 2023 11:04:06 +0000	[thread overview]
Message-ID: <b1dbef0b-0c25-c646-58c1-f57bc4d13e62@microchip.com> (raw)
In-Reply-To: <20230621231044.3816914-1-robh@kernel.org>

On 22.06.2023 02:10, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> "enum" values should be integers or strings, not arrays (though json-schema
> does allow arrays, we do not). In this case, all possible combinations are
> allowed anyways, so there's little point in expressing as an array.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> ---
>  .../devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
> index 9b40268537cb..9aa65c975c4e 100644
> --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
> +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
> @@ -56,13 +56,9 @@ properties:
>      items:
>        items:
>          - description: value for DS line
> +          enum: [0, 1]
>          - description: value for sampling edge
> -      anyOf:
> -        - enum:
> -            - [0, 0]
> -            - [0, 1]
> -            - [1, 0]
> -            - [1, 1]
> +          enum: [0, 1]
>      minItems: 1
>      maxItems: 4
>      uniqueItems: true
> --
> 2.40.1
> 


  reply	other threads:[~2023-06-22 11:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 23:10 [PATCH] ASoC: dt-bindings: microchip,sama7g5-pdmc: Simplify "microchip,mic-pos" constraints Rob Herring
2023-06-22 11:04 ` Claudiu.Beznea [this message]
2023-06-22 19:52 ` Conor Dooley
2023-06-22 22:33 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1dbef0b-0c25-c646-58c1-f57bc4d13e62@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox