From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCDA0245014 for ; Wed, 20 Aug 2025 08:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755680270; cv=none; b=mOwAQTGYq6vBDy39mu3yNNHh9fOEsG+SD7Z3VpR8iVYkiX4tms1+sI6FW8VQnlJdg88y8kDWlNc2PQjl94CK0qLn1qXyfgYotKk5FEmyZcAfIdRkKiiijYNCF9SEaDF6Ec0fUi0wQZ9KzTGi0IF9fZbNc3evnU4XFNaFmcOZBQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755680270; c=relaxed/simple; bh=qkYO27EQCIXsaD48NEJxduCJmgc4ju2NKyZ3rsjrJ5o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qdwNQIHFP/zs0ejba4GWWGuJZGmX7H5+07rHqFERZxr3Wmr6LtrJlHzpw87KaC9U19JwaiR+oj0Ne28ewOsG7nVz24pqOQRyn6hZ2bmtBSjM3OUCRKuGM/WnMCcADS/Qg9IYCqZs1szWaOihySkGUBaRd3Kcj93W6/P14MuQ624= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=epGuVVM3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="epGuVVM3" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57K1p0sZ024931 for ; Wed, 20 Aug 2025 08:57:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LovUKZUetKjTNqClYAkifuYXcchuuq2HOA0oOrFjetc=; b=epGuVVM3UEI+lpZ/ GC3Gd49RLBjAts2KljoWNXZv1cVr+p/JIiFOTIni5sidKUiq8KP1lK9EODITlCKG do4i2ykChgNg+ODHLRPgfw/2uxIGrXvNag/dnw8nYBPZuadkJTjWfKqS2dEimX90 VRxYcJHdH05LPhJCJKGZO3UvNU1hSJuditpdj8qQ4KkvscAWFiu7us+ZcZXANkYR oz/G+N7ALaYxtAwMeJeLgaOiiCtCrS7HX5rVM8sqc0Ju79vTt55maIT7bY9nf4we UnO0zqkurPhJR05+67EV2d164UT/MeAXMSDTmXfLQXtwX6WQKJgaAL+ChW0EZFrk DMzOVA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48n5291370-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 20 Aug 2025 08:57:48 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2445820337cso68792435ad.3 for ; Wed, 20 Aug 2025 01:57:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755680267; x=1756285067; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LovUKZUetKjTNqClYAkifuYXcchuuq2HOA0oOrFjetc=; b=ExOECB8a7A55VnIXvE/cn4W5M2oX5GhkPlfEGy7VpD5uyUX6S+tvU2EOkSOXQWgHwZ H9iLbWSkbKv6npg8yoiPeshpyySCfkgBMM8omB8jPVd6qfgq9l0WFWLltk/DbZxa39sL dn8W+M3Fv2el6BlfudfyLpQC3JYGvpUpuqMrg/5O9HVjNegNzBNTv97x3LzxPHU/G/WS g19M/rNn0naicBI+tHd97g+iLoADTU+4jk/0kmFA91rwSNe5BQBjNKK4o2YvsxqYazuG JkhoWUBRZt/63KrUygSjNw2SPedkUuXVHYuxL4hqpapoEtSomoCO6XrB6fyDG74VPxgt XcYA== X-Forwarded-Encrypted: i=1; AJvYcCU3OVvyVzmyqEbBAc+ijzhWVYIdQgmxr4esXmL5a8R4vR3OWnYn+lq4FxZz4SRqCDfYqFRZ5b2WahnJ@vger.kernel.org X-Gm-Message-State: AOJu0YwS3npPt35Eq+ozybJbE2m3wOqH+LvwXc/Br+0HPXDjcZnCwYFa JyvaKLa9Pp7IJSEXppPUrTI36zeBQjQpEAP5uByKhpI4lsnKw4+DP8YYXlDXrYpABWeho0D300U y3G9qt+phJPyA6G9DeSecwZ/3qpdumJGI1uYr/Q4hBJn6WtPN732OfktEF4zBX1Nz X-Gm-Gg: ASbGnctZkGwJ11nGdqVEypteAjQ6I+UrQpApVDAUECyEsxW5zgkfIPDl7bdSTMA0VrC Pw4Ie0bk/ovnp7yYK+uaLe+TbBHAUE5XLl0tiVVMuTxxDSSzQPzhzAsyZPpn78HmugyrC7reWr0 aqTutOtRxRStlwGcCX/jeVKQFNUp5NCHQtw+caE5O+MbtcBagl5aStofpTXidgFT/je5ufBW519 2fEg3bGJTYy0UBC8EjtMvHmnEHk9OFpu4U0wKm9SH1+a/LfLjekE6iljF4Ws40skXERvHsAM8/8 L8PWNYMRVWKW79O1l/UnBKnaB/iD5O8iVw7aW99urMQu0OKcDefXpCaGc+kbj+K44PX8JZKYSB7 yApurEiiT0GXaNlNX1uSmXXqfswNIIcjH X-Received: by 2002:a17:902:e74a:b0:240:96a:b812 with SMTP id d9443c01a7336-245ef1728ddmr29790225ad.24.1755680267123; Wed, 20 Aug 2025 01:57:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG5sQXiIDgpXrdgQJsAaziiWnOkOwfxl+Waxq3t4y+pSVqgHGK5588qw9DsrKpoU1yq0lXcog== X-Received: by 2002:a17:902:e74a:b0:240:96a:b812 with SMTP id d9443c01a7336-245ef1728ddmr29789735ad.24.1755680266607; Wed, 20 Aug 2025 01:57:46 -0700 (PDT) Received: from [10.133.33.88] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed379e92sm20242905ad.65.2025.08.20.01.57.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Aug 2025 01:57:46 -0700 (PDT) Message-ID: Date: Wed, 20 Aug 2025 16:57:38 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] arm64: dts: qcom: qcs615: add ethernet node To: Krzysztof Kozlowski , Vinod Koul , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable+noautosel@kernel.org, Yijie Yang , Konrad Dybcio References: <20250819-qcs615_eth-v4-0-5050ed3402cb@oss.qualcomm.com> <20250819-qcs615_eth-v4-3-5050ed3402cb@oss.qualcomm.com> <157c048d-0efd-458c-8a3f-dfc30d07edf8@oss.qualcomm.com> <0b53dc0b-a96f-49e1-a81e-3748fa908144@kernel.org> <1394aa43-3edc-4ed5-9662-43d98bf8d85f@oss.qualcomm.com> <7c072b63-f4ff-4d7f-b71e-01f239f6b465@kernel.org> Content-Language: en-US From: Yijie Yang In-Reply-To: <7c072b63-f4ff-4d7f-b71e-01f239f6b465@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=ZJKOWX7b c=1 sm=1 tr=0 ts=68a58e0c cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=DOxB7AakEuovRElI8tQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: oUZCaxiIDMK_bivE0CHmWVWB5XoKhn_P X-Proofpoint-GUID: oUZCaxiIDMK_bivE0CHmWVWB5XoKhn_P X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIwMDAxMyBTYWx0ZWRfXypZvhMEd3tey Vv+swFSeqRFLGTfL6X/l2ytkDDJFxMdCqfmgwl0vT1NspMezDjYpiZmFI0vMbCHXkAadT2vX6OI uYAB3ASVsDKiv+EShb60U0IPecdkq00c8GwCdNLjw0CRiAYm3IH+f4EIKPGPvngxQJ2PLnABAVw E3UoGirfAVpYq+B4oOtxg/fgbekxRAotNuX2zlIAjo5ScC5qPn5QXyQwzbEfEqE0ZxeqhBrHWFG 52HMJAQwr/+u8NwQknyy71+9nOENICSwu24fJiTgKN142uSPmDGk9sXZe5+2aHm+JGXJB2PA2vB pSupFi1JVAIGEnfSijHxJzE/N1N53bB04CI0COnC8MvJ6ytl+mfIPqoE9jsVYLv2ARy6ZfScC7T tHlJvDhAwYo9ojb4zUoWkARh/p/6iQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-20_03,2025-08-20_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2508110000 definitions=main-2508200013 On 2025-08-19 17:08, Krzysztof Kozlowski wrote: > On 19/08/2025 11:04, Yijie Yang wrote: >> >> >> On 2025-08-19 15:15, Krzysztof Kozlowski wrote: >>> On 19/08/2025 08:51, Yijie Yang wrote: >>>> >>>> >>>> On 2025-08-19 14:44, Krzysztof Kozlowski wrote: >>>>> On 19/08/2025 08:35, YijieYang wrote: >>>>>> From: Yijie Yang >>>>>> >>>>>> Add an ethernet controller node for QCS615 SoC to enable ethernet >>>>>> functionality. >>>>>> >>>>>> Reviewed-by: Konrad Dybcio >>>>>> Signed-off-by: Yijie Yang >>>>>> --- >>>>> >>>>> >>>>> Why do you mix up DTS and net-next patches? This only makes difficult to >>>>> apply it, for no benefits. >>>> >>>> The DTS changes and driver code modifications work together to achieve a >>>> single purpose, so I included them in one patch series. Should I >>>> consider splitting them into two separate series? >>> Of course yes. You are just making difficult to apply this. Patches are >>> completely independent and even your internal guideline asks to NOT >>> combine independent patches. >> >> The challenge with splitting this series lies in the fact that it >> attempts to reverse the incorrect semantics of phy-mode in both the >> driver code and the device tree. Selecting only part of the series would >> break Ethernet functionality on both boards. > > And where did you explain that? Anyway, you did not achieve your goal, > because you broke the boards still. > > Your patchset is not bisectable and does not follow standard submission > guidelines. DTS is always independent, please read carefully the docs. The approach I'm taking will inevitably make the series non-bisectable, but I'll clearly note this in the cover letter in the next revision. > >> >> As you can see, I’ve CC’d noautosel to prevent this issue. Given the >> circumstances, I’m wondering if it would be acceptable to leave the >> series as-is? > > NAK. Sneaking DTS into net-next is not acceptable. Okay, I’ll split this series in the next revision. > > > Best regards, > Krzysztof -- Best Regards, Yijie