From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B077DC001B2 for ; Thu, 22 Dec 2022 12:46:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235247AbiLVMqG (ORCPT ); Thu, 22 Dec 2022 07:46:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229862AbiLVMqD (ORCPT ); Thu, 22 Dec 2022 07:46:03 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CDA222B for ; Thu, 22 Dec 2022 04:46:02 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id n3so768919wrc.5 for ; Thu, 22 Dec 2022 04:46:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6n0bW6AEyag4Yz/fTHAES88HSyxxmFvstBuhh9x5saw=; b=KOROV8lX7w89xX5ufKygg/XiKOHbwq+ahSq/EFXdClSz6A6PPIASH93vwSblhvyfvP z065xKqyID4B23C5FKRtCNBRT7EZeHKqBaXWbTm25nv5NSIM4YVpd6sapwFwIVxhDl9W vgS1DDELxOfO9UFeHBkuF3kXiBeX2Z9lJnUFB7VxxeWgDG2J9dKD9d4mhaDEElya+7OC J/Ifu+V/cIVhsVdOkWv9imdoqJp91AmZx3BU1lsgG0BAioTGznMGTy/nSQNLUBVfUTbu 59/w/iEnZzmu8sYKq1kwC+RZvZABDeTzNELZU1mol/HdAZezfgpti3m/1ZYHUj2Ma+AJ OpWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6n0bW6AEyag4Yz/fTHAES88HSyxxmFvstBuhh9x5saw=; b=BBp5antoLG8xk6Jg1ObZNy1H6xbfkgXvenzTiPm86Mp9zw3MxngWTBylA2eRjbjCYd lNES/mj0SQrJnxkb+0hXZlRyGsvr9JWY9QYtztdnCfXKyFWs0Jn/OXFH6gFng5A/BIML 9dHMj0BfNNADY5O/qZdXKvS74LQbv6+qhBQqGfOP9Y0aFLffN3zwuGW7gzznB/ADVC3e BrjJ+TUPIpMc6sJLG4fAaPHtOJAJJhtEnDqEfpIiCPA9mPh3xmfTifxO9P1fFFs30w+Q J/T2Bv1AuBKHqy+LfkK90YaYuHVIMGX2C3g1HhMNCahd/ErWZILzD9ajTfrnid+FhF3M 5pxQ== X-Gm-Message-State: AFqh2kpVKdv6ZONMgtaB+3p3oWOdIkS/q0q5unfe08nn1JjfEBXDxSOk apWzP/Fqy0ltUVSXIH3pzPT6Zg== X-Google-Smtp-Source: AMrXdXv2CMOs1kyvXBletImJqlJC+DtSfV8o0e7xTIWzSkmMqSaL7v/keKysbviY3GcBchUTo4+AIw== X-Received: by 2002:adf:fd4a:0:b0:242:593e:ee08 with SMTP id h10-20020adffd4a000000b00242593eee08mr3616514wrs.36.1671713160841; Thu, 22 Dec 2022 04:46:00 -0800 (PST) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id o2-20020a5d58c2000000b0026a4bb75477sm456705wrf.28.2022.12.22.04.45.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Dec 2022 04:46:00 -0800 (PST) Message-ID: Date: Thu, 22 Dec 2022 12:45:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v5 05/21] dt-bindings: msm: dsi-controller-main: Deprecate qcom,dsi-ctrl-6g-qcm2290 in favour of qcom,qcm2290-dsi-ctrl Content-Language: en-US To: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, dianders@chromium.org, david@ixit.cz, krzysztof.kozlowski+dt@linaro.org, swboyd@chromium.org, konrad.dybcio@somainline.org, agross@kernel.org, andersson@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221220123634.382970-1-bryan.odonoghue@linaro.org> <20221220123634.382970-6-bryan.odonoghue@linaro.org> <4115ec26-dedf-ca80-b81a-409d9db88f52@linaro.org> From: Bryan O'Donoghue In-Reply-To: <4115ec26-dedf-ca80-b81a-409d9db88f52@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/12/2022 11:50, Krzysztof Kozlowski wrote: > On 20/12/2022 13:36, Bryan O'Donoghue wrote: >> Deprecate qcom,dsi-ctrl-6g-qcm2290 in favour of the desired format >> qcom,qcm2290-dsi-ctrl. >> >> Signed-off-by: Bryan O'Donoghue >> --- >> .../display/msm/dsi-controller-main.yaml | 36 +++++++++++-------- >> 1 file changed, 21 insertions(+), 15 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> index 01afa9e9c4b3c..98d54a7ee28d4 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> @@ -14,21 +14,27 @@ allOf: >> >> properties: >> compatible: >> - items: >> - - enum: >> - - qcom,apq8064-dsi-ctrl >> - - qcom,msm8916-dsi-ctrl >> - - qcom,msm8953-dsi-ctrl >> - - qcom,msm8974-dsi-ctrl >> - - qcom,msm8996-dsi-ctrl >> - - qcom,msm8998-dsi-ctrl >> - - qcom,dsi-ctrl-6g-qcm2290 >> - - qcom,sc7180-dsi-ctrl >> - - qcom,sc7280-dsi-ctrl >> - - qcom,sdm660-dsi-ctrl >> - - qcom,sdm845-dsi-ctrl >> - - qcom,sm8250-dsi-ctrl >> - - const: qcom,mdss-dsi-ctrl >> + oneOf: >> + - items: >> + - enum: >> + - qcom,apq8064-dsi-ctrl >> + - qcom,msm8916-dsi-ctrl >> + - qcom,msm8953-dsi-ctrl >> + - qcom,msm8974-dsi-ctrl >> + - qcom,msm8996-dsi-ctrl >> + - qcom,msm8998-dsi-ctrl >> + - qcom,qcm2290-dsi-ctrl >> + - qcom,sc7180-dsi-ctrl >> + - qcom,sc7280-dsi-ctrl >> + - qcom,sdm660-dsi-ctrl >> + - qcom,sdm845-dsi-ctrl >> + - qcom,sm8250-dsi-ctrl >> + - const: qcom,mdss-dsi-ctrl >> + - items: > > I would just squash it with previous. You are adding some code and in > next patch immediately: > 1. re-indent it, > 2. remove it (qcom,dsi-ctrl-6g-qcm2290) > > > Best regards, > Krzysztof > Just to make sure. I'll squash this patch down in the previous and include your RB.