From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF0DC4321E for ; Tue, 29 Nov 2022 13:29:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230119AbiK2N3l (ORCPT ); Tue, 29 Nov 2022 08:29:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbiK2N3k (ORCPT ); Tue, 29 Nov 2022 08:29:40 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9163627CE for ; Tue, 29 Nov 2022 05:29:39 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id a7so16936997ljq.12 for ; Tue, 29 Nov 2022 05:29:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rKJhVyRGUk4beI2B134E4lnab0QniJpFD4ue42GKmoQ=; b=gX2VO5eWszA5m64OjvHkVs7GZV1B6rsOlcXF/Ig9YJW0gnLt8hrbou6SLhqH4rCyIl yZqZ5KM8+AIeNhulHYFRbN5nGcXOL5GLVql1jHTNR1iixH3Ynw/ePjOi8bQf3H/BIHts JbzvUhDRadwmhI7NUWo8vWscuD+dbCfhHC4TYDzuihz4srY3K4LmTjRu8z5W9kRo2Vmd gzYQJfFqJQAwgcYBrJ1Yj34JtyW8R/Xab+qjMiECyZaV803w7y7/mEtwj3QhgmIAT7kk ZUugGAPlxMyABqxl/ApMVkIujvKRG6QBjoVLWmr+c0iMyt4RnR3rv9iDsVAAB9FaeWRa pCvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rKJhVyRGUk4beI2B134E4lnab0QniJpFD4ue42GKmoQ=; b=PQeN2uc0m26VDz2khFRqN1wNQJknx9BaimBLrP4dJU3GuKrdDJuagHMTjnmDxxYwQ0 CPjy3fBuTKfWp7tNfmltF8hnIgNkMmLTmqH5LhL+rnTo29ENzkJZnEPbXNgeWgVmi08+ yEQJOBSRpD6zZaHVwyG9TkcllRAX/FW8am3QmK1ShZsARB8dipimnHzr7zfo7vwIUpke xkF+hswWSU9cdB93Wm4fsLHEDgUv26vB8PhXiXHW3MzqjxskrAq+jbsI48ZyeRH7Fwej ac/ud7pjdXt26lpU9P8RI0OCPU2bqP38pPa9a4mOXwB097DiZN44pSEpbFE2Nb+QaIQK UWDA== X-Gm-Message-State: ANoB5pl9ZEgkaWH/yTZMXtTNw9TIvUg/bDGKEpRvrI+6asVIDoPaGaCG 9T7Y+zRnqsQsJuftkIN0R6VktQ== X-Google-Smtp-Source: AA0mqf6kfHONa8T7ELuxkKXU8LMOCkZTyUF5FwXqy9geQvr+hzrnarng0//lfGE1HAaPhG1tASpVFA== X-Received: by 2002:a05:6512:2390:b0:4ac:7d84:cba8 with SMTP id c16-20020a056512239000b004ac7d84cba8mr13811746lfv.425.1669728578076; Tue, 29 Nov 2022 05:29:38 -0800 (PST) Received: from [192.168.1.101] (95.49.125.236.neoplus.adsl.tpnet.pl. [95.49.125.236]) by smtp.gmail.com with ESMTPSA id m22-20020a197116000000b004aab0ca795csm2204040lfc.211.2022.11.29.05.29.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 05:29:37 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 14:29:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [RESEND PATCH 2/2] arm64: dts: qcom: sdm632-fairphone-fp3: Add NFC Content-Language: en-US To: Luca Weiss , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221128173744.833018-1-luca@z3ntu.xyz> <20221128173744.833018-2-luca@z3ntu.xyz> From: Konrad Dybcio In-Reply-To: <20221128173744.833018-2-luca@z3ntu.xyz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28.11.2022 18:37, Luca Weiss wrote: > Configure the node for the NQ310 chip found on this device, which is > compatible with generic nxp-nci-i2c driver. > > Signed-off-by: Luca Weiss > --- > RESEND to fix Cc > > arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > index 2920504461d3..fde93cbcd180 100644 > --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > @@ -63,6 +63,21 @@ touchscreen@48 { > }; > }; > > +&i2c_5 { > + status = "okay"; > + > + nfc@28 { > + compatible = "nxp,nq310", "nxp,nxp-nci-i2c"; Unless there was some binding change (that was not emailed to me with this email, I only got 2/2), only "nxp,nxp-nci-i2c" and "nxp,pn547", "nxp,nxp-nci-i2c" are allowed. The node looks good though. Konrad > + reg = <0x28>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; > + > + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; > + firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > &pm8953_resin { > status = "okay"; > linux,code = ;