From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gatien CHEVALLIER <gatien.chevallier@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Christophe Roullier <christophe.roullier@foss.st.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Simon Horman <horms@kernel.org>,
Tristram Ha <Tristram.Ha@microchip.com>,
Florian Fainelli <florian.fainelli@broadcom.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: document st,phy-wol property
Date: Mon, 21 Jul 2025 14:16:57 +0200 [thread overview]
Message-ID: <b220ae01-81b5-47f1-bf99-9aa0903995e1@kernel.org> (raw)
In-Reply-To: <f5c4bb6d-4ff1-4dc1-9d27-3bb1e26437e3@foss.st.com>
On 21/07/2025 14:10, Gatien CHEVALLIER wrote:
> Hello Krzysztof,
>
> On 7/21/25 13:30, Krzysztof Kozlowski wrote:
>> On 21/07/2025 13:14, Gatien Chevallier wrote:
>>> The "st,phy-wol" property can be set to use the wakeup capability of
>>> the PHY instead of the MAC.
>>
>>
>> And why would that be property of a SoC or board? Word "can" suggests
>> you are documenting something which exists, but this does not exist.
> Can you elaborate a bit more on the "not existing" part please?
Where does this property exist that you suggest that a new binding "can"
use it?
>
> For the WoL from PHY to be supported, the PHY line that is raised
> (On nPME pin for this case) when receiving a wake up event has to be
> wired to a wakeup event input of the Extended interrupt and event
> controller(EXTI), and that's implementation dependent.
So it is not "can" but some implementations do not have proper wiring.
You need to justify your commits and changes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-21 12:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 11:14 [PATCH net-next 0/4] net: add WoL from PHY support for stm32mp135f-dk Gatien Chevallier
2025-07-21 11:14 ` [PATCH net-next 1/4] dt-bindings: net: document st,phy-wol property Gatien Chevallier
2025-07-21 11:30 ` Krzysztof Kozlowski
2025-07-21 12:10 ` Gatien CHEVALLIER
2025-07-21 12:16 ` Krzysztof Kozlowski [this message]
2025-07-21 12:54 ` Gatien CHEVALLIER
2025-07-21 13:18 ` Andrew Lunn
2025-07-21 15:56 ` Gatien CHEVALLIER
2025-07-21 17:07 ` Andrew Lunn
2025-07-21 18:08 ` Florian Fainelli
2025-07-22 9:08 ` Gatien CHEVALLIER
2025-07-22 13:40 ` Andrew Lunn
2025-07-22 20:20 ` Russell King (Oracle)
2025-07-22 20:30 ` Florian Fainelli
2025-07-22 20:59 ` Andrew Lunn
2025-07-22 21:39 ` Russell King (Oracle)
2025-07-22 22:00 ` Russell King (Oracle)
2025-07-22 22:57 ` Russell King (Oracle)
2025-07-23 14:02 ` Andrew Lunn
2025-07-23 14:23 ` Andrew Lunn
2025-07-23 18:13 ` Florian Fainelli
2025-07-23 8:50 ` Gatien CHEVALLIER
2025-07-23 8:53 ` Gatien CHEVALLIER
2025-07-23 9:25 ` Russell King (Oracle)
2025-07-23 9:20 ` Russell King (Oracle)
2025-07-23 14:35 ` Gatien CHEVALLIER
2025-07-22 9:13 ` Russell King (Oracle)
2025-07-22 7:32 ` Russell King (Oracle)
2025-07-22 9:10 ` Gatien CHEVALLIER
2025-07-21 11:14 ` [PATCH net-next 2/4] net: stmmac: stm32: add WoL from PHY support Gatien Chevallier
2025-07-21 11:14 ` [PATCH net-next 3/4] net: phy: smsc: fix and improve WoL support Gatien Chevallier
2025-07-21 11:28 ` Russell King (Oracle)
2025-07-21 12:23 ` Gatien CHEVALLIER
2025-07-21 13:26 ` Andrew Lunn
2025-07-21 14:19 ` Gatien CHEVALLIER
2025-07-21 14:23 ` Andrew Lunn
2025-07-21 11:14 ` [PATCH net-next 4/4] arm: dts: st: activate ETH1 WoL from PHY on stm32mp135f-dk Gatien Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b220ae01-81b5-47f1-bf99-9aa0903995e1@kernel.org \
--to=krzk@kernel.org \
--cc=Tristram.Ha@microchip.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=christophe.roullier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=gatien.chevallier@foss.st.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).