From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29287236EAC for ; Tue, 14 Jan 2025 12:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736856636; cv=none; b=FQcLHyKSPAgWEePbicPX+9JlSp/AuwAsL39nJ9WRU3GgkNt4fxyLrDogc1qgMlYR1lT8HcI3mU4G2TdKCnzbE+nLw/sn7NPrimIuv9jL3dMV3lpRdhXgH+LFcD2ZAYklYxKfdCGpYrk/KZtcL03MaqLON+1Eif7EHxAtvKnO2WU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736856636; c=relaxed/simple; bh=aw+IE+TK30Kc5n+zyp5/ZsAebiJhM1w0EygSSnfnaI8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LUfiv7v2wtfUdBcqyZM//SP5W9bd9XbZna1Lj6b8xVQD/e6KtF2A6AAVrqmBgyqzK5dm2c3K/uczWtmYMWWB4Z2WTjukSnbgaI499CtUP1Arlv86669xSDA+sWmOIeyNLc4lTggFx3ZHT5lrKuRiPz7eQvb4jWcUDMkog7GtGeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bpXv8XeG; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bpXv8XeG" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-385e44a1a2dso328496f8f.3 for ; Tue, 14 Jan 2025 04:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736856633; x=1737461433; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=L7S3Bqm4SNa/5fzzRYJGEgkQpxjwQsp8IpalJXQqIYs=; b=bpXv8XeGst1IGZZlZ8mU/Uca4QRn8ct7zokB7JeUSjoBoSFLlQhebDe5OVovkJCVJe ZwBeaBrEGT8TETdALP0zAWbGPH7KOzIrWtrZeMeFzBKajxJpyC97/c2GUDzNORL7j3eK 1QEGMLtp8Y8fWYqY0U2vhMIamRmhxxedK4k0cr9EA/LREsatBScIZQDe5WyiBI68bjtA omDroCS9WDuSoCYu1/PsmjXRdwPoVU1acorWWyLwxUsWF2EXXvYyEAH7niXzDh38yQfv IwCeY11mrRnM5iclxu43cvXV8ORDL3VVxzoFooU0DX9sKesOvXsSqE93LPMgo4bexAmx UBsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736856633; x=1737461433; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L7S3Bqm4SNa/5fzzRYJGEgkQpxjwQsp8IpalJXQqIYs=; b=kziQk65yKXI4Q+46o/dIVPGvKFjg2FU6cUbytu8zvz2lwdBJdxmgOeRMjfmGaACMSg 74IdQCIzWC5DhpGN99hzE2Ol5EN2KkNSNE6lNtMfyHBO1U/CLWyzPr/hgUjtsvP4T4gg RqEVukGqBlMzc96Ci53t8BdG7uqMEq8WEDTSqbUEhSLQlaSyXi4Bdxb/E91WZVp1JLp2 0DFIR1E/AZuFBT+S2293OIBTAuxFH4FG+syAB5vGYw7T8xnLkwBmRwnS7SR0r9bNSVhj CG7h+iS3BgPkl7qF5ondhfgBpUch15TjnaNCERxzsYj1r9AP2OmfNPnX5Ypgc3a7wkZi sQRw== X-Forwarded-Encrypted: i=1; AJvYcCVY8hTsF757TE+mvu4jweN07L4fwIGHctzq4qBJ1Ob1PAI40aIeFtZKueNdrLD9u+DsLUXlJkSZZuGb@vger.kernel.org X-Gm-Message-State: AOJu0YxPYeDvHdGf+CMXZgKw6mfwCYPcD8TJggjmugAQMQahyOgJCBAy FE927X4qS01X6Lr73+McURtrHcKFmPGmp0ooLxeGzjxZxb7nq3qbKzrKKzgwccg= X-Gm-Gg: ASbGnctsZq5JTXhPZVYXSqRTwz2zsMqK4eIrfrcDCYLkTkm4o0PUo43kbXFRuYLugpE FiVHe/2NF6ZBy2iXT2W4NqH+CDNThBNNEtZOjf85AfG1kpN/dwmA0viLzxjuE/4Uiklb5wiEJY4 EMMsscTJGfHMoUeexuWvThSo0Bi8V9AubHbrUV3BCal2IsJeX1Yu8FUbGaGMfGcYnQ05wOumGWH dnFgAZo8jTVjshsYe+SdYVRlS46HDCAJ7zgRBusTPvUYDZqSPGWJk5sM4Ps+LK6G8+gVZjsYnx4 X-Google-Smtp-Source: AGHT+IEyJ/lzH1HupLPZyyqFfgaVEsvS8mYjH3oZgQAV4JnCkZ/mE9gYnmXZGtd/cwlAg1EayO2C/Q== X-Received: by 2002:a5d:648f:0:b0:385:f479:ef46 with SMTP id ffacd0b85a97d-38a87310d7bmr7823496f8f.13.1736856633432; Tue, 14 Jan 2025 04:10:33 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38c6dbsm14958381f8f.55.2025.01.14.04.10.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 04:10:32 -0800 (PST) Message-ID: Date: Tue, 14 Jan 2025 13:10:30 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: clock: convert stm32 rcc bindings to json-schema To: Dario Binacchi Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Alexandre Torgue , Conor Dooley , Krzysztof Kozlowski , Maxime Coquelin , Michael Turquette , Philipp Zabel , Rob Herring , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20250114091128.528757-1-dario.binacchi@amarulasolutions.com> <20250114091128.528757-2-dario.binacchi@amarulasolutions.com> <79a90c01-9e21-4e3f-a334-6ba9e1df4150@kernel.org> <54b63cfc-7a51-4b69-8b32-eb7591b2169b@kernel.org> <581275bf-11f3-4a8a-8e58-75b00c515c79@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 14/01/2025 12:25, Dario Binacchi wrote: > On Tue, Jan 14, 2025 at 11:13 AM Krzysztof Kozlowski > wrote: >> >> On 14/01/2025 11:00, Dario Binacchi wrote: >>> On Tue, Jan 14, 2025 at 10:48 AM Krzysztof Kozlowski wrote: >>>> >>>> On 14/01/2025 10:36, Dario Binacchi wrote: >>>>>> Nothing improved here. >>>>> >>>>> In my humble opinion, there is nothing to improve. Any modification >>>>> made causes the tests to fail. >>>>> >>>>> $ git grep st,stm32f746-rcc arch/ >>>>> arch/arm/boot/dts/st/stm32f746.dtsi: compatible = >>>>> "st,stm32f746-rcc", "st,stm32-rcc"; >>>>> arch/arm/boot/dts/st/stm32f769-disco.dts: compatible = >>>>> "st,stm32f769-rcc", "st,stm32f746-rcc", "st,stm32-rcc"; >>>>> >>>>> Or am I missing something? >>>> >>>> How can I know what you are missing if you do not show the code? >>> >>> Sorry, but I still can't understand. I run multiple tests, trying to >> >> You don't understand that I cannot improve your code if I do not see the >> code? So let me rephrase: In order to tell what is wrong with some sort >> of code, I need to see it. I cannot tell what is wrong with code without >> seeing it. > > You told me that this code was not exactly correct for the parts > marked with *********: All places with same fallbacks should be unified. You have at least two of such groups. > > properties: > compatible: > oneOf: > - items: > - const: st,stm32f42xx-rcc > - const: st,stm32-rcc > - items: > - enum: > - st,stm32f469-rcc > - const: st,stm32f42xx-rcc > - const: st,stm32-rcc > - items: > - const: st,stm32f746-rcc ******** > - const: st,stm32-rcc > - items: > - enum: > - st,stm32f769-rcc > - const: st,stm32f746-rcc > - const: st,stm32-rcc > - items: > - const: st,stm32h743-rcc ********* > - const: st,stm32-rcc > > I haven't found a way to make changes to those elements without causing the > tests to fail. Could you kindly provide more explicit guidance on the kind of > modification you're expecting? > items: - enum: - foo - bar - const: baz Like I said: all Qcom bindings. Probably all NXP as well. Best regards, Krzysztof