From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Piyush Malgujar <pmalgujar@marvell.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
adrian.hunter@intel.com, ulf.hansson@linaro.org,
p.zabel@pengutronix.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
yamada.masahiro@socionext.com, devicetree@vger.kernel.org
Cc: jannadurai@marvell.com, cchavva@marvell.com,
Dhananjay Kangude <dkangude@cadence.com>
Subject: Re: [PATCH v4 3/6] mmc: sdhci-cadence: SD6 controller support
Date: Mon, 17 Jul 2023 22:04:50 +0200 [thread overview]
Message-ID: <b236b46f-d6de-21f1-d535-680518a0b945@linaro.org> (raw)
In-Reply-To: <20230717125146.16791-4-pmalgujar@marvell.com>
On 17/07/2023 14:51, Piyush Malgujar wrote:
> From: Dhananjay Kangude <dkangude@cadence.com>
>
> Add support for SD6 controller for Marvell CN10k SoCs and related ops
> along with support for HS400 and HS400ES emmc modes.
> Updated HS200 tuning values and support to read tune configuration
> from FDT and support to configure and read host side drive strength,
> slew from device tree.
>
...
> static void sdhci_cdns_hs400_enhanced_strobe(struct mmc_host *mmc,
> struct mmc_ios *ios)
> {
> @@ -518,8 +1752,11 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> struct sdhci_pltfm_host *pltfm_host;
> struct sdhci_cdns_priv *priv;
> struct clk *clk;
> + bool sd6_ctrl;
> int ret;
> struct device *dev = &pdev->dev;
> + sd6_ctrl = of_device_is_compatible(dev->of_node, "marvell,cdns-sd6hc");
Don't sprinkle compatibles in probe. You have match data for quirks and
flags.
> +
> static const u16 version = SDHCI_SPEC_400 << SDHCI_SPEC_VER_SHIFT;
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-17 20:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 12:51 [PATCH v4 0/6] mmc: sdhci-cadence: SD6 controller support Piyush Malgujar
2023-07-17 12:51 ` [PATCH v4 1/6] mmc: sdhci-cadence: Rename functions/structures to SD4 specific Piyush Malgujar
2023-07-26 12:41 ` Adrian Hunter
2023-07-17 12:51 ` [PATCH v4 2/6] mmc: sdhci-cadence: Restructure the code Piyush Malgujar
2023-07-26 12:41 ` Adrian Hunter
2023-07-17 12:51 ` [PATCH v4 3/6] mmc: sdhci-cadence: SD6 controller support Piyush Malgujar
2023-07-17 20:04 ` Krzysztof Kozlowski [this message]
2023-07-26 12:41 ` Adrian Hunter
2023-07-17 12:51 ` [PATCH v4 4/6] mmc: sdhci-cadence: enable MMC_SDHCI_IO_ACCESSORS support Piyush Malgujar
2023-07-26 12:42 ` Adrian Hunter
2023-07-17 12:51 ` [PATCH v4 5/6] dt-bindings: mmc: sdhci-cadence: SD6 support Piyush Malgujar
2023-07-17 18:31 ` Conor Dooley
2023-07-17 20:06 ` Krzysztof Kozlowski
2023-07-17 12:51 ` [PATCH v4 6/6] mmc: sdhci-cadence: Add debug option for SD6 controller Piyush Malgujar
2023-07-18 16:10 ` kernel test robot
2023-07-26 12:42 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b236b46f-d6de-21f1-d535-680518a0b945@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=cchavva@marvell.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dkangude@cadence.com \
--cc=jannadurai@marvell.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pmalgujar@marvell.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).