From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2757EC7EE23 for ; Fri, 26 May 2023 16:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237386AbjEZQzH (ORCPT ); Fri, 26 May 2023 12:55:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbjEZQzG (ORCPT ); Fri, 26 May 2023 12:55:06 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F9E0A3; Fri, 26 May 2023 09:55:05 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D091E846EF; Fri, 26 May 2023 18:55:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1685120102; bh=cKTPC7NLR+bUlQkhK5KxByysIc4mZo54tKRP17auFUI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QhIDWXJXStcEmnXV38Ng5kZJWd00HFalkT8KayTgOFZLVG5y+iCtPv2ioz3sjzVXQ 53K2Rf2asrVBEXTNXqlBcz5hwBa6xlsCCrUWl+UGEKDju7QBAer4wfSOrRrJJ4leqx TEGyYwhq7QHwEcKXQbXIqNe5ThipdWqODbr+HZmu/d/CGwDdoNsI8Fllg/S6CzAvUz b+CZyuNS5uxYMarcKoXVZnIyMQKSE5uNasCYh2BHnGbB/s9UQhlTc49+ow3Q8H/Xxl uRtjmX2gjmwDmVhFncVTigQdgNMXxDDJ/JT5b5WDKqrbU39RS3z61/nOYJ518qJhqr 9py0Ak53Z8yYA== Message-ID: Date: Fri, 26 May 2023 18:55:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 3/3] ARM: dts: stm32: fix several DT warnings on stm32mp15 Content-Language: en-US To: Raphael Gallais-Pou , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Philippe Cornu , Yannick Fertre Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@dh-electronics.com References: <20230517143542.284029-1-raphael.gallais-pou@foss.st.com> <20230517143542.284029-4-raphael.gallais-pou@foss.st.com> <5f201903-17cb-5054-763c-f03b1066db1d@denx.de> <32fafa74-8964-c9cf-f95b-f2cd084f46c6@foss.st.com> From: Marek Vasut In-Reply-To: <32fafa74-8964-c9cf-f95b-f2cd084f46c6@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5/25/23 10:14, Raphael Gallais-Pou wrote: Hi, >> I think if you retain the stm32mp151.dtsi <dc { port { #address-cells = <1>; >> #size-cells = <0>; }; }; part, then you wouldn't be getting any warnings >> regarding LTDC , and you wouldn't have to remove the unit-address from >> endpoint@0 . >> >> btw. I do use both endpoint@0/endpoint@1 in Avenger96 DTOs, but those are not >> submitted yet, I have to clean them up a bit more first. >> >>> One way to do it would be to make the endpoint@0 go down in the device-tree with >>> its dependencies, so that both endpoints are the same level without generating >>> noise. >> >> I'm afraid I really don't quite understand which warning you're referring to. >> Can you please share that warning and ideally how to trigger it (the >> command-line incantation) ? > > Using '$ make dtbs W=1', you can observe several of the followings: > > arch/arm/boot/dts/stm32mp151.dtsi:1533.9-1536.6: Warning > (avoid_unnecessary_addr_size): /soc/display-controller@5a001000/port: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > arch/arm/boot/dts/stm32mp151.dtsi:1533.9-1536.6: Warning (graph_child_address): > /soc/display-controller@5a001000/port: graph node has single child node > 'endpoint@0', #address-cells/#size-cells are not necessary > > This <dc { port { #address-cells = <1>; #size-cells = <0>; }; }; part is > actually annoying. This is because there is several device-trees that only got > one endpoint, and some other that includes two. > > For instance: stm32mp15xx-dhcor-avenger96.dtsi vs stm32mp157c-dk2.dts. > > I would like to remove to root part of address/size field and let only the lower > device-trees with with multiple endpoints handle their own fields. I hope this > explains a bit better my process. After thinking about this some more, and digging through LTDC driver, and testing on EV1, I think dropping the LTDC node endpoint@N and reg= altogether and just using port/endpoint (singular) is fine. You might want to split the DSI node specific changes and the LTDC node specific changes into separate patches (LTDC specific change like you did in 1/3).