From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
MandyJH Liu <mandyjh.liu@mediatek.com>
Cc: iommu@lists.linux.dev, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v4 06/20] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS
Date: Tue, 2 Aug 2022 10:58:06 +0200 [thread overview]
Message-ID: <b265c106-373f-3850-2933-9418c2b515f0@linaro.org> (raw)
In-Reply-To: <20220729063208.16799-7-tinghan.shen@mediatek.com>
On 29/07/2022 08:31, Tinghan Shen wrote:
> The System Control Processor System (SCPSYS) has several power
> management related tasks in the system. Add the bindings for it.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
Thank you for your patch. There is something to discuss/improve.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/power/mt8195-power.h>
> +
> + syscon@10006000 {
> + compatible = "mediatek,mt8195-scpsys", "syscon", "simple-mfd";
> + reg = <0x10006000 0x100>;
> +
> + spm: power-controller {
> + compatible = "mediatek,mt8195-power-controller";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #power-domain-cells = <1>;
> +
> + /* sample of power domain nodes */
> + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY {
> + reg = <MT8195_POWER_DOMAIN_PCIE_PHY>;
Wrong indentation.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-02 8:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 6:31 [PATCH v4 00/20] Add driver nodes for MT8195 SoC Tinghan Shen
2022-07-29 6:31 ` [PATCH v4 01/20] dt-bindings: iommu: mediatek: Increase max interrupt number Tinghan Shen
2022-07-29 8:06 ` AngeloGioacchino Del Regno
2022-08-01 12:04 ` Yong Wu
2022-08-04 2:06 ` Tinghan Shen
2022-07-29 6:31 ` [PATCH v4 02/20] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Tinghan Shen
2022-08-16 9:21 ` (subset) " Krzysztof Kozlowski
2022-07-29 6:31 ` [PATCH v4 03/20] dt-bindings: power: mediatek: Refine multiple level power domain nodes Tinghan Shen
2022-07-29 8:06 ` AngeloGioacchino Del Regno
2022-08-25 13:34 ` Matthias Brugger
2022-07-29 6:31 ` [PATCH v4 04/20] dt-bindings: power: mediatek: Support naming power controller node with unit address Tinghan Shen
2022-07-29 8:06 ` AngeloGioacchino Del Regno
2022-08-25 13:35 ` Matthias Brugger
2022-07-29 6:31 ` [PATCH v4 05/20] dt-bindings: power: mediatek: Update maintainer list Tinghan Shen
2022-08-04 8:43 ` Matthias Brugger
2022-08-04 9:16 ` Tinghan Shen
2022-08-25 13:36 ` Matthias Brugger
2022-07-29 6:31 ` [PATCH v4 06/20] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Tinghan Shen
2022-07-29 22:59 ` Rob Herring
2022-08-02 8:58 ` Krzysztof Kozlowski [this message]
2022-08-04 2:05 ` Tinghan Shen
2022-07-29 6:31 ` [PATCH v4 07/20] arm64: dts: mediatek: Update mt81xx scpsys node to align with dt-bindings Tinghan Shen
2022-07-29 6:31 ` [PATCH v4 08/20] arm64: dts: mt8195: Disable watchdog external reset signal Tinghan Shen
2022-07-29 6:31 ` [PATCH v4 09/20] arm64: dts: mt8195: Disable I2C0 node Tinghan Shen
2022-07-29 6:31 ` [PATCH v4 10/20] arm64: dts: mt8195: Add cpufreq node Tinghan Shen
2022-07-29 6:31 ` [PATCH v4 11/20] arm64: dts: mt8195: Add vdosys and vppsys clock nodes Tinghan Shen
2022-07-29 6:32 ` [PATCH v4 12/20] arm64: dts: mt8195: Add power domains controller Tinghan Shen
2022-07-29 6:32 ` [PATCH v4 13/20] arm64: dts: mt8195: Add spmi node Tinghan Shen
2022-07-29 6:32 ` [PATCH v4 14/20] arm64: dts: mt8195: Add scp node Tinghan Shen
2022-07-29 6:32 ` [PATCH v4 15/20] arm64: dts: mt8195: Add audio related nodes Tinghan Shen
2022-07-29 6:32 ` [PATCH v4 16/20] arm64: dts: mt8195: Add adsp node and adsp mailbox nodes Tinghan Shen
2022-07-29 6:32 ` [PATCH v4 17/20] arm64: dts: mt8195: Specify audio reset controller Tinghan Shen
2022-07-29 6:32 ` [PATCH v4 18/20] arm64: dts: mt8195: Add iommu and smi nodes Tinghan Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b265c106-373f-3850-2933-9418c2b515f0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mandyjh.liu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tinghan.shen@mediatek.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).