From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7967CC00140 for ; Tue, 2 Aug 2022 08:58:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233029AbiHBI6N (ORCPT ); Tue, 2 Aug 2022 04:58:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232747AbiHBI6M (ORCPT ); Tue, 2 Aug 2022 04:58:12 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F0844B4A6 for ; Tue, 2 Aug 2022 01:58:11 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id q7so14887183ljp.13 for ; Tue, 02 Aug 2022 01:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=npQP1PTeFOBz/aH/qk/2cJgnMA7yHhXLpALhGeue+vw=; b=wrhadkP9rdiZt1XXIHzWWCrjD0rl5hQMS+ZHqpbiG8Bt2LLowIhnWcU7ppEYLP+n5h feQRYMFdysj8IjhdN8uy//PHWuS2s0gAwNG2Tl4bJRy/VJ9+pKLcCEgofn1G/zzwOdbc Bklq4hdGFHGafaOmpt8fbbRFgY2Swqfn0djw4xHaNIQUxdGw7fQt/cg6ATRE6IJ64N3u SJgUmnLAuwZUEPt3YYr+G8Cs5Yl1YdtfUahwTnkJ/1KXe+/za3ugN2PeP7+3or95tLx+ zqcqdUUdODthmLA5lyqRvz90oSbF2qfLtF5jWkgC45Uoo1xD+XGM0+Lw/wJ93t2KtsXd AgzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=npQP1PTeFOBz/aH/qk/2cJgnMA7yHhXLpALhGeue+vw=; b=pZcJ1Jwpo6cjyXCMuQzQUMcP6z4xwazHWqNG6Ha3utRIE/d6vNhMTDt/4IJ/CqGwH3 +8/8b7rkdHhMvACmG+Yzjqig42pOO2nlcxpET1tepC8RPKT6lmGDd9n153foJecVH0ak 5p1YjZkUVO/lTqaUvHunrnqomLtUmlmLyMs51j4wg9dlP63Mk4On2+dWG4nbEf0cXT/Y DzPzChJ9q7RZJ+yw5cVUKgNkeGlVZ+iCpDKVfM2RYGfT4sic+asMl/b6osfu0X+jkCOZ iDW+Kt1TT7ub07tXo5F+mxfHO+fw9jCQwCedvahSJwmvrEkSf6LCyMqMvImSnRv1DiKJ AFpA== X-Gm-Message-State: AJIora/urbczHEAedYGv3UEYq0gDAQ3hiS9e2Oe+5Udgy6e5TGPLKpHX 72xmeaPBa8I++aTNH6k4YaXmMw== X-Google-Smtp-Source: AGRyM1s6TASgKeoeefB3kojxmqJkb8Ddf94gvx/txy9BStGigDLYfFEvUo1PUBytil1oYOafbF8+hQ== X-Received: by 2002:a05:651c:179f:b0:25d:ba24:2e16 with SMTP id bn31-20020a05651c179f00b0025dba242e16mr5887088ljb.422.1659430689430; Tue, 02 Aug 2022 01:58:09 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id bf43-20020a05651225ab00b0047fae90bfb4sm2033495lfb.56.2022.08.02.01.58.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 01:58:08 -0700 (PDT) Message-ID: Date: Tue, 2 Aug 2022 10:58:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 06/20] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Content-Language: en-US To: Tinghan Shen , Yong Wu , Joerg Roedel , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Lee Jones , Matthias Brugger , AngeloGioacchino Del Regno , MandyJH Liu Cc: iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220729063208.16799-1-tinghan.shen@mediatek.com> <20220729063208.16799-7-tinghan.shen@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220729063208.16799-7-tinghan.shen@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/07/2022 08:31, Tinghan Shen wrote: > The System Control Processor System (SCPSYS) has several power > management related tasks in the system. Add the bindings for it. > > Signed-off-by: Tinghan Shen Thank you for your patch. There is something to discuss/improve. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + syscon@10006000 { > + compatible = "mediatek,mt8195-scpsys", "syscon", "simple-mfd"; > + reg = <0x10006000 0x100>; > + > + spm: power-controller { > + compatible = "mediatek,mt8195-power-controller"; > + #address-cells = <1>; > + #size-cells = <0>; > + #power-domain-cells = <1>; > + > + /* sample of power domain nodes */ > + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY { > + reg = ; Wrong indentation. Best regards, Krzysztof