From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eddie James Subject: Re: [PATCH v7 3/7] drivers/i2c: Add port structure to FSI algorithm Date: Thu, 31 May 2018 09:18:09 -0500 Message-ID: References: <1527632665-25707-1-git-send-email-eajames@linux.vnet.ibm.com> <1527632665-25707-4-git-send-email-eajames@linux.vnet.ibm.com> <8aaa7fa9874bf140354964535ce5cf023012c3f4.camel@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8aaa7fa9874bf140354964535ce5cf023012c3f4.camel@kernel.crashing.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Herrenschmidt , Andy Shevchenko Cc: linux-i2c , Linux Kernel Mailing List , devicetree , Wolfram Sang , Rob Herring , Joel Stanley , Mark Rutland , Greg Kroah-Hartman , "Edward A. James" List-Id: devicetree@vger.kernel.org On 05/30/2018 04:16 PM, Benjamin Herrenschmidt wrote: > On Wed, 2018-05-30 at 10:47 -0500, Eddie James wrote: >>>> + if (!list_empty(&i2c->ports)) { >>> My gosh, this is done already in list_for_each*() >> No, list_for_each_entry does NOT check if the list is empty or if the >> first entry is NULL. > NULL is never valid for a list. It does however check for an empty list > > It does it implicitely in the test part of the for () statement, > checking if the next pointer points back to the head. Thanks Ben. My mistake on this one; I misread the macro. I will remove the check in v9... going to wait a little for any further comments now. Thanks, Eddie > > Cheers, > Ben. > >