From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4AC3C433F5 for ; Thu, 23 Sep 2021 14:37:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94BCB611C6 for ; Thu, 23 Sep 2021 14:37:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241704AbhIWOjG convert rfc822-to-8bit (ORCPT ); Thu, 23 Sep 2021 10:39:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241565AbhIWOjF (ORCPT ); Thu, 23 Sep 2021 10:39:05 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D168C061574 for ; Thu, 23 Sep 2021 07:37:34 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTPqu-0001bZ-GD; Thu, 23 Sep 2021 16:37:32 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mTPqt-0006Po-W7; Thu, 23 Sep 2021 16:37:31 +0200 Message-ID: Subject: Re: [PATCH v4 1/3] media: imx6-mipi-csi2: use pre_streamon callback to set sensor into LP11 From: Philipp Zabel To: Michael Tretter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Marek Vasut Cc: Rob Herring , Mauro Carvalho Chehab , Sakari Ailus , kernel@pengutronix.de Date: Thu, 23 Sep 2021 16:37:31 +0200 In-Reply-To: <20210923105618.365513-2-m.tretter@pengutronix.de> References: <20210923105618.365513-1-m.tretter@pengutronix.de> <20210923105618.365513-2-m.tretter@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Michael, On Thu, 2021-09-23 at 12:56 +0200, Michael Tretter wrote: > Step 5 expects that the sensor is in LP11 mode. Use the new > pre_streamon callback to signal the sensor that it should switch into > LP11. > > Signed-off-by: Michael Tretter > --- > Changelog: > > v4: > > - new patch > --- > drivers/staging/media/imx/imx6-mipi-csi2.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c > index 9de0ebd439dc..4f19e2bce4bb 100644 > --- a/drivers/staging/media/imx/imx6-mipi-csi2.c > +++ b/drivers/staging/media/imx/imx6-mipi-csi2.c > @@ -382,13 +382,17 @@ static int csi2_start(struct csi2_dev *csi2) > csi2_enable(csi2, true); > > /* Step 5 */ > + ret = v4l2_subdev_call(csi2->src_sd, video, pre_streamon, > + V4L2_SUBDEV_PRE_STREAMON_FL_MANUAL_LP); > + if (ret) > + goto err_assert_reset; I think this should check for (ret && ret != -ENOIOCTLCMD) to avoid breaking drivers that are still missing pre_streamon implementation. regards Philipp