From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Date: Fri, 19 Jan 2018 14:12:19 -0800 Message-ID: References: <1516139101-7835-1-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1516139101-7835-1-git-send-email-jacopo+renesas@jmondi.org> Content-Language: en-US Sender: linux-media-owner@vger.kernel.org To: Jacopo Mondi , laurent.pinchart@ideasonboard.com, magnus.damm@gmail.com, geert@glider.be, hverkuil@xs4all.nl, mchehab@kernel.org, festevam@gmail.com, sakari.ailus@iki.fi, robh+dt@kernel.org, mark.rutland@arm.com, pombredanne@nexb.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 01/16/2018 01:44 PM, Jacopo Mondi wrote: > Hello, > new version of CEU after Hans' review. > > Added his Acked-by to most patches and closed review comments. > Running v4l2-compliance, I noticed a new failure introduced by the way I now > calculate the plane sizes in set/try_fmt. I would expect that you have already seen this, but I get a build error in renesas-ceu.c. Here is a small patch for it. --- From: Randy Dunlap Fix build error (on x86 with COMPILE_TEST): ../drivers/media/platform/renesas-ceu.c: In function 'ceu_parse_dt': ../drivers/media/platform/renesas-ceu.c:1497:27: error: request for member 'fwnode' in something not a structure or union ceu_sd->asd.match.fwnode.fwnode = Signed-off-by: Randy Dunlap --- drivers/media/platform/renesas-ceu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c +++ linux-next-20180119/drivers/media/platform/renesas-ceu.c @@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic ceu_sd->mbus_flags = fw_ep.bus.parallel.flags; ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE; - ceu_sd->asd.match.fwnode.fwnode = + ceu_sd->asd.match.fwnode = fwnode_graph_get_remote_port_parent( of_fwnode_handle(ep));