From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Phil Edworthy <phil.edworthy@renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 1/2] dt-bindings: usb: renesas, usb3-peri: Document RZ/V2M r9a09g011 support
Date: Tue, 19 Jul 2022 08:37:35 +0200 [thread overview]
Message-ID: <b26f2353-c5f3-16f4-11c8-63068baeada5@linaro.org> (raw)
In-Reply-To: <TYYPR01MB70868B846CAB2F7124148771F58C9@TYYPR01MB7086.jpnprd01.prod.outlook.com>
On 18/07/2022 17:24, Phil Edworthy wrote:
>>> phys:
>>> maxItems: 1
>>> @@ -43,7 +65,15 @@ properties:
>>> maxItems: 1
>>>
>>> resets:
>>> - maxItems: 1
>>> + minItems: 1
>>> + items:
>>> + - description: Peripheral reset
>>> + - description: DRD reset
>>> +
>>> + reset-names:
>>> + items:
>>> + - const: aresetn_p
>>> + - const: drd_reset
>>>
>>> usb-role-switch:
>>> $ref: /schemas/types.yaml#/definitions/flag
>>> @@ -78,6 +108,27 @@ required:
>>> - interrupts
>>> - clocks
>>>
>>> +allOf:
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - renesas,rzv2m-usb3-peri
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 2
>>> + interrupts:
>>> + minItems: 2
>>> + resets:
>>> + minItems: 2
>>> + required:
>>> + - clock-names
>>> + - interrupt-names
>>> + - resets
>>> + - reset-names
>>
>> else:
>> narrow the number of items
> Sorry, I don't understand why we need minItems: 1 for
> interrupt-names/clock-names, but then I'm easily confused!
>
> None of the existing users have any interrupt-names/clock-names
> hence they are not in required. The rzv2m is the only device
> that needs them so the driver can get them by name, and hence
> it sets minItems: 2
They are not required but they can appear. Nothing prevents it, based on
your patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-19 6:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 13:44 [PATCH 0/2] Add usb gadget support for RZ/V2M Phil Edworthy
2022-07-18 13:44 ` [PATCH 1/2] dt-bindings: usb: renesas, usb3-peri: Document RZ/V2M r9a09g011 support Phil Edworthy
2022-07-18 13:55 ` Krzysztof Kozlowski
2022-07-18 15:24 ` Phil Edworthy
2022-07-19 6:37 ` Krzysztof Kozlowski [this message]
2022-07-19 9:01 ` Phil Edworthy
2022-07-19 9:13 ` Krzysztof Kozlowski
2022-07-21 10:58 ` Phil Edworthy
2022-07-21 12:12 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b26f2353-c5f3-16f4-11c8-63068baeada5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).