From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexandre Mergnat <amergnat@baylibre.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] spi: spidev: add new mediatek support
Date: Fri, 20 Jan 2023 08:44:31 +0100 [thread overview]
Message-ID: <b277b67c-bd00-a543-1945-f986134a78f7@linaro.org> (raw)
In-Reply-To: <CAFGrd9rtO0B2XWEEU6gtv39PndjdjLL6tbRWimWT3RvLu1GFrQ@mail.gmail.com>
On 19/01/2023 20:18, Alexandre Mergnat wrote:
> Le jeu. 19 janv. 2023 à 17:49, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> a écrit :
>>
>> On 19/01/2023 17:28, Alexandre Mergnat wrote:
>>> { .compatible = "micron,spi-authenta", .data = &spidev_of_check },
>>> + { .compatible = "mediatek,genio", .data = &spidev_of_check },
>>
>> Please run scripts/checkpatch.pl and fix reported warnings.
>
> Actually I did.
> I saw: "WARNING: DT compatible string "mediatek,genio" appears
> un-documented -- check ./Documentation/devicetree/bindings/"
> But there are no bindings for spidev.
There are. Just some other people were as well ignoring warnings. What
is the purpose of having tools if people keep ignoring the warnings, sigh...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-20 7:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 16:28 [PATCH 0/2] Add MediaTek MT8365 SPI support Alexandre Mergnat
2023-01-19 16:28 ` [PATCH 1/2] arm64: dts: mediatek: add spidev support for mt8365-evk board Alexandre Mergnat
2023-01-19 16:28 ` [PATCH 2/2] spi: spidev: add new mediatek support Alexandre Mergnat
2023-01-19 16:39 ` Mark Brown
2023-01-19 16:40 ` Matthias Brugger
2023-01-19 16:49 ` Krzysztof Kozlowski
2023-01-19 19:18 ` Alexandre Mergnat
2023-01-20 7:44 ` Krzysztof Kozlowski [this message]
2023-01-20 7:58 ` Krzysztof Kozlowski
2023-01-20 7:47 ` Krzysztof Kozlowski
2023-01-23 10:06 ` Alexandre Mergnat
2023-01-23 15:55 ` Krzysztof Kozlowski
2023-01-20 8:20 ` Michael Walle
2023-01-23 9:37 ` Alexandre Mergnat
2023-01-23 10:44 ` Michael Walle
2023-01-23 14:57 ` Alexandre Mergnat
2023-01-23 12:19 ` Mark Brown
2023-01-23 15:07 ` Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b277b67c-bd00-a543-1945-f986134a78f7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amergnat@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).