From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309F5C433EF for ; Sat, 2 Apr 2022 12:30:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242376AbiDBMby (ORCPT ); Sat, 2 Apr 2022 08:31:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242383AbiDBMby (ORCPT ); Sat, 2 Apr 2022 08:31:54 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F3D24F9E2 for ; Sat, 2 Apr 2022 05:30:02 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id d7so7718952wrb.7 for ; Sat, 02 Apr 2022 05:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=WHHY6/AA+RV5B6HQp/JMxKSATkAk8e0U+XPm3mIVbG4=; b=w0+Pu5NJu0h1cXv19IbjAmNV5ldGQMzlT1e5o18hrVpSP81bd/f43dGd4yCkcjnXFj R2qlaT8dm6+KGQHjMYI04hf69HstNdN/nB7hBe9L6nw7imHMUmYH62EuePSEGeotSAyo TMYbT9Rl0CP6maAEFQJhy0+zlZZYuue+n0MScmtkGpgZXbQ/jCVFOhunGuUpuXOT7DY6 ++1yAu+IKf8/nhs+mI8cEXHjLfuxqOLTiQVnSp14MrHUZJctA7D9dx7v01OJSVxKR5YV Jjw5XaIx4iuyqjwSE8ny0tXsCnqRScAYHTaFNURSwCIo602rpbOAl+bStzbU7xV3EaaW /9iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WHHY6/AA+RV5B6HQp/JMxKSATkAk8e0U+XPm3mIVbG4=; b=ZhFbmRTYjG9NqSKZJ/9Gyq3eMrpWIpDA07SkM58tNQeF0ZH//cRI9T8Hxw/A/yfN20 ZFRXLqzmNNhw+b86TWQzCCSbYY/qtltzgOOK59cA5TQjhIwRnu1NMldJHgUc9szd6DoY H4S2nepRlOxm/j5ZnY0vXPnK94dhV+uzKHRRQZbSgIWPk09fHY1/CcJyCTeTKyYfOpyD ufeAvAIIfALaSIV+9uM1WlKCl3cV6XaqSK61RP7ien0pN9k8QBL9GWFubTwJUQk4PHln gIPN/NrOTfr4/2BMglY6705qo7yVQXfHRnasfu2P+ssZ0NJvQacJwtxNDyKc0XFFFPCu 1fXw== X-Gm-Message-State: AOAM532CM4RMiZhOMQZE93Y3uyMgxguY9jqPr9YDeb3gBHsWt463rihB dbYQRdGEUXh7BVJPVzUi6pN1Tg== X-Google-Smtp-Source: ABdhPJwdpU3ivl1IB9fl4GewiNTFa7+yJoV0fEBquDI28ZJajPWiHd7NxgeG3sRDbNbcE2+dDMylew== X-Received: by 2002:a5d:47a7:0:b0:203:d1b4:8f6 with SMTP id 7-20020a5d47a7000000b00203d1b408f6mr11192742wrb.36.1648902600596; Sat, 02 Apr 2022 05:30:00 -0700 (PDT) Received: from [192.168.0.171] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id r4-20020a1c2b04000000b0038a0e15ee13sm12705690wmr.8.2022.04.02.05.29.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Apr 2022 05:30:00 -0700 (PDT) Message-ID: Date: Sat, 2 Apr 2022 14:29:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/5] dt-bindings: i2c: Add Qualcomm Geni based QUP i2c bindings Content-Language: en-US To: Kuldeep Singh , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org References: <20220402051206.6115-1-singh.kuldeep87k@gmail.com> <20220402051206.6115-2-singh.kuldeep87k@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220402051206.6115-2-singh.kuldeep87k@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/04/2022 07:12, Kuldeep Singh wrote: > GENI(generic interface) based Qualcomm Universal Peripheral controller > can support multiple serial interfaces like spi,uart and i2c. > > Unlike other i2c controllers, QUP i2c bindings are present in parent > schema. Move it out from parent to an individual binding and let parent > refer to child schema later on. > > Please note, current schema isn't complete as it misses out few > properties and thus, add these missing properties along the process. > > Signed-off-by: Kuldeep Singh > --- > .../bindings/i2c/qcom,i2c-geni-qcom.yaml | 110 ++++++++++++++++++ > 1 file changed, 110 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > new file mode 100644 > index 000000000000..01a02e680ea3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > @@ -0,0 +1,110 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/i2c/qcom,i2c-geni-qcom.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Geni based QUP I2C Controller > + > +maintainers: > + - Andy Gross > + - Bjorn Andersson > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,geni-i2c Just const, no enum. There are no other flavors of this (unless you think there are?). > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: se > + > + clock-frequency: > + description: Desired I2C bus clock frequency in Hz > + default: 100000 > + > + interconnects: > + maxItems: 3 > + > + interconnect-names: > + items: > + - const: qup-core > + - const: qup-config > + - const: qup-memory > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + required-opps: > + maxItems: 1 I have doubts this is correct property. Usually it is part of the opp-table. I see sc7180 needs this, but I think it is a mistake. Do you know how it is supposed to work? Best regards, Krzysztof