From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40C5D1946AA; Sat, 16 Nov 2024 20:07:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.62.61 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731787665; cv=none; b=No6rwdoVeUkOjRgCg2sExtSKyfSAA9jGpdk+wwpE59ZJXGEpJRNh9pF0Q+6npJD+zKotJrLMNxKDNWTdVVAz697PxV3VAWVyOl/8Kt/hkKK6Sx1VavpjVp5HhciO4wY0HAL+42JFPIz+/3KY2S0k8BQuvCSiBkOAt5CWCh4QFQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731787665; c=relaxed/simple; bh=5rtxGu68PLWrXyTEJNBr68hhrntpwpZdOSN9YWdsbfY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qxiVqSsmdln+TjVfPRmDgwPyjT3nA7y3o5lzewuNKz/WLYdmENM+91eclN2OSQ85pNrv+VNgnLfiWULn69XiWdN01myxb8V8dnYLolXF2K93rwmABeR6RSQlJJLuk67IDnkt2mzYgJsuQtoozXZokA9tbqaByVGwNJIlLjCb01I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=JQOZxKP3; arc=none smtp.client-ip=85.214.62.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="JQOZxKP3" Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 40BBA89698; Sat, 16 Nov 2024 21:07:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1731787655; bh=msWG5qnuSAmchrjZIHWSe5yibi3jg0xEpfJtIVvoQA0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JQOZxKP3VnpaHDzeb2po7GNni8qWiMQve1IWLtAaq1+5mSjtN24PUPimlzF/6AHC1 U8a+ONq23zJkAah8DAfn22UvOArHyWcUDdkBSWpKHFlb6IY8OYZmywqxK4Q3295oFF fPv6GRs5arWYat28D4lnKYRN1DAbvUdj5ndlmYt9fsGrMWp+Ld34ORgN+sVhT0r5Qv qyr5Bb6JCRB98vN4avDSYVag8IDSLlol/nUZRmeok5Yrn1pzUg3Da6UxSnhJUFCLM3 mLOGXtKy2197fkhOCAXvKQuWikwhkiqxMNKQxZsDmMs+clqx+AH4W0ISuqxOI+XUj1 Udg2euHimVxRw== Message-ID: Date: Sat, 16 Nov 2024 20:57:36 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: wilc1000: Rework bus locking To: Ajay.Kathat@microchip.com, alexis.lothore@bootlin.com, linux-wireless@vger.kernel.org Cc: davem@davemloft.net, adham.abozaeid@microchip.com, claudiu.beznea@tuxon.dev, conor+dt@kernel.org, edumazet@google.com, kuba@kernel.org, kvalo@kernel.org, krzk+dt@kernel.org, pabeni@redhat.com, robh@kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org References: <20241022013855.284783-1-marex@denx.de> <8e28ba76-ecfa-49b6-89b5-1edabb22129d@denx.de> <5e2a5056-78ac-4be0-83ca-4aa55f524535@denx.de> <880baad9-be3d-41b2-bea3-620f915ca397@microchip.com> <9d20b408-72a4-49f0-aca6-108dfdd65f99@denx.de> <16e5c8d7-64ac-424e-9430-b683ae16a34e@denx.de> <9888f605-ee68-4bd3-8d1d-aeef247d23d0@microchip.com> <260a505e-53ec-4f1d-94fe-2b71af48f1b7@denx.de> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 11/15/24 9:04 PM, Ajay.Kathat@microchip.com wrote: Hello Ajay, >>>>> Can you explain how to prevent that or shall we disable uAPSD >>>>> altogether ? >>>> >>>> Could you please share the test procedure and logs. I am occupied at the >>>> moment but I shall make some time to look into it and get a better >>>> understanding. >>> >>> The simplest test procedure is this: >>> >>> $ while true ; do ifconfig wlan0 up ; ifconfig wlan0 down ; done >>> >>> As for the logs, MMCI controller sporadically reports either Command or >>> Data CRC error, so likely the SDIO response (from WILC to Host) is >>> corrupted. >> >> Are there any news ? > > I did test the same procedure in my setup, but I couldn't reproduce this issue > even after running it for a long duration. In my test setup, I used the > sama5d27-som1-ek1 host and wilc3000 firmware version 16.3. > > I think this issue could be related to the host MMCI controller driver. > Normally, the wilc SDIO bus failures are captured by driver logs with an error > code (e.g., timeout), but if the MMCI controller is outputting the warning > message, then the error could be related to it. Does the MMCI controller error > point to any specific function? Either CMD52 or CMD53 errors out with CRC error, this is recognized by the controller. That points to sporadic CRC error during SDIO transfer. > Which host was used to test this scenario, and > is it possible to test with different host or different configuration on the > same host I am observing sporadic command and data CRC errors on STM32MP157F system with SDIO WILC3000. , like disabling power save on the host? I already tested disabling power save. Can you explain why does uAPSD (iw ...set power_save off) adversely affect SDIO bus stability ? Can you explain how to prevent that or shall we disable uAPSD altogether ? Is there any way to make the WILC firmware produce debug output , so we can figure out what is going on "on the other side" ? Are you able to provide me (maybe off-list) some debug firmware build ? (or can I get firmware sources and build and debug my own WILC firmware on the Cortus CPU?) I can trigger the SDIO errors even without being connected to any AP , so this is something between the WILC and the SDIO host, the radio is likely not involved , right ?