From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Vasut <marex@denx.de>, Jonathan Cameron <jic23@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH] dt-bindings: non-dt-devices: document ltr,ltrf216a used via ACPI PRP0001
Date: Thu, 11 Jul 2024 09:57:55 +0200 [thread overview]
Message-ID: <b288d373-a1bc-46b9-9a08-4d949d1bd2bc@linaro.org> (raw)
In-Reply-To: <CAL_JsqL-wLzHmYN9Lntth3TKgpjfj3jxoGD5T49gSkDSMR=S_Q@mail.gmail.com>
On 09/07/2024 22:48, Rob Herring wrote:
> On Tue, Jul 9, 2024 at 11:15 AM Rob Herring <robh@kernel.org> wrote:
>>
>> On Tue, Jul 09, 2024 at 10:44:01AM +0200, Krzysztof Kozlowski wrote:
>>> There is a device in the wild with non-updatable firmware coming with
>>> ACPI tables with rejected "ltr,ltrf216a" compatible. Linux kernel still
>>> supports this device via ACPI PRP0001, however the compatible was never
>>> accepted to bindings. Lack of bindings causes checkpatch.pl warning
>>> about undocumented compatible.
>>
>> Why do we care? For checkpatch.pl I really don't. That hack check I
>> wrote makes any string in binding docs a documented compatible. I have a
>> better check using the schema written, but that would make checkpatch
>> dependent on dtschema tools. So maybe just time to drop this check from
>> checkpatch as we have other ways to check and track this.
People still use checkpatch - both to actually test patches before
sending and also to fix random existing issues.
>>
>> However, I do care about 'make dt_compatible_check'. Besides these ACPI
>> cases, there's a bunch of cases that we'll never have schemas for. Like
>> everything from Sparc... Old PowerMac stuff... So I would like to
>> 'document' them just to exclude from dt_compatible_check. So perhaps
>> this should be generalized.
Sure, I can rewrite it to more generic.
>
> Here's my list of what's really not documented. It's just a grep of
> the bindings of each compatible found by 'make dt_compatible_check'.
> Probably anything with SUNW, ibm, amcc, or mpc5 is never going to be
> documented.
>
> There are some false positives such as cases documented like "fsl,<chip>-guts".
I'll come with something, maybe incomplete but it could grow later.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-07-11 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 8:44 [PATCH] dt-bindings: non-dt-devices: document ltr,ltrf216a used via ACPI PRP0001 Krzysztof Kozlowski
2024-07-09 17:02 ` Rob Herring
2024-07-09 20:48 ` Rob Herring
2024-07-11 7:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b288d373-a1bc-46b9-9a08-4d949d1bd2bc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).