From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 077BCC77B76 for ; Tue, 18 Apr 2023 07:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230420AbjDRHan (ORCPT ); Tue, 18 Apr 2023 03:30:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbjDRHam (ORCPT ); Tue, 18 Apr 2023 03:30:42 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C7463C0D for ; Tue, 18 Apr 2023 00:30:41 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5058181d58dso4737366a12.1 for ; Tue, 18 Apr 2023 00:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681803040; x=1684395040; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rVgNSlQei7ClLmAXgHdLYMij5O05eDXWOobwGEh17DQ=; b=vR0c1V6fHjkOyv3+jlpqY5zM6LZj07DmVTLUWBjOaBOnR6s/0Baom+vEKaqJuhxeZ/ Xc2D6F3qbZCYol/JMWRydydPtMlGMn5e+nfsLiGcOe5rc+35obwyzfmNe1GgK97zBtTt 1Koogst0alt2YUOp73Y6GIQGW4PtGqo+3GIbQ5sYJDaUBLFX+vSBPMZa8Z6RiFe+5SP9 yt3weQk73jK4zbBsH2P4E87ne3NJ2xeH/QFqzjwYBdS26g7e7C44okeVj6RGWC5JQhu+ im64hz/ErmPn7+rNBHTtTkWqnC+09/Ynd1k5kWaNwVHcekfYvFmrb29OqVqmTdj8tHfQ sdLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681803040; x=1684395040; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rVgNSlQei7ClLmAXgHdLYMij5O05eDXWOobwGEh17DQ=; b=UnK6xAjMQSIfL1SGXWMXEen3nlJMUC0qCte+yqRWuAKwgHc0bmKClrdXa1V5mw786A YpHZG1plhHbnc2dXrOyKiSOmrUWhblJDrlIbvX0VtSp5RIqaBElav0frCZrDEh6+LAEj Tb86/Fifrf2UHzN30HQuhJH6yiggzH/rZeIh10ld191RGtVTdGK50y1mnKupHBMs+e0P AUOxG0UM8nz0qy2DtQCXl7fi6HL9Rk3Whf3NNHRquzIOR+ICrtS5qKSbSp2GrSDhmNMV 6zEtsqC8VOZILuP5uP65SXS21h9edCmvnra1m7vW5tvoSyzmlF+fOz9eTcOwxZPhblvO /oPQ== X-Gm-Message-State: AAQBX9dXvftDIrKcQj3bYBzJONvRGn4Mp+ppOMusaXfSt1hm3sbLtqsD SxDTPhZ0sUcQhTJWVP+//eDiQA== X-Google-Smtp-Source: AKy350Zoyxpwx+/pSMVZgdFa6Mkl6usfBX3ptXBL+sCtn0/rIgDyyeOnSAiaOQ8GnTcResGJW+JT7A== X-Received: by 2002:a50:fb17:0:b0:502:70e9:2c14 with SMTP id d23-20020a50fb17000000b0050270e92c14mr1498794edq.29.1681803039878; Tue, 18 Apr 2023 00:30:39 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a276:7d35:5226:1c77? ([2a02:810d:15c0:828:a276:7d35:5226:1c77]) by smtp.gmail.com with ESMTPSA id m21-20020a509995000000b0050684020babsm5369235edb.27.2023.04.18.00.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 00:30:39 -0700 (PDT) Message-ID: Date: Tue, 18 Apr 2023 09:30:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] dt-bindings: phy: qmp-ufs: fix clock and clock-names for sa8775p Content-Language: en-US To: Bartosz Golaszewski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Bartosz Golaszewski References: <20230417130522.401605-1-brgl@bgdev.pl> From: Krzysztof Kozlowski In-Reply-To: <20230417130522.401605-1-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/04/2023 15:05, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We must set *minItems* to 3, not maxItems as this platform requires > exactly three clocks and maxItems is already set to 3 globally. > > Fixes: e5796a9cdf73 ("dt-bindings: phy: qmp-ufs: describe the UFS PHY for sa8775p") Your change makes the code easier to read (more obvious), so I am okay with the change, but I am not okay with commit msg and Fixes tag. Issue is described inaccurately. There is nothing to fix here, because original code was correct. maxItems:3 in implies minItems:3, thus everything worked as should. Feel free to re-phrase the commit msg and remove the Fixes tag. > Signed-off-by: Bartosz Golaszewski > --- Best regards, Krzysztof