* [PATCH] dt-bindings: phy: qmp-ufs: fix clock and clock-names for sa8775p
@ 2023-04-17 13:05 Bartosz Golaszewski
2023-04-18 7:30 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2023-04-17 13:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel, linux-scsi,
Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
We must set *minItems* to 3, not maxItems as this platform requires
exactly three clocks and maxItems is already set to 3 globally.
Fixes: e5796a9cdf73 ("dt-bindings: phy: qmp-ufs: describe the UFS PHY for sa8775p")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
.../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
index 94c0fab065a8..a1897a7606df 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
@@ -78,9 +78,9 @@ allOf:
then:
properties:
clocks:
- maxItems: 3
+ minItems: 3
clock-names:
- maxItems: 3
+ minItems: 3
else:
properties:
clocks:
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dt-bindings: phy: qmp-ufs: fix clock and clock-names for sa8775p
2023-04-17 13:05 [PATCH] dt-bindings: phy: qmp-ufs: fix clock and clock-names for sa8775p Bartosz Golaszewski
@ 2023-04-18 7:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-18 7:30 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel, linux-scsi,
Bartosz Golaszewski
On 17/04/2023 15:05, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> We must set *minItems* to 3, not maxItems as this platform requires
> exactly three clocks and maxItems is already set to 3 globally.
>
> Fixes: e5796a9cdf73 ("dt-bindings: phy: qmp-ufs: describe the UFS PHY for sa8775p")
Your change makes the code easier to read (more obvious), so I am okay
with the change, but I am not okay with commit msg and Fixes tag. Issue
is described inaccurately. There is nothing to fix here, because
original code was correct.
maxItems:3 in implies minItems:3, thus everything worked as should.
Feel free to re-phrase the commit msg and remove the Fixes tag.
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-18 7:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-17 13:05 [PATCH] dt-bindings: phy: qmp-ufs: fix clock and clock-names for sa8775p Bartosz Golaszewski
2023-04-18 7:30 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).