From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings Date: Mon, 5 Dec 2016 11:23:25 +0100 Message-ID: References: <1480326567-6132-1-git-send-email-harinik@xilinx.com> <20161203213553.f3agwvaseufglnq6@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Harini Katakam , Rob Herring Cc: Harini Katakam , David Miller , Pawel Moll , Mark Rutland , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Boris Brezillon , alexandre.belloni@free-electrons.com, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "michals@xilinx.com" List-Id: devicetree@vger.kernel.org Le 05/12/2016 à 03:55, Harini Katakam a écrit : > Hi Rob, > > > Thanks for the review. > On Sun, Dec 4, 2016 at 3:05 AM, Rob Herring wrote: >> On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: > >>> +Required properties: >>> +- compatible: Should be "cdns,macb-mdio" >> >> Only one version ever? This needs more specific compatible strings. >> > > This is part of the Cadence MAC in a way. > I can use revision number from the Cadence spec I was working with. > But it is not necessarily specific that version. Yes it is: you must specify the first precise SoC needing/implementing it: "cdns,zynqmp-gem-mdio" or "xlnx,zynq-gem-mdio" or anything looking like this. So, if an Atmel implementation is slightly different, we can still use our own "atmel,sama5d2-gem-mdio" or "cdns,sama5d2-gem-mdio" compatibility string. On the other hand, if it's strictly the same, we can use the "xlnx,zynq-gem-mdio" compatibility without any problem... > I'll take care of the other comments in the next version. > > Regards, > Harini > -- Nicolas Ferre