From: "André Draszik" <andre.draszik@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: exynos: gs101-pixel-common: add Maxim MAX77759 PMIC
Date: Fri, 27 Jun 2025 09:54:16 +0100 [thread overview]
Message-ID: <b2c3b78d60f3dc3e4576e8b79298e22ea46567c6.camel@linaro.org> (raw)
In-Reply-To: <2c491166-d8ae-4fb6-a4f7-74e823e1205d@kernel.org>
Hi Krzysztof,
On Thu, 2025-06-26 at 21:49 +0200, Krzysztof Kozlowski wrote:
> On 24/05/2025 07:21, André Draszik wrote:
> > +
> > + gpio {
> > + compatible = "maxim,max77759-gpio";
> > +
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + /*
> > + * "Human-readable name [SIGNAL_LABEL]" where the
> > + * latter comes from the schematic
> > + */
> > + gpio-line-names = "OTG boost [OTG_BOOST_EN]",
> > + "max20339 IRQ [MW_OVP_INT_L]";
> > +
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
> > + };
> > +
> > + nvmem-0 {
>
> Why is this called nvmem-0, not nvmem? Is there nvmem-1? I see binding
> does it, but why?
'nvmem' is used/declared by nvmem-consumer.yaml as a phandle array
already so using just 'nvmem' fails validation:
Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: pmic@66: nvmem: {'compatible': ['maxim,max77759-nvmem'], 'nvmem-
layout': {'compatible': ['fixed-layout'], '#address-cells': 1, '#size-cells': 1, 'reboot-mode@0': {'reg': [[0, 4]]}, 'boot-reason@4':
{'reg': [[4, 4]]}, 'shutdown-user-flag@8': {'reg': [[8, 1]]}, 'rsoc@10': {'reg': [[10, 2]]}}} is not of type 'array'
from schema $id: http://devicetree.org/schemas/nvmem/nvmem-consumer.yaml#
https://lore.kernel.org/all/20250226-max77759-mfd-v2-3-a65ebe2bc0a9@linaro.org/
Cheers,
Andre'
next prev parent reply other threads:[~2025-06-27 8:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-24 5:21 [PATCH v2 0/4] gs101 max77759 enablement (DT) André Draszik
2025-05-24 5:21 ` [PATCH v2 1/4] arm64: defconfig: enable Maxim max77759 driver André Draszik
2025-05-25 6:59 ` Peter Griffin
2025-05-24 5:21 ` [PATCH v2 2/4] arm64: dts: exynos: gs101-pixel-common: add Maxim MAX77759 PMIC André Draszik
2025-05-25 7:02 ` Peter Griffin
2025-06-26 19:49 ` Krzysztof Kozlowski
2025-06-27 8:54 ` André Draszik [this message]
2025-06-27 9:12 ` Krzysztof Kozlowski
2025-06-27 9:20 ` André Draszik
2025-05-24 5:21 ` [PATCH v2 3/4] arm64: dts: exynos: gs101-pixel-common: add nvmem-reboot-mode André Draszik
2025-05-25 7:05 ` Peter Griffin
2025-05-24 5:21 ` [PATCH v2 4/4] arm64: dts: exynos: gs101: add dm-verity-device-corrupted syscon-reboot-mode André Draszik
2025-05-25 7:04 ` Peter Griffin
2025-06-25 17:25 ` [PATCH v2 0/4] gs101 max77759 enablement (DT) André Draszik
2025-06-26 13:23 ` Krzysztof Kozlowski
2025-06-27 9:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c3b78d60f3dc3e4576e8b79298e22ea46567c6.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).