From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 601B2277C88 for ; Fri, 27 Jun 2025 08:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751014463; cv=none; b=IeBsxO0U28AZL96mVMaPQrDoOTWwLgcq60dc+RUELizY5p+Wl2liC+1NmnGPic5YUl10AsukxDSYYnHvAW1keX+wQfYN04Zji6FAQ0AR03SmW7uTGEtopwMS9YJGAXBI/0/uyOkKSHg5r57CU5L6lUCMb6Pi/mAg8YCuDsMnYHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751014463; c=relaxed/simple; bh=G/67mhxLuKytL5l5EvWf4Siqtg/clNGoegq0wOXrKnE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=kreYCopBt2zpWGOJnLzczpF1vNTzf29bqcFYXMjhMbD21q+lRrx6YFyZTOhsB7nBodTHEPmKF4Gq1Pxz6jxDmmu9+md0VuZk62TbwpTxkxFsQkwXetb4AcGkEGceZV148SjYMEkgLxMs65L8vNBKb8vAQZlkgQn/gtfBVhR5Opc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iba02Znd; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iba02Znd" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-451d54214adso13118575e9.3 for ; Fri, 27 Jun 2025 01:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751014459; x=1751619259; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=0BS+6uy4su/8ABLs5cJdrouwkh2bvREAZhph1XMTpHE=; b=iba02ZndNDEd8FYkIxmnk0X3mZnW4cYs7zKS8dLT0Aeltvyo8fofDespJ+Nq8ompjG D1uddw91hnsRPH/DNoGBALCrrFfow+lMQxqjgbxw6GqLYhORAVBy6XMrf6KUoxgC7iuo RtH+vr1MNWgySIOXmxJ29Arllq7sXQ23n5jhI4SeLEFg8kPnPRT4DJCM2LsHSa5IvMi+ irrWWPcEV/CCNvXRjkbmr56FHRMtTMPvVMZBpbTBQWVITUbuWj4kG6VzRjESdoeSH88E InbD7swBRHhdZbonyFcx6JuBKfZ0YCrYh8mwIVg5ZSLra/e06iIDPzND/0QRkm5BPJ5O VBgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751014459; x=1751619259; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0BS+6uy4su/8ABLs5cJdrouwkh2bvREAZhph1XMTpHE=; b=MGpzNwdjjliIH0L1OpZiIRGHnIjla5+SN7mGjkm91hfHkgjzZA/zyxuc+9tjDq6MTg dc/XfeF8Fwil1R+vgunwi+y8g3zhrWIjDEErNirVOY/my8OkeM3dG0n1zff11IaC+q9S 4CktXHJouHI8Ur6perzB8y0OabyTFx4WMaezNwQ7o5GzXKYOqzfYPbU099JtuFHrcIWw 4whb1g2QpoDsSTARW2eDtDyBXHRD47P0LIfWas76shq/Ldzl5s3bzoWWBC3udCGN12Dy lss2b7hYA2hhzvXnqLQlRM4my2RPEcr9JrAHxSwZlRy+J8e87n9FwBO6ZSiGNKUYwuCb Z4Kg== X-Forwarded-Encrypted: i=1; AJvYcCWNBkGw+0VAIqIbaLac3AV2I9d+xa1Y3u/LWdaeoyI3pxtMvKKX8/XnirXYi6dm695cyaBcVQySgsjL@vger.kernel.org X-Gm-Message-State: AOJu0YwrQAB9V7frudU3EHvl08Ov4BXbxJ2Rv2uzUX0vtS0g4cvCMkqa k/kHaben/XR88lCBc6r85JOY0yl7HjkCOnuT81S5BdcswgsyZuWiYwZoI1C3NocUhIU= X-Gm-Gg: ASbGnct5aNNFT3XkQepmBb6R/eXMBskdoXqFkSpFxnSClTYxHwd9x7yPN6VSufiaG/E EhbPr5rsoKWCKGX+pXmInrMBWU/bF16lH9fbyAzvJGZR5XIwQTZln0mjGnaCCWZrFqXP1kfNNRD KgBeYOgjeVti7m8L7MUbxRKO1jkY4x2kdej7102Qhdyhrbn8z9BtAD/7IkiS3uf6ykPXePtBCiP jNybbuzm7QyJ7x+hTqGwdD1652PCPkdkD3c2B9Z9D1ZkSmQScHRUbaj9nMJvhIk+garM2E+AKDw /RBxpjlfN2anKYI1eTaS5Fe0Z+YkKufNJHZAQ2QmQ0gSj9xiv7WFlrCAKA6JVxX3Rfk= X-Google-Smtp-Source: AGHT+IE4X30M79feYa1B4IoJp+P/zoAnkDqF1pqfPyj589N4UXNvVInq2V7VnCmuiR3hct5W2E2d9A== X-Received: by 2002:a05:600c:1c87:b0:442:c993:6f94 with SMTP id 5b1f17b1804b1-4538ee59148mr23355875e9.12.1751014458664; Fri, 27 Jun 2025 01:54:18 -0700 (PDT) Received: from [10.1.1.109] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4537c6e2f64sm51190205e9.2.2025.06.27.01.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jun 2025 01:54:18 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 2/4] arm64: dts: exynos: gs101-pixel-common: add Maxim MAX77759 PMIC From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Peter Griffin , Tudor Ambarus , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar Cc: Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Date: Fri, 27 Jun 2025 09:54:16 +0100 In-Reply-To: <2c491166-d8ae-4fb6-a4f7-74e823e1205d@kernel.org> References: <20250524-b4-max77759-mfd-dts-v2-0-b479542eb97d@linaro.org> <20250524-b4-max77759-mfd-dts-v2-2-b479542eb97d@linaro.org> <2c491166-d8ae-4fb6-a4f7-74e823e1205d@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Krzysztof, On Thu, 2025-06-26 at 21:49 +0200, Krzysztof Kozlowski wrote: > On 24/05/2025 07:21, Andr=C3=A9 Draszik wrote: > > + > > + gpio { > > + compatible =3D "maxim,max77759-gpio"; > > + > > + gpio-controller; > > + #gpio-cells =3D <2>; > > + /* > > + * "Human-readable name [SIGNAL_LABEL]" where the > > + * latter comes from the schematic > > + */ > > + gpio-line-names =3D "OTG boost [OTG_BOOST_EN]", > > + =C2=A0 "max20339 IRQ [MW_OVP_INT_L]"; > > + > > + interrupt-controller; > > + #interrupt-cells =3D <2>; > > + }; > > + > > + nvmem-0 { >=20 > Why is this called nvmem-0, not nvmem? Is there nvmem-1? I see binding > does it, but why? 'nvmem' is used/declared by nvmem-consumer.yaml as a phandle array already so using just 'nvmem' fails validation: Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: pmic@66: = nvmem: {'compatible': ['maxim,max77759-nvmem'], 'nvmem- layout': {'compatible': ['fixed-layout'], '#address-cells': 1, '#size-cells= ': 1, 'reboot-mode@0': {'reg': [[0, 4]]}, 'boot-reason@4': {'reg': [[4, 4]]}, 'shutdown-user-flag@8': {'reg': [[8, 1]]}, 'rsoc@10': {'= reg': [[10, 2]]}}} is not of type 'array' from schema $id: http://devicetree.org/schemas/nvmem/nvmem-consumer.yaml# https://lore.kernel.org/all/20250226-max77759-mfd-v2-3-a65ebe2bc0a9@linaro.= org/ Cheers, Andre'